4 files changed, 46 insertions, 19 deletions

diff --git a/pwmanager/pwmanager/libgcryptif.cpp b/pwmanager/pwmanager/libgcryptif.cpp
index ff94bf6..15f6cef 100644
--- a/pwmanager/pwmanager/libgcryptif.cpp
+++ b/pwmanager/pwmanager/libgcryptif.cpp
@@ -43,3 +43,5 @@ PwMerror LibGCryptIf::encrypt(unsigned char **outBuf,
                               size_t keylen,
-                              char _algo)
+                              char _algo,
+                              char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+                              )
 {
@@ -107,3 +109,3 @@ PwMerror LibGCryptIf::encrypt(unsigned char **outBuf,
         hashedKey = new unsigned char[cipherKeylen];
-        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, true);
+        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, true, _hashalgo);
         // so now set the hashed key
@@ -154,3 +156,5 @@ PwMerror LibGCryptIf::decrypt(unsigned char **outBuf,
                               size_t keylen,
-                              char _algo)
+                              char _algo,
+                              char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+)
 {
@@ -203,3 +207,3 @@ PwMerror LibGCryptIf::decrypt(unsigned char **outBuf,
         hashedKey = new unsigned char[cipherKeylen];
-        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, false);
+        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, false, _hashalgo);
         // so now set the hashed key
@@ -316,3 +320,5 @@ bool LibGCryptIf::hashPassphrase(const unsigned char *pw,
                                  size_t keylen,
-                                 bool create)
+                                 bool create,
+                                 char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+)
 {
@@ -324,3 +330,6 @@ bool LibGCryptIf::hashPassphrase(const unsigned char *pw,
         s2k.mode = 1;
-        s2k.hash_algo = mapHashId(conf()->confGlobHashAlgo());
+        //US bug: do not use the global hash algo here. Use the passed ago instead. The hashalgo stored in the file can
+        // be different from the one in the configuration.
+        s2k.hash_algo = mapHashId(_hashalgo //conf()->confGlobHashAlgo()
+                                  );
         s2k.count = 0;
@@ -441,3 +450,3 @@ void LibGCryptIf::unpadData(const unsigned char *buf,
         while (buf[pos] != static_cast<char>(0x01)) {
-        qDebug("pos %d %d %d", pos, buf[pos],   static_cast<char>(0x01)     );
+          //qDebug("pos %d %d %d", pos, buf[pos],   static_cast<char>(0x01)     );
                 BUG_ON(!pos);
@@ -449,3 +458,3 @@ void LibGCryptIf::unpadData(const unsigned char *buf,
         *bufLen = pos;
-    qDebug("ente ");
+        //qDebug("ente ");
 }
diff --git a/pwmanager/pwmanager/libgcryptif.h b/pwmanager/pwmanager/libgcryptif.h
index 1a7b658..9a987a2 100644
--- a/pwmanager/pwmanager/libgcryptif.h
+++ b/pwmanager/pwmanager/libgcryptif.h
@@ -75,3 +75,5 @@ public:
                          size_t keylen,
-                         char _algo);
+                         char _algo,
+                         char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+);
         /** decrypt data. _algo is the PWM_CRYPT_* ID
@@ -85,3 +87,5 @@ public:
                          size_t keylen,
-                         char _algo);
+                         char _algo,
+                         char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+);
         /** hash data. _algo is the PWM_HASH_* ID of the hash */
@@ -126,3 +130,5 @@ protected:
                             size_t keylen,
-                            bool create);
+                            bool create, 
+                         char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+);
         /** hash a passphrase to a cipher key */
diff --git a/pwmanager/pwmanager/pwmdoc.cpp b/pwmanager/pwmanager/pwmdoc.cpp
index 17cb74a..a740d6d 100644
--- a/pwmanager/pwmanager/pwmdoc.cpp
+++ b/pwmanager/pwmanager/pwmdoc.cpp
@@ -489,3 +489,3 @@ PwMerror PwMDoc::saveDoc(char compress, const QString *file)
         }
-        e = encrypt(&serialized, &currentPw, &f, cryptAlgo);
+        e = encrypt(&serialized, &currentPw, &f, cryptAlgo, hashAlgo);
         if (e == e_weakPw) {
@@ -609,3 +609,3 @@ PwMerror PwMDoc::openDoc(const QString *file, int openLocked)
         }
-        ret = decrypt(&decrypted, headerLen, &currentPw, cryptAlgo, &f);
+        ret = decrypt(&decrypted, headerLen, &currentPw, cryptAlgo, dataHashType, &f);
         if (ret == e_cryptNotImpl) {
@@ -1309,3 +1309,5 @@ bool PwMDoc::decompressDta(string *d, char algo)
 
-PwMerror PwMDoc::encrypt(string *d, const QString *pw, QFile *f, char algo)
+PwMerror PwMDoc::encrypt(string *d, const QString *pw, QFile *f, char algo,
+                                 char hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+)
 {
@@ -1350,3 +1352,5 @@ PwMerror PwMDoc::encrypt(string *d, const QString *pw, QFile *f, char algo)
                                  pw->length(),
-                                 algo);
+                                 algo,
+                                 hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+                                 );
                 delete [] plain;
@@ -1373,3 +1377,5 @@ PwMerror PwMDoc::encrypt(string *d, const QString *pw, QFile *f, char algo)
 PwMerror PwMDoc::decrypt(string *d, unsigned int pos, const QString *pw,
-                         char algo, QFile *f)
+                         char algo, 
+                         char hashalgo, //US BUG: pass _hashalgo because we need it in hashPassphrase
+                         QFile *f)
 {
@@ -1425,3 +1431,5 @@ PwMerror PwMDoc::decrypt(string *d, unsigned int pos, const QString *pw,
                                  pw->length(),
-                                 algo);
+                                 algo,
+                                 hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+);
                 if (err != e_success) {
diff --git a/pwmanager/pwmanager/pwmdoc.h b/pwmanager/pwmanager/pwmdoc.h
index 138dd3d..9fcdda7 100644
--- a/pwmanager/pwmanager/pwmdoc.h
+++ b/pwmanager/pwmanager/pwmdoc.h
@@ -738,5 +738,9 @@ protected:
         /** encrypt data "d" and write to "filename" */
-        PwMerror encrypt(string *d, const QString *pw, QFile *f, char algo);
+        PwMerror encrypt(string *d, const QString *pw, QFile *f, char algo,
+                                 char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+);
         /** read data from file beginning at "pos", decrypt and return it */
-        PwMerror decrypt(string *d, unsigned int pos, const QString *pw, char algo, QFile *f);
+        PwMerror decrypt(string *d, unsigned int pos, const QString *pw, char algo, 
+                 char _hashalgo, //US BUG: pass _hashalgo because we need it in hashPassphrase
+QFile *f);
         /** compress the data */