2 files changed, 63 insertions, 46 deletions

diff --git a/korganizer/kofilterview.cpp b/korganizer/kofilterview.cpp
index 20118aa..1335d7e 100644
--- a/korganizer/kofilterview.cpp
+++ b/korganizer/kofilterview.cpp
@@ -111,119 +111,127 @@ void KOFilterView::setSelectedFilter( int fil )
 
 KOCalEditView::KOCalEditView(QWidget* parent,
                            const char* name )
   : QScrollView(parent,name)
 {
     mw = 0; 
     setResizePolicy( AutoOneFit );
     setFrameStyle ( QFrame::Panel | QFrame::Plain );
     setLineWidth ( 1 ); 
     setMidLineWidth ( 1 ); 
     setFocusPolicy(NoFocus); 
 }
 
 KOCalEditView::~KOCalEditView()
 {
     // no need to delete child widgets, Qt does it all for us
 }
 void KOCalEditView::selectCal(int id ,bool b)
 {
     KOPrefs::instance()->getCalendar( id )->isEnabled = b;
     emit calendarEnabled ( id, b );
     emit needsUpdate();
 
 }
-void KOCalEditView::selectStdCal( int id, bool b )
+void KOCalEditView::selectStdCal( int id  )
 {
-
-    if ( !b ) {
-        KOCalCheckButton* it = (KOCalCheckButton*) sender();
-        if ( it ) {
-            it->blockSignals( true );
-            it->setChecked( true );
-            it->blockSignals( false );
-            return;
-        }
-        return;
-    }
-    KOCalRadioButton* sen = (KOCalRadioButton*) sender();
     KOCalRadioButton* it = mStdandardB.first();
     while ( it ) {
-        if ( it->isChecked() ) {
-            if ( it != sen ) {
-                it->blockSignals( true );
-                it->setChecked( false );
-                it->blockSignals( false );
-                break;
-            }
-        }
+        it->blockSignals( true );
+        it->setChecked( it->num() == id );
+        it->blockSignals( false );
         it = mStdandardB.next();
     }
    KopiCalendarFile * kkf = KOPrefs::instance()->mCalendars.first();
     while ( kkf ) {
-        kkf->isStandard = false;
+        kkf->isStandard = (kkf->mCalNumber == id );
         kkf = KOPrefs::instance()->mCalendars.next();
     }
-    KOPrefs::instance()->getCalendar( id )->isStandard = true;
     emit setCalendarDefault ( id );
 }
 
 void KOCalEditView::selectCalAlarm(int id ,bool b )
 {
     KOPrefs::instance()->getCalendar( id )->isAlarmEnabled = b;
     emit alarmEnabled ( id , b );
     emit needsUpdate();
 }
 void KOCalEditView::selectReadOnly(int id ,bool b )
 {
     KOPrefs::instance()->getCalendar( id )->isReadOnly = b;
     emit calendarReadonly ( id , b );
-    if ( KOPrefs::instance()->getCalendar( id )->isStandard && b && id > 1 ) {
-        KOPrefs::instance()->getCalendar( id )->isStandard = false;
-        KOPrefs::instance()->getCalendar( 1 )->isStandard = true;
-        mStdandardB.at(0)->setChecked( true );
-        mStdandardB.at(id-1)->setChecked( false );
-        emit setCalendarDefault ( 1 );
+    if ( KOPrefs::instance()->getCalendar( id )->isStandard && b ) {
+        findNewStandard(); 
+    } else {
+        if ( !b ){
+            KopiCalendarFile * kkf = KOPrefs::instance()->mCalendars.first();
+            while ( kkf ) {
+                if (kkf->isReadOnly && kkf->isStandard ) {
+                    selectStdCal( id );
+                    break;
+                }
+                kkf = KOPrefs::instance()->mCalendars.next();
+            }
+        }
     }
     mStdandardB.at(id-1)->setEnabled( !b );
     emit needsUpdate();
     
 }
+void KOCalEditView::findNewStandard()
+{ 
+    bool found = false;
+    KopiCalendarFile * kkf = KOPrefs::instance()->mCalendars.first();
+    while ( kkf ) {
+        if (!kkf->isReadOnly && !kkf->mErrorOnLoad ) {
+            found = true;
+            selectStdCal( kkf->mCalNumber );
+            break;
+        }
+        kkf = KOPrefs::instance()->mCalendars.next();
+    }
+    if ( !found ) {
+        KMessageBox::error( this,i18n("\nNO\n WRITEABLE\n   CALENDAR\n      FOUND!\n\nPlease fix your calendar settings!\n"),
+                    i18n("Houston, we have a problem!") );
+
+    }
+}
+
 void KOCalEditView::setColor( const QColor& c, int id )
 {
     KOPrefs::instance()->getCalendar( id )->mDefaultColor = c;
     emit needsUpdate();
 }
 void KOCalEditView::deleteCal( int id )
 {
     KopiCalendarFile * kkf = KOPrefs::instance()->getCalendar( id );
     QString name = kkf->mName;
     QString file = KGlobal::formatMessage ( kkf->mFileName ,0 );
     if ( KMessageBox::warningContinueCancel( this,  i18n("The calendar <b>%1</b> is displaying file <b>%2</b>. Do you want to remove this calendar from KO/Pi? (The file is not removed!)").arg(name).arg(file) ) != KMessageBox::Continue ) return;
-    if ( kkf->isStandard )
-        selectStdCal( 1, true );
+    bool findnewstd =  kkf->isStandard;
     emit removeCalendar ( id );
     KOPrefs::instance()->mCalendars.remove ( kkf );
+    if ( findnewstd  ) findNewStandard();
     emit needsUpdate();
     QTimer::singleShot( 0, this, SLOT ( readConfig() ) ); 
 }
 void KOCalEditView::infoCal( int id )
 {
     QString name = KOPrefs::instance()->getCalendar( id )->mName;
     QString file = KGlobal::formatMessage ( KOPrefs::instance()->getCalendar( id )->mFileName, 0 );
     if ( KOPrefs::instance()->getCalendar( id )->mErrorOnLoad ) {
         if (  KMessageBox::Yes == KMessageBox::questionYesNo( this,  i18n("The calendar <b>%1</b> is not loaded! Loading of file <b>%2</b> failed! <b>Try again to load the calendar?</b>").arg(name).arg(file) ) ) {
             emit calendarAdded( id );
             emit needsUpdate();
             QTimer::singleShot( 0, this, SLOT ( readConfig() ) ); 
             QTimer::singleShot( 100, this, SIGNAL ( checkCalendar() ) ); 
         }
     }
     else
         KMessageBox::information( this,  i18n("The calendar <b>%1</b> is displaying file <b>%2</b>").arg(name).arg(file) );
 }
 void KOCalEditView::readConfig() 
 {
     
     mStdandardB.clear();
     mEnabledB.clear();
     mAlarmB.clear();
@@ -263,109 +271,113 @@ void KOCalEditView::readConfig()
     connect(addBut,SIGNAL(clicked()),SLOT(enableAlarm()));
     addBut->setMaximumWidth( addBut->sizeHint().height() );
 
     addBut = new QPushButton ( mw );
     addBut->setFocusPolicy(NoFocus); 
     mainLayout->addWidget( addBut,0,++ii );
     addBut->setPixmap ( SmallIcon("pencil"));
     connect(addBut,SIGNAL(clicked()),SLOT(disableRO()));
     addBut->setMaximumWidth( addBut->sizeHint().height() );
     lab = new QLabel ( "", mw );
     mainLayout->addWidget( lab,0,++ii );
 
     addBut = new QPushButton ( mw );
     addBut->setFocusPolicy(NoFocus); 
     mainLayout->addWidget( addBut,0,++ii );
     addBut->setPixmap ( SmallIcon("plus"));
     connect(addBut,SIGNAL(clicked()),SLOT(addCal()));
 
     lab = new QLabel ( " ", mw );
     mainLayout->addWidget( lab,0,++ii );
 
 
     KopiCalendarFile * kkf = KOPrefs::instance()->mCalendars.first();
     int row = 1;
+    bool errorLoadStandard = false;
     while ( kkf ) {
         int iii = 0;
         KOCalRadioButton* rb = new KOCalRadioButton( mw );
         mainLayout->addWidget( rb,row,0 );mStdandardB.append( rb );
         rb->setChecked( kkf->isStandard );
+        if ( kkf->isStandard && ( kkf->mErrorOnLoad || kkf->isReadOnly ) )
+            errorLoadStandard = true;
         rb->setNum( kkf->mCalNumber );
-        connect (rb, SIGNAL (selectNum(int,bool)), SLOT ( selectStdCal(int,bool) ) );
+        connect (rb, SIGNAL (selectNum(int)), SLOT ( selectStdCal(int) ) );
         if ( kkf->mErrorOnLoad ||  kkf->isReadOnly )
             rb->setEnabled( false );
         KOCalCheckButton* cb = new KOCalCheckButton( mw );
         mainLayout->addWidget( cb,row,++iii );mEnabledB.append( cb );
-        cb->setChecked( kkf->isEnabled );
+        cb->setChecked( kkf->isEnabled && !kkf->mErrorOnLoad );
         cb->setNum( kkf->mCalNumber );
         if ( kkf->mErrorOnLoad )
             cb->setEnabled( false );
         connect (cb, SIGNAL (selectNum(int,bool)), SLOT ( selectCal(int,bool) ) );
         KOCalButton* name = new KOCalButton( mw );
         name->setNum( kkf->mCalNumber );
         name->setText(  kkf->mName );
         mainLayout->addWidget( name,row,++iii );
         connect (name, SIGNAL (selectNum(int)), SLOT ( infoCal(int) ) );
         //lab = new QLabel (" ", mw );
         //mainLayout->addWidget( lab,row,++iii );
         cb = new KOCalCheckButton( mw );
         mainLayout->addWidget( cb,row,++iii );mAlarmB.append( cb );
-        cb->setChecked( kkf->isAlarmEnabled );
+        cb->setChecked( kkf->isAlarmEnabled && !kkf->mErrorOnLoad);
         cb->setNum( kkf->mCalNumber );
         connect (cb, SIGNAL (selectNum(int,bool)), SLOT ( selectCalAlarm(int,bool) ) );
         if ( kkf->mErrorOnLoad )
             cb->setEnabled( false );
         cb = new KOCalCheckButton( mw );
         mainLayout->addWidget( cb,row,++iii );mROB.append( cb );
         cb->setChecked( kkf->isReadOnly );
         cb->setNum( kkf->mCalNumber );
         connect (cb, SIGNAL (selectNum(int,bool)), SLOT ( selectReadOnly(int,bool) ) );
         if ( kkf->mErrorOnLoad )
             cb->setEnabled( false );
         if ( row > 1) {
             KColorButton *colb = new KColorButton( mw );
             mainLayout->addWidget( colb,row,++iii );
             colb->setID( kkf->mCalNumber );
             colb->setColor( kkf->mDefaultColor );
             connect (colb, SIGNAL (changedID(const QColor&, int )), SLOT ( setColor(const QColor&,int) ) );
             KOCalButton* calb = new KOCalButton( mw );
             mainLayout->addWidget( calb,row,++iii );
             calb->setNum( kkf->mCalNumber );
             calb->setPixmap ( SmallIcon("minus"));
             connect (calb, SIGNAL (selectNum(int)), SLOT ( deleteCal(int) ) );
             int hei = calb->sizeHint().height();
             //calb->setMaximumSize( hei*9/10, hei*9/10 );
         }
         ++row;
         kkf = KOPrefs::instance()->mCalendars.next();
     }
+    if ( errorLoadStandard ) 
+        findNewStandard();
     lab = new QLabel (  "", mw );
     mainLayout->addWidget( lab,row,0 );
     mw->show();
 
 }
 
-
 void KOCalEditView::defaultInfo()
 {
     KMessageBox::information( this,  i18n("Please choose the <b>default calendar</b> in this column. Newly created or imported items are added to the default calendar.") ); 
 }
 void KOCalEditView::addCal()
 {
     bool tryagain = true;
     QString name, file;
     while ( tryagain ) {
         KONewCalPrefs prefs ( this ); 
         prefs.nameE->setText( name );
         prefs.url->setURL( file );
         if ( !  prefs.exec() )
             return;
         name = prefs.calName();
         file = prefs.calFileName();
         tryagain = false;
         KopiCalendarFile * kkf = KOPrefs::instance()->mCalendars.first();
         while ( kkf ) {
             if ( kkf->mName == name ) {
                 KMessageBox::information( this,  i18n("Sorry, the calendar name \n%1\nalready exists!\nPlease choose another name!").arg( name ) ); 
                 name = "";
                 tryagain = true;  
                 break;
@@ -410,47 +422,48 @@ int KOCalEditView::addCalendar( QString name, QString file, bool ask )
     return kkf->mCalNumber;
 }
 int KOCalEditView::getBirtdayID()
 {
     KopiCalendarFile * kkf = KOPrefs::instance()->mCalendars.first();
     while ( kkf ) {
         if ( kkf->mName == i18n("Birthdays") )
             return kkf->mCalNumber;
         kkf = KOPrefs::instance()->mCalendars.next();
     }
     QString file = locateLocal( "data", "korganizer/birthdays.ics" ); 
     return addCalendar( i18n("Birthdays"), file, false );
 }
 
 void KOCalEditView::enableAll()
 {
     toggleList( mEnabledB );
 }
 void KOCalEditView::enableAlarm()
 {
     toggleList( mAlarmB );
 }
 void KOCalEditView::disableRO()
 {
-    toggleList( mROB );
+    toggleList( mROB, false );
 }
-void KOCalEditView::toggleList ( QPtrList<KOCalCheckButton> list )
+void KOCalEditView::toggleList ( QPtrList<KOCalCheckButton> list , bool enable )
 {
-    bool dis = false;
+    bool dis = !enable;
     KOCalCheckButton* it = list.first();
     while ( it ) {
-        if ( !it->isChecked() ) {
-            dis = true;
+        if ( !it->isChecked() == enable && it->isEnabled() ) {
+            dis = !dis;
             break;
         }
         it = list.next();
     }
     it = list.first();
     while ( it ) {
-        it->setChecked(dis);
+        if ( it->isEnabled() )
+            it->setChecked(dis);
         it = list.next();
     }  
 }
 void KOCalEditView::deleteAll()
 {
     qDebug("delteAll");
 }
diff --git a/korganizer/kofilterview.h b/korganizer/kofilterview.h
index 02107cf..874fc6a 100644
--- a/korganizer/kofilterview.h
+++ b/korganizer/kofilterview.h
@@ -49,49 +49,51 @@ class KONewCalPrefs : public QDialog
 {
     Q_OBJECT 
   public:
     KONewCalPrefs( QWidget *parent=0, const char *name=0 ) :
       QDialog( parent, name, true ) 
     {
         setCaption( i18n("Add new Calendar") );
         QVBoxLayout* lay = new QVBoxLayout( this );
         lay->setSpacing( 3 );
         lay->setMargin( 3 );
         QLabel * lab = new QLabel( i18n("<b>Name of new calendar:</b>"), this );
         lay->addWidget( lab ); 
         nameE = new KLineEdit( this );
         lay->addWidget( nameE ); 
         lab = new QLabel( i18n("<b>Local ical (*.ics) file:</b>"), this );
         lay->addWidget( lab ); 
         url = new KURLRequester ( this );
         lay->addWidget( url ); 
         QPushButton * ok = new QPushButton( i18n("OK"), this );
         lay->addWidget( ok );
         QPushButton * cancel = new QPushButton( i18n("Cancel"), this );
         lay->addWidget( cancel );
         connect ( ok,SIGNAL(clicked() ),this , SLOT ( checkValid() )  );
         connect (cancel, SIGNAL(clicked() ), this, SLOT ( reject())  );
-        setMinimumWidth( 220 );
+        int minwid = 220;
+        if ( QApplication::desktop()->width() >= 320 ) minwid = 300;
+        setMinimumWidth(  minwid );
         resize(sizeHint() );
     }
       
     QString calName() { return nameE->text(); }
     QString calFileName() { return url->url(); }
 
 public slots:
 void checkValid() {
     if ( nameE->text().isEmpty() ) {
         KMessageBox::information( this,  i18n("Sorry, the calendar name is empty!") ); 
         nameE->setText( "LPQJ_"+ QString::number( QTime::currentTime().msec () ));
         return;
     } 
     if ( url->url().isEmpty() ) {
         KMessageBox::information( this,  i18n("Sorry, the file name is empty!") ); 
         return;
     }
     accept();
 }
            
 public:
     KLineEdit* nameE;
     KURLRequester *url;
 };
@@ -142,109 +144,111 @@ private:
     int mNumber;
     void keyPressEvent ( QKeyEvent * e )
     {
         e->ignore();     
     }
 
 private slots :
     void bottonClicked( bool b) { if ( mNumber > 0 ) emit selectNum ( mNumber , b); }
 };
 
 class KOCalRadioButton : public QRadioButton
 {
     Q_OBJECT
   public:
     KOCalRadioButton( QWidget *parent=0, const char *name=0 ) :
       QRadioButton( parent, name) 
     {
       connect( this, SIGNAL( toggled ( bool ) ),
                SLOT( bottonClicked( bool ) )); 
       mNumber = -1;
       setFocusPolicy(NoFocus); 
       //setMaximumWidth( 10 );
 
     }
+        int num() { return mNumber;}
     void setNum ( int num ) {mNumber = num; }
     signals:
-    void selectNum ( int, bool );
+    void selectNum ( int );
 private: 
     int mNumber;
     void keyPressEvent ( QKeyEvent * e )
     {
         e->ignore();     
     }
 
 private slots :
-    void bottonClicked( bool b) { if ( mNumber > 0 ) emit selectNum ( mNumber , b); }
+    void bottonClicked( bool b) { if ( mNumber > 0  ) emit selectNum ( mNumber); }
 };
 
 
 
 class KOFilterView : public KOFilterView_base
 {
     Q_OBJECT
   public:
     KOFilterView(QPtrList<CalFilter> *filterList,QWidget* parent=0,const char* name=0, WFlags fl=0);
     ~KOFilterView();
 
     void updateFilters();
 
     bool filtersEnabled();
     void setFiltersEnabled(bool);
     CalFilter *selectedFilter();
     void setSelectedFilter(QString);
     void setSelectedFilter( int );
 
   signals:
     void filterChanged();
     void editFilters();
 
   private:
     QPtrList<CalFilter> *mFilters;
 };
 
 class KOCalEditView : public QScrollView
 {
     Q_OBJECT
   public:
     KOCalEditView( QWidget* parent=0,const char* name=0);
     ~KOCalEditView();
     int addCalendar( QString calName, QString fileName, bool ask = true );
     int getBirtdayID();
     public slots:
     void addCal();
     void enableAll();
     void enableAlarm();
     void disableRO();
     void deleteAll();
-    void selectStdCal(int,bool );
+    void selectStdCal(int);
     void selectCal(int,bool );
     void selectCalAlarm(int,bool );
     void selectReadOnly(int,bool );
     void setColor(const QColor &,int) ;
     void deleteCal(int) ;
     void infoCal(int) ;
     void readConfig(); 
     void defaultInfo();
+    void findNewStandard();
   signals:
     void alarmEnabled ( int cal, bool enable );
     void calendarEnabled ( int cal, bool enable );
     void calendarReadonly ( int cal, bool readonly );
     void setCalendarDefault ( int cal );
     void removeCalendar ( int cal );
     void calendarAdded( int );
     void needsUpdate();
     void checkCalendar();
 
   private:
     QWidget *mw;
-    void toggleList ( QPtrList<KOCalCheckButton> );
+    void toggleList ( QPtrList<KOCalCheckButton> , bool b = true );
     QPtrList<KOCalRadioButton> mStdandardB;
     QPtrList<KOCalCheckButton> mEnabledB;
     QPtrList<KOCalCheckButton> mAlarmB;
     QPtrList<KOCalCheckButton> mROB;
     QGridLayout* mainLayout; 
 };
 
 
 
 #endif // KOFILTERVIEW_H