8 files changed, 113 insertions, 32 deletions

diff --git a/kaddressbook/addresseeeditorwidget.cpp b/kaddressbook/addresseeeditorwidget.cpp
index 3397e06..c6993e9 100644
--- a/kaddressbook/addresseeeditorwidget.cpp
+++ b/kaddressbook/addresseeeditorwidget.cpp
@@ -982,9 +982,9 @@ void AddresseeEditorWidget::load()
   if ( mAddressee.formattedName().isEmpty() ) {
 //US    KConfig config( "kaddressbookrc" );
-    KConfig config( locateLocal("config", "kaddressbookrc") );
+    KConfig config( locateLocal("config", "kabcrc") );
     config.setGroup( "General" );
     mFormattedNameType = config.readNumEntry( "FormattedNameType", 1 );
     mAddressee.setFormattedName( NameEditDialog::formattedName( mAddressee, mFormattedNameType ) );
-  } else {
+  } else {;
     if ( mAddressee.formattedName() == NameEditDialog::formattedName( mAddressee, NameEditDialog::SimpleName ) )
       mFormattedNameType = NameEditDialog::SimpleName;
@@ -1186,4 +1186,6 @@ bool AddresseeEditorWidget::dirty()
 void AddresseeEditorWidget::nameTextChanged( const QString &text )
 {
+    if ( mBlockSignals )
+        return;
   // use the addressee class to parse the name for us
     mAConfig->setUid( mAddressee.uid() );
diff --git a/kaddressbook/extensionmanager.cpp b/kaddressbook/extensionmanager.cpp
index 98561dc..efbdf17 100644
--- a/kaddressbook/extensionmanager.cpp
+++ b/kaddressbook/extensionmanager.cpp
@@ -59,4 +59,5 @@ ExtensionManager::ExtensionManager( KABCore *core, QWidget *parent,
            SLOT( setActiveExtension( int ) ) );
   mWidgetBox = new QWidget( viewport() );
+  new QHBoxLayout (mWidgetBox  );
   addChild( mWidgetBox );
   setResizePolicy(AutoOneFit);
@@ -159,5 +160,5 @@ void ExtensionManager::createExtensionWidgets()
   // add addressee editor as default
 
-  QHBoxLayout *hbl = new QHBoxLayout (mWidgetBox  );
+  QHBoxLayout *hbl = (QHBoxLayout *) mWidgetBox->layout();;
 
   wdg = new AddresseeEditorWidget( mCore, true, mWidgetBox );
@@ -181,5 +182,5 @@ void ExtensionManager::createExtensionWidgets()
     KLibFactory *factory = KLibLoader::self()->factory( (*it)->library().latin1() );
     if ( !factory ) {
-      kdDebug(5720) << "ExtensionManager::loadExtensions(): Factory creation failed" << endl;
+        //kdDebug(5720) << "ExtensionManager::loadExtensions(): Factory creation failed" << endl;
       continue;
     }
@@ -188,5 +189,5 @@ void ExtensionManager::createExtensionWidgets()
 
     if ( !extensionFactory ) {
-      kdDebug(5720) << "ExtensionManager::loadExtensions(): Cast failed" << endl;
+        //kdDebug(5720) << "ExtensionManager::loadExtensions(): Cast failed" << endl;
       continue;
     }
diff --git a/kaddressbook/filter.cpp b/kaddressbook/filter.cpp
index b0d04ca..39d2ae4 100644
--- a/kaddressbook/filter.cpp
+++ b/kaddressbook/filter.cpp
@@ -181,15 +181,16 @@ Filter::List Filter::restore( KConfig *config, QString baseGroup )
   }
 
-  QStringList cats = KABPrefs::instance()->mCustomCategories;
-  for ( QStringList::Iterator it = cats.begin(); it != cats.end(); ++it ) {
-    Filter filter;
-    filter.mName = *it;
-    filter.mEnabled = true;
-    filter.mCategoryList = *it;
-    filter.mMatchRule = Matching;
-    filter.mInternal = true;
-    list.append( filter );
+  if ( list.isEmpty()) {
+      QStringList cats = KABPrefs::instance()->mCustomCategories;
+      for ( QStringList::Iterator it = cats.begin(); it != cats.end(); ++it ) {
+          Filter filter;
+          filter.mName = *it;
+          filter.mEnabled = true;
+          filter.mCategoryList = *it;
+          filter.mMatchRule = Matching;
+          filter.mInternal = true;
+          list.append( filter );
+      }
   }
-
   return list;
 }
diff --git a/kaddressbook/kabcore.cpp b/kaddressbook/kabcore.cpp
index e14e579..c6288fa 100644
--- a/kaddressbook/kabcore.cpp
+++ b/kaddressbook/kabcore.cpp
@@ -152,4 +152,5 @@ $Id$
 #include "extensionmanager.h"
 #include "addresseeconfig.h"
+#include "nameeditdialog.h"
 #include <kcmultidialog.h>
 
@@ -197,4 +198,39 @@ private:
 };
 
+class KABFormatPrefs : public QDialog
+{
+  public:
+    KABFormatPrefs( QWidget *parent=0, const char *name=0 ) :
+      QDialog( parent, name, true ) 
+    {
+        setCaption( i18n("Set formatted name") );
+        QVBoxLayout* lay = new QVBoxLayout( this );
+        lay->setSpacing( 3 );
+        lay->setMargin( 3 );
+        QLabel * lab = new QLabel( i18n("You can set the formatted name\nfor a list of contacts in one go."), this );
+        lay->addWidget( lab ); 
+        QButtonGroup* format = new QButtonGroup( 1, Horizontal, i18n("Set formatted name to:"), this );
+        lay->addWidget( format ); 
+        format->setExclusive ( true ) ;
+        simple = new QRadioButton(i18n("Simple: James Bond"), format );
+        full = new QRadioButton(i18n("Full: Mr. James 007 Bond I"), format );
+        reverse = new QRadioButton(i18n("Reverse: Bond, James"), format );
+        company = new QRadioButton(i18n("Organization: MI6"), format );
+        simple->setChecked( true );
+        setCompany = new QCheckBox(i18n("Set formatted name to\norganization, if name empty"), this);
+        lay->addWidget( setCompany );
+        QPushButton * ok = new QPushButton( i18n("Select contact list"), this );
+        lay->addWidget( ok );
+        QPushButton * cancel = new QPushButton( i18n("Cancel"), this );
+        lay->addWidget( cancel );
+        connect ( ok,SIGNAL(clicked() ),this , SLOT ( accept() )  );
+        connect (cancel, SIGNAL(clicked() ), this, SLOT ( reject())  );
+        resize( 200, 200 );
+    }
+public:
+    QRadioButton* simple, *full, *reverse, *company;
+    QCheckBox* setCompany;
+};
+
 
 
@@ -1147,5 +1183,10 @@ bool KABCore::modified() const
 }
 
-void KABCore::contactModified( const KABC::Addressee &addr )
+void KABCore::contactModified( const KABC::Addressee &addr  )
+{
+    addrModified( addr );
+}
+
+void KABCore::addrModified( const KABC::Addressee &addr ,bool updateDetails )
 {
 
@@ -1164,5 +1205,6 @@ void KABCore::contactModified( const KABC::Addressee &addr )
   UndoStack::instance()->push( command );
   RedoStack::instance()->clear();
-  mDetails->setAddressee( addr );
+  if ( updateDetails )
+      mDetails->setAddressee( addr );
   setModified( true );
 }
@@ -1542,5 +1584,5 @@ void KABCore::openConfigDialog()
 
     connect( ConfigureDialog, SIGNAL( applyClicked() ),
-             this, SLOT( configurationChanged() ) );
+           this, SLOT( configurationChanged() ) );
     connect( ConfigureDialog, SIGNAL( okClicked() ),
              this, SLOT( configurationChanged() ) );
@@ -1997,4 +2039,7 @@ void KABCore::initActions()
                                     SLOT( removeVoice() ), actionCollection(),
                                    "remove_voice" );
+  mActionSetFormattedName = new KAction( i18n( "Set formatted name..." ), 0, this,
+                                    SLOT( setFormattedName() ), actionCollection(),
+                                   "set_formatted" );
 
   mActionManageCategories= new KAction( i18n( "Manage new categories..." ), 0, this,
@@ -2137,4 +2182,5 @@ void KABCore::addActionsManually()
   mActionSelectAll->plug( editMenu );
 
+  mActionSetFormattedName->plug( changeMenu );
   mActionRemoveVoice->plug( changeMenu );
   // settings menu
@@ -2303,9 +2349,40 @@ void KABCore::removeVoice()
     for ( it = list.begin(); it != list.end(); ++it ) {
         if ( (*it).removeVoice() )
-            contactModified((*it) );
+            addrModified((*it), false );
     }
 }
 
-
+void KABCore::setFormattedName()
+{
+    KABFormatPrefs setpref;
+    if ( !setpref.exec() ) {
+        return;
+    }
+    KABC::Addressee::List list;
+    XXPortSelectDialog dlg( this, false, this );
+    if ( dlg.exec() )
+        list = dlg.contacts();
+    else
+        return;
+    KABC::Addressee::List::Iterator it;
+    for ( it = list.begin(); it != list.end(); ++it ) {
+        QString fName;
+        if ( setpref.simple->isChecked() )
+            fName = NameEditDialog::formattedName( (*it), NameEditDialog::SimpleName );
+        else if ( setpref.full->isChecked() )
+            fName = NameEditDialog::formattedName( (*it), NameEditDialog::FullName );
+        else if ( setpref.reverse->isChecked() )
+            fName = NameEditDialog::formattedName( (*it), NameEditDialog::ReverseName );
+        else 
+            fName = (*it).organization();
+        if ( setpref.setCompany->isChecked() )
+            if ( fName.isEmpty() || fName =="," )
+                fName = (*it).organization();
+        (*it).setFormattedName( fName );
+        addrModified((*it),false );
+    }
+    Addressee add;
+    mDetails->setAddressee( add );
+}
 
 void KABCore::clipboardDataChanged()
diff --git a/kaddressbook/kabcore.h b/kaddressbook/kabcore.h
index 85ffbdb..0d5891e 100644
--- a/kaddressbook/kabcore.h
+++ b/kaddressbook/kabcore.h
@@ -279,4 +279,5 @@ class KABCore : public QWidget, public KSyncInterface
      */
     void contactModified( const KABC::Addressee &addr );
+    void addrModified( const KABC::Addressee &addr, bool updateDetails = true );
 
     /**
@@ -374,4 +375,5 @@ class KABCore : public QWidget, public KSyncInterface
     void configureKeyBindings();
     void removeVoice();
+    void setFormattedName();
 #ifdef KAB_EMBEDDED
     void configureResources();
@@ -478,4 +480,5 @@ class KABCore : public QWidget, public KSyncInterface
     //LR additional methods
     KAction *mActionRemoveVoice;
+    KAction *mActionSetFormattedName;
     KAction * mActionImportOL;
 
diff --git a/kaddressbook/kabprefs.cpp b/kaddressbook/kabprefs.cpp
index db123da..a2095d4 100644
--- a/kaddressbook/kabprefs.cpp
+++ b/kaddressbook/kabprefs.cpp
@@ -61,5 +61,5 @@ KABPrefs::KABPrefs()
   addItemBool("ToolBarHor",&mToolBarHor, true );
   addItemBool("ToolBarUp",&mToolBarUp, false );
-  addItemBool("SearchWithReturn",&mSearchWithReturn, true );
+  addItemBool("SearchWithReturn",&mSearchWithReturn, false );
   addItemFont("DetailsFont",&mDetailsFont);
 
diff --git a/kaddressbook/kcmconfigs/addresseewidget.cpp b/kaddressbook/kcmconfigs/addresseewidget.cpp
index eb5bdd9..168d39e 100644
--- a/kaddressbook/kcmconfigs/addresseewidget.cpp
+++ b/kaddressbook/kcmconfigs/addresseewidget.cpp
@@ -219,12 +219,10 @@ void AddresseeWidget::restoreSettings()
   mInclusion->setNameParts( config.readListEntry( "Inclusions" ) );
   mSuffix->setNameParts( config.readListEntry( "Suffixes" ) );
-
-  KConfig cfg( locateLocal("config","kaddressbookrc") );
-  cfg.setGroup( "General" );
-  mFormattedNameCombo->setCurrentItem( cfg.readNumEntry( "FormattedNameType", 1 ) );
+  mFormattedNameCombo->setCurrentItem( config.readNumEntry( "FormattedNameType", 1 ) );
 }
 
 void AddresseeWidget::saveSettings()
 {
+    qDebug("AddresseeWidget::saveSettings() ");
   KConfig config( locateLocal("config","kabcrc") );
   config.setGroup( "General" );
@@ -233,8 +231,5 @@ void AddresseeWidget::saveSettings()
   config.writeEntry( "Inclusions", mInclusion->nameParts() );
   config.writeEntry( "Suffixes", mSuffix->nameParts() );
-
-  KConfig cfg( locateLocal("config","kaddressbookrc") );
-  cfg.setGroup( "General" );
-  cfg.writeEntry( "FormattedNameType", mFormattedNameCombo->currentItem() );
+  config.writeEntry( "FormattedNameType", mFormattedNameCombo->currentItem() );
 }
 
diff --git a/kaddressbook/nameeditdialog.cpp b/kaddressbook/nameeditdialog.cpp
index 8213c2b..f5dba0f 100644
--- a/kaddressbook/nameeditdialog.cpp
+++ b/kaddressbook/nameeditdialog.cpp
@@ -226,15 +226,16 @@ bool NameEditDialog::changed() const
 QString NameEditDialog::formattedName( const KABC::Addressee &addr, int type )
 {
+    QString retval;
   switch ( type ) {
     case SimpleName:
-      return addr.givenName() + " " + addr.familyName();
+      retval = addr.givenName() + " " + addr.familyName();
       break;
     case FullName:
-      return addr.prefix() + " " + addr.givenName() + " " +
+      retval =addr.prefix() + " " + addr.givenName() + " " +
              addr.additionalName() + " " + addr.familyName() + " " +
              addr.suffix();
       break;
     case ReverseName:
-      return addr.familyName() + ", " + addr.givenName();
+      retval = addr.familyName() + ", " + addr.givenName();
       break;
     default:
@@ -242,4 +243,5 @@ QString NameEditDialog::formattedName( const KABC::Addressee &addr, int type )
       break;
   }
+  return retval.stripWhiteSpace ();
 }