1 files changed, 18 insertions, 4 deletions

diff --git a/kabc/vcardparser/vcardtool.cpp b/kabc/vcardparser/vcardtool.cpp
index 01c5b3e..71f29d7 100644
--- a/kabc/vcardparser/vcardtool.cpp
+++ b/kabc/vcardparser/vcardtool.cpp
@@ -58,99 +58,110 @@ VCardTool::VCardTool()
   mPhoneTypeMap.insert( "PCS", PhoneNumber::Pcs );
   mPhoneTypeMap.insert( "PAGER", PhoneNumber::Pager );
 }
 
 VCardTool::~VCardTool()
 {
 }
 
 QString VCardTool::createVCards( Addressee::List list, VCard::Version version )
 {
   VCard::List vCardList;
 
   Addressee::List::Iterator addrIt;
   for ( addrIt = list.begin(); addrIt != list.end(); ++addrIt ) {
     VCard card;
     QStringList::ConstIterator strIt;
 
     // ADR + LABEL
     Address::List addresses = (*addrIt).addresses();
     for ( Address::List::Iterator it = addresses.begin(); it != addresses.end(); ++it ) {
       QStringList address;
 
 /*US       
       address.append( (*it).postOfficeBox().replace( ';', "\\;" ) );
       address.append( (*it).extended().replace( ';', "\\;" ) );
       address.append( (*it).street().replace( ';', "\\;" ) );
       address.append( (*it).locality().replace( ';', "\\;" ) );
       address.append( (*it).region().replace( ';', "\\;" ) );
       address.append( (*it).postalCode().replace( ';', "\\;" ) );
       address.append( (*it).country().replace( ';', "\\;" ) );
 */
 //US using the old implementation instead
       //qDebug("VCardTool::createVCards has to be verified");
       address.append( (*it).postOfficeBox().replace(  QRegExp(";"), "\\;" ) );
       address.append( (*it).extended().replace( QRegExp(";"), "\\;" ) );
       address.append(  (*it).street().replace( QRegExp(";"), "\\;" ) );
       address.append( (*it).locality().replace( QRegExp(";"), "\\;" ) );
       address.append( (*it).region().replace( QRegExp(";"), "\\;" ) );
       address.append( (*it).postalCode().replace( QRegExp(";"), "\\;" ) );
       address.append( (*it).country().replace( QRegExp(";"), "\\;" ) );
 
       VCardLine adrLine( "ADR", address.join( ";" ) );
       VCardLine labelLine( "LABEL", (*it).label() );
 
       bool hasLabel = !(*it).label().isEmpty();
       QMap<QString, int>::Iterator typeIt;
       for ( typeIt = mAddressTypeMap.begin(); typeIt != mAddressTypeMap.end(); ++typeIt ) {
         if ( typeIt.data() & (*it).type() ) {
-          adrLine.addParameter( "TYPE", typeIt.key() );
-          if ( hasLabel )
-            labelLine.addParameter( "TYPE",  typeIt.key() );
+          if ( version == VCard::v3_0 ) {
+            adrLine.addParameter( "TYPE", typeIt.key().lower() );
+          }
+          else {
+            adrLine.addParameter( "TYPE", typeIt.key() );
+          }
+          if ( hasLabel ) {
+            if ( version == VCard::v3_0 ) {
+              labelLine.addParameter( "TYPE",  typeIt.key().lower() );
+            }          
+            else {
+              labelLine.addParameter( "TYPE",  typeIt.key() );
+            }
+          }
         }
       }
 
       card.addLine( adrLine );
       if ( hasLabel )
         card.addLine( labelLine );
     }
 
     // AGENT
     card.addLine( createAgent( version, (*addrIt).agent() ) );
 
     // BDAY
     card.addLine( VCardLine( "BDAY", createDateTime( (*addrIt).birthday() ) ) );
 
     // CATEGORIES
     if ( version == VCard::v3_0 ) {
       QStringList categories = (*addrIt).categories();
       QStringList::Iterator catIt;
       for ( catIt = categories.begin(); catIt != categories.end(); ++catIt )
       {
 //US using the old implementation instead
           // qDebug("VCardTool::createVCards has to be verified");
 //US        (*catIt).replace( ',', "\\," );
         (*catIt).replace( QRegExp(","), "\\," );
       }
       card.addLine( VCardLine( "CATEGORIES", categories.join( "," ) ) );
     }
 
     // CLASS
     if ( version == VCard::v3_0 ) {
       card.addLine( createSecrecy( (*addrIt).secrecy() ) );
     }
     
     // EMAIL
     QStringList emails = (*addrIt).emails();
     bool pref = true;
     for ( strIt = emails.begin(); strIt != emails.end(); ++strIt ) {
       VCardLine line( "EMAIL", *strIt );
       if ( pref == true ) {
         line.addParameter( "TYPE", "PREF" );
         pref = false;
       }
       card.addLine( line );
     }
 
     // FN
     card.addLine( VCardLine( "FN", (*addrIt).formattedName() ) );
 
@@ -188,97 +199,100 @@ QString VCardTool::createVCards( Addressee::List list, VCard::Version version )
     name.append( (*addrIt).familyName().replace( QRegExp(";"), "\\;" ) );
     name.append( (*addrIt).givenName().replace( QRegExp(";"), "\\;" ) );
     name.append( (*addrIt).additionalName().replace( QRegExp(";"), "\\;" ) );
     name.append( (*addrIt).prefix().replace( QRegExp(";"), "\\;" ) );
     name.append( (*addrIt).suffix().replace( QRegExp(";"), "\\;" ) );
 
     if ( !name.join( "" ).isEmpty() )
       card.addLine( VCardLine( "N", name.join( ";" ) ) );
 
     // NICKNAME
     if ( version == VCard::v3_0 )
       card.addLine( VCardLine( "NICKNAME", (*addrIt).nickName() ) );
 
     // NOTE
     card.addLine( VCardLine( "NOTE", (*addrIt).note() ) );
 
     // ORG
     card.addLine( VCardLine( "ORG", (*addrIt).organization() ) );
 
     // PHOTO
     card.addLine( createPicture( "PHOTO", (*addrIt).photo() ) );
 
     // PROID
     if ( version == VCard::v3_0 )
       card.addLine( VCardLine( "PRODID", (*addrIt).productId() ) );
 
     // REV
     card.addLine( VCardLine( "REV", createDateTime( (*addrIt).revision() ) ) );
 
     // ROLE
     card.addLine( VCardLine( "ROLE", (*addrIt).role() ) );
 
     // SORT-STRING
     if ( version == VCard::v3_0 )
       card.addLine( VCardLine( "SORT-STRING", (*addrIt).sortString() ) );
 
     // SOUND
     card.addLine( createSound( (*addrIt).sound() ) );
 
     // TEL
     PhoneNumber::List phoneNumbers = (*addrIt).phoneNumbers();
     PhoneNumber::List::ConstIterator phoneIt;
     for ( phoneIt = phoneNumbers.begin(); phoneIt != phoneNumbers.end(); ++phoneIt ) {
       VCardLine line( "TEL", (*phoneIt).number() );
 
       QMap<QString, int>::Iterator typeIt;
       for ( typeIt = mPhoneTypeMap.begin(); typeIt != mPhoneTypeMap.end(); ++typeIt ) {
         if ( typeIt.data() & (*phoneIt).type() )
-          line.addParameter( "TYPE", typeIt.key() );
+          if ( version == VCard::v3_0 )
+            line.addParameter( "TYPE", typeIt.key().lower() );
+          else
+            line.addParameter( "TYPE", typeIt.key() );
       }
 
       card.addLine( line );
     }
 
     // TITLE
     card.addLine( VCardLine( "TITLE", (*addrIt).title() ) );
 
     // TZ
     TimeZone timeZone = (*addrIt).timeZone();
     if ( timeZone.isValid() ) {
       QString str;
 
       int neg = 1;
       if ( timeZone.offset() < 0 )
         neg = -1;
 
       str.sprintf( "%c%02d:%02d", ( timeZone.offset() >= 0 ? '+' : '-' ),
                                   ( timeZone.offset() / 60 ) * neg,
                                   ( timeZone.offset() % 60 ) * neg );
 
       card.addLine( VCardLine( "TZ", str ) );
     }
 
     // UID
     card.addLine( VCardLine( "UID", (*addrIt).uid() ) );
 
     // URL
     card.addLine( VCardLine( "URL", (*addrIt).url().url() ) );
 
     // VERSION
     if ( version == VCard::v2_1 )
       card.addLine( VCardLine( "VERSION", "2.1" ) );
     if ( version == VCard::v3_0 )
       card.addLine( VCardLine( "VERSION", "3.0" ) );
 
     // X-
     QStringList customs = (*addrIt).customs();
     for ( strIt = customs.begin(); strIt != customs.end(); ++strIt ) {
       QString identifier = "X-" + (*strIt).left( (*strIt).find( ":" ) );
       QString value = (*strIt).mid( (*strIt).find( ":" ) + 1 );
       if ( value.isEmpty() )
         continue;
 
       card.addLine( VCardLine( identifier, value ) );
     }
 
     vCardList.append( card );