3 files changed, 57 insertions, 46 deletions

diff --git a/kabc/plugins/qtopia/resourceqtopia.cpp b/kabc/plugins/qtopia/resourceqtopia.cpp
index d6df981..cf6b11a 100644
--- a/kabc/plugins/qtopia/resourceqtopia.cpp
+++ b/kabc/plugins/qtopia/resourceqtopia.cpp
@@ -134,65 +134,65 @@ bool ResourceQtopia::doOpen()
     {
           QString msg("Unable to initialize qtopia converter. Most likely a problem with the category file");
       qDebug(msg);
       return false;
     }
   }
 
   return true;
 }
 
 void ResourceQtopia::doClose()
 {
   qDebug("ResourceQtopia::doClose: %s", fileName().latin1());
 
  
   // it seems so, that deletion of access deletes backend as well
   //delete backend;
 
   return;
 }
 
 bool ResourceQtopia::load()
 {
 
   QFile file( fileName() );
   if ( !file.open(IO_ReadOnly ) ) {
     return false;
   }
 
   QDomDocument doc("mydocument" );
   if ( !doc.setContent( &file ) ) {
     file.close();
-    return false;
+    return true;
   }
   bool res;
   QDomElement docElem = doc.documentElement( );
   QDomNode n =  docElem.firstChild();
   while ( !n.isNull() ) {
     QDomElement e = n.toElement();
     if ( !e.isNull() ) {
       if ( e.tagName() == QString::fromLatin1( "Contacts" ) ) { 
         QDomNode no = e.firstChild();
         while ( !no.isNull() ) {
           QDomElement el = no.toElement();
           if ( !el.isNull() ) {
               KABC::Addressee addressee;
               res = mConverter->qtopiaToAddressee( el,  addressee ); 
               if ( !addressee.isEmpty() && res )
                   {
                       addressee.setResource( this );
                       addressBook()->insertAddressee( addressee );
                   }
           }
 
           no = no.nextSibling();
         }
       }
     }
 
     n = n.nextSibling();
   }
   return true;
 }
 
 bool ResourceQtopia::save( Ticket *ticket )
diff --git a/kaddressbook/xxport/qtopia_xxport.cpp b/kaddressbook/xxport/qtopia_xxport.cpp
index 0cf6546..fc4abbb 100644
--- a/kaddressbook/xxport/qtopia_xxport.cpp
+++ b/kaddressbook/xxport/qtopia_xxport.cpp
@@ -4,75 +4,83 @@
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
     As a special exception, permission is given to link this program
     with any edition of Qt, and distribute the resulting executable,
     without including the source code for Qt in the source distribution.
 */
 
 /*
 Enhanced Version of the file for platform independent KDE tools.
 Copyright (c) 2004 Ulf Schenk
 
 $Id$
 */
 
 #include <qdir.h>
 
 #include "addressee.h"
 #include "xxportmanager.h"
 #include "qtopia_xxport.h"
+#include <kfiledialog.h>
 
 /*US
 class QtopiaXXPortFactory : public XXPortFactory
 {
   public:
     XXPortObject *xxportObject( KABC::AddressBook *ab, QWidget *parent, const char *name )
     {
       return new QtopiaXXPort( ab, parent, name );
     }
 };
 */
 
 extern "C"
 {
   void *init_microkaddrbk_qtopia_xxport()
   {
     return ( new QtopiaXXPortFactory() );
   }
 }
 
 
 
 QtopiaXXPort::QtopiaXXPort( KABC::AddressBook *ab, QWidget *parent, const char *name )
   : XXPortResourceObject( ab, parent, name )
 {
   defaultFileName = QDir::homeDirPath() + "/Applications/addressbook/addressbook.xml";
 
   if ( mFactory && !mFactory->typeName( "qtopia" ).isEmpty() )
   {
-    createImportAction( i18n( "Import Qtopia..." ) );
-    createExportAction( i18n( "Export Qtopia..." ) );
+    createImportAction( i18n( "Import xml (Qtopia)..." ) );
+    createExportAction( i18n( "Export xml (Qtopia)..." ) );
   }
 }
 
 bool QtopiaXXPort::exportContacts( const KABC::AddresseeList &list, const QString &identifier )
 {
-  return _exportContacts( list, identifier, defaultFileName );
+    QString fn =KFileDialog::getSaveFileName( defaultFileName, i18n("Import xml file"), 0 );
+    if ( fn == "" )
+        return false;
+
+  return _exportContacts( list, identifier, fn );
 }
 
 KABC::AddresseeList QtopiaXXPort::importContacts( const QString &identifier ) const
 {
-  return _importContacts( identifier, defaultFileName );
+    QString fn =KFileDialog::getOpenFileName( defaultFileName, i18n("Import xml file"), 0 );
+    if ( fn == "" )
+        return KABC::AddresseeList() ;
+  return _importContacts( identifier, fn );
 }
diff --git a/kaddressbook/xxportobject.cpp b/kaddressbook/xxportobject.cpp
index 67e8406..bd9d986 100644
--- a/kaddressbook/xxportobject.cpp
+++ b/kaddressbook/xxportobject.cpp
@@ -1,63 +1,64 @@
 /*
     This file is part of KAddressbook.
     Copyright (c) 2003 Tobias Koenig <tokoe@kde.org>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
     As a special exception, permission is given to link this program
     with any edition of Qt, and distribute the resulting executable,
     without including the source code for Qt in the source distribution.
 */
 
 /*
 Enhanced Version of the file for platform independent KDE tools.
 Copyright (c) 2004 Ulf Schenk
 
 $Id$
 */
 
 #include <qmap.h>
+#include <qfile.h>
 #include <qsignalmapper.h>
 
 #include <kaction.h>
 #include <kmessagebox.h>
 #include <factory.h>
 
 #include "kabcore.h"
 #include "addressee.h"
 #include "tmpaddressbook.h"
 #include "xxportobject.h"
 
 
 class XXPortObject::XXPortObjectPrivate
 {
   public:
     QSignalMapper *mExportMapper;
     QSignalMapper *mImportMapper;
 };
 
 XXPortObject::XXPortObject( KABC::AddressBook *ab, QWidget *parent,
                             const char *name )
   : QObject( parent, name ), mAddressBook( ab ), mParentWidget( parent ),
     d( new XXPortObjectPrivate )
 {
   d->mExportMapper = new QSignalMapper( this );
   d->mImportMapper = new QSignalMapper( this );
 
   connect( d->mExportMapper, SIGNAL( mapped( const QString& ) ),
            SLOT( slotExportActivated( const QString& ) ) );
   connect( d->mImportMapper, SIGNAL( mapped( const QString& ) ),
            SLOT( slotImportActivated( const QString& ) ) );
 }
@@ -147,108 +148,110 @@ void XXPortObject::slotExportActivated( const QString &data )
 
 void XXPortObject::slotImportActivated( const QString &data )
 {
   emit importActivated( identifier(), ( data == "<empty>" ? QString::null : data ) );
 }
 
 /********************************************************************
  *
  *******************************************************************/
 
 
 XXPortResourceObject::XXPortResourceObject( KABC::AddressBook *ab, QWidget *parent,
                             const char *name )
   : XXPortObject( ab, parent, name ), mFactory(0)
 {
   mFactory = KRES::Factory::self( "tmpcontact" );
 }
 
 XXPortResourceObject::~XXPortResourceObject()
 {
   //do not delete the factory. It is a singleton, and selfcontained
 }
 
 bool XXPortResourceObject::isAvailable()
 {
   return (mFactory != 0);
 }
 
 
 bool XXPortResourceObject::_exportContacts( const KABC::AddresseeList &list, const QString& identifier, const QString& fileName )
 {
   //create new resource
-  KABC::Resource* mResource = (KABC::Resource*)(mFactory->resource( this->identifier(), 0 ));
-
-  if (mResource == 0)
-    return false;
-
-  if (fileName != QString::null)
-          mResource->setFileName( fileName );
-
-
-  KABC::TmpAddressBook tmpAB;
-
-  bool res = tmpAB.addResource( mResource );
-  if (res == false)
-  {
-        delete mResource;
-        return false;
-  }
-
-  res = tmpAB.load();
-  if (res == false)
-  {
-    //removeResource deletes also the resource object, if the linkcount is 0
-    tmpAB.removeResource( mResource );
-    return false;
-  }
-
-
-  //Now check if the file has already entries, and ask the user if he wants to delete them first.
-  if (tmpAB.begin() != tmpAB.end())
-  {
-    QString text( i18n( "Do you want to remove<br>all existing entries from<br>%1<br>before exporting.?" ) );
-    if ( KMessageBox::questionYesNo( parentWidget(), text.arg( fileName ) ) == KMessageBox::Yes ) {
-      // Clean the database..
-      tmpAB.clear();
+    KABC::Resource* mResource = (KABC::Resource*)(mFactory->resource( this->identifier(), 0 ));
+
+    if (mResource == 0)
+        return false;
+
+    if (fileName != QString::null) {
+        mResource->setFileName( fileName );
+    } else 
+        return false;
+
+
+    KABC::TmpAddressBook tmpAB;
+
+    bool res = tmpAB.addResource( mResource );
+    if (res == false)
+        {
+            delete mResource;
+            return false;
+        }
+    if ( QFile::exists ( fileName ) ) {
+        res = tmpAB.load();
+        if (res == false)
+            {
+                //removeResource deletes also the resource object, if the linkcount is 0
+                tmpAB.removeResource( mResource );
+                return false;
+            }
+
+
+        //Now check if the file has already entries, and ask the user if he wants to delete them first.
+        if (tmpAB.begin() != tmpAB.end())
+            {
+                QString text( i18n( "Do you want to remove<br>all existing entries from<br>%1<br>before exporting.?" ) );
+                if ( KMessageBox::questionYesNo( parentWidget(), text.arg( fileName ) ) == KMessageBox::Yes ) {
+                    // Clean the database..
+                    tmpAB.clear();
+                }
+            }
     }
-  }
 
+    KABC::Addressee::List::ConstIterator it;
+    for ( it = list.begin(); it != list.end(); ++it ) {
+        tmpAB.insertAddressee(*it);
+    }
 
-  KABC::Addressee::List::ConstIterator it;
-  for ( it = list.begin(); it != list.end(); ++it ) {
-    tmpAB.insertAddressee(*it);
-  }
-
-  KABC::Ticket * ticket = tmpAB.requestSaveTicket(mResource);
+    KABC::Ticket * ticket = tmpAB.requestSaveTicket(mResource);
 
   res = false;
   if (ticket != 0)
     res = tmpAB.save( ticket );
 
   //removeResource deletes also the resource object, if the linkcount is 0
   tmpAB.removeResource( mResource );
 
   return res;
 }
 
 
 KABC::AddresseeList XXPortResourceObject::_importContacts( const QString& identifier, const QString& fileName ) const
 {
 
 
   KABC::Resource* mResource = (KABC::Resource*)(mFactory->resource( this->identifier(), 0 ));
 
   if (mResource == 0)
     return KABC::AddresseeList();
 
   KABC::AddresseeList adrlst;
 
   if (fileName != QString::null)
           mResource->setFileName( fileName );
 
 
   KABC::TmpAddressBook tmpAB;
 
   bool res = tmpAB.addResource( mResource );
   if (res == false)
   {