many phone and sync fixes

7 files changed, 227 insertions, 127 deletions

diff --git a/libkcal/event.cpp b/libkcal/event.cpp
index dfa265b..7256f05 100644
--- a/libkcal/event.cpp
+++ b/libkcal/event.cpp
@@ -58,2 +58,48 @@ bool KCal::operator==( const Event& e1, const Event& e2 )
 
+bool Event::contains ( Event* from )
+{
+
+    if ( !from->summary().isEmpty() )
+        if (  !summary().startsWith(  from->summary() ))
+            return false; 
+    if ( from->dtStart().isValid() )
+        if (dtStart() != from->dtStart() )
+            return false;
+    if ( from->dtEnd().isValid() )
+        if ( dtEnd() !=  from->dtEnd() )
+            return false;
+    if ( !from->location().isEmpty() )
+        if (  !location().startsWith( from->location() ) )
+            return false;
+    if ( !from->description().isEmpty() )
+        if (  !description().startsWith(  from->description() ))
+            return false;
+    if ( from->alarms().count() ) {
+        Alarm *a = from->alarms().first();
+        if (  a->enabled()  ){
+            if ( !alarms().count() )
+                return false;
+            Alarm *b = alarms().first();
+            if( ! b->enabled() )
+                return false;
+            if ( ! (a->offset() == b->offset() ))
+                return false;
+        }
+    }
+    QStringList cat = categories();
+    QStringList catFrom = from->categories();
+    QString nCat;
+    int iii;
+    for ( iii = 0; iii < catFrom.count();++iii ) {
+        nCat = catFrom[iii];
+        if ( !nCat.isEmpty() )
+            if ( !cat.contains( nCat )) {
+                return false;
+            }
+    }
+    if ( from->doesRecur() ) 
+        if ( from->doesRecur() != doesRecur() && ! (from->doesRecur()== Recurrence::rYearlyMonth && doesRecur()== Recurrence::rYearlyDay) )
+            return false;
+    return true;
+}
 
diff --git a/libkcal/event.h b/libkcal/event.h
index 2a8bd95..3bc8adc 100644
--- a/libkcal/event.h
+++ b/libkcal/event.h
@@ -73,2 +73,4 @@ class Event : public Incidence
 
+    bool contains ( Event*);
+
   private:
diff --git a/libkcal/phoneformat.cpp b/libkcal/phoneformat.cpp
index 281434e..101db57 100644
--- a/libkcal/phoneformat.cpp
+++ b/libkcal/phoneformat.cpp
@@ -314,3 +314,12 @@ bool PhoneFormat::load( Calendar *calendar, Calendar *existingCal)
             ev->setCategories( QStringList() );
+        } else 
+        if ( cat.contains( "Birthday" )) {
+            ev->setFloats( true );
+            QDate da = ev->dtStart().date();
+            ev->setDtStart( QDateTime( da)  );
+            ev->setDtEnd( QDateTime( da.addDays(1))  );
+            
         }
+        uint cSum;
+        cSum = PhoneFormat::getCsumEvent( ev );
         int id = ev->pilotId();
@@ -326,4 +335,2 @@ bool PhoneFormat::load( Calendar *calendar, Calendar *existingCal)
             event = ev;
-        uint cSum;
-        cSum = PhoneFormat::getCsumEvent( event );
         event->setCsum( mProfileName, QString::number( cSum ));
@@ -344,2 +351,4 @@ bool PhoneFormat::load( Calendar *calendar, Calendar *existingCal)
             int id = ev->pilotId();
+            uint cSum;
+            cSum = PhoneFormat::getCsumTodo( ev );
             Todo *event;
@@ -356,4 +365,2 @@ bool PhoneFormat::load( Calendar *calendar, Calendar *existingCal)
                 event = ev;
-            uint cSum;
-            cSum = PhoneFormat::getCsumTodo( event );
             event->setCsum( mProfileName, QString::number( cSum ));
@@ -384,7 +391,3 @@ void PhoneFormat::copyEvent( Event* to,  Event* from )
         b->setEnabled( a->enabled()  );
-        if ( a->hasStartOffset() ) {
-            b->setStartOffset( a->startOffset() );
-        }
-        if ( a->hasTime() )
-            b->setTime( a->time() );
+        b->setStartOffset(Duration( a->offset() ) );
     
@@ -403,4 +406,6 @@ void PhoneFormat::copyEvent( Event* to,  Event* from )
     to->setCategories( cat );
-    Recurrence * r = new Recurrence( *from->recurrence(),to);
-    to->setRecurrence( r ) ;
+    if ( from->doesRecur() ) {
+        Recurrence * r = new Recurrence( *from->recurrence(),to);
+        to->setRecurrence( r ) ;
+    }
 
@@ -410,6 +415,10 @@ void PhoneFormat::copyTodo( Todo* to,  Todo* from )
 {
-    if ( from->dtStart().isValid() )
+    if ( from->hasStartDate() ) {
+        to->setHasStartDate( true );
         to->setDtStart(  from->dtStart() );
-    if ( from->dtDue().isValid() )
+    }
+    if ( from->hasDueDate() ){
+        to->setHasDueDate( true );
         to->setDtDue(  from->dtDue() );
+    }
     if ( !from->location().isEmpty() )
@@ -426,6 +435,3 @@ void PhoneFormat::copyTodo( Todo* to,  Todo* from )
         b->setEnabled( a->enabled()  );
-        if ( a->hasStartOffset() )
-            b->setStartOffset( a->startOffset() );
-        if ( a->hasTime() )
-            b->setTime( a->time() );
+        b->setStartOffset(Duration( a->offset() ) );
     }
@@ -463,12 +469,6 @@ void PhoneFormat::copyTodo( Todo* to,  Todo* from )
 
-void PhoneFormat::afterSave( Incidence* inc)
+void PhoneFormat::afterSave( Incidence* inc,const QString& id ,const QString& csum)
 {
-    uint csum;
-    inc->removeID( mProfileName );
-    if ( inc->type() == "Event")
-        csum = PhoneFormat::getCsumEvent( (Event*) inc );
-    else
-        csum = PhoneFormat::getCsumTodo( (Todo*) inc );
-    inc->setCsum( mProfileName, QString::number( csum ));
-
+    inc->setID( mProfileName, id );
+    inc->setCsum( mProfileName, csum);
     inc->setTempSyncStat( SYNC_TEMPSTATE_NEW_ID );
@@ -480,5 +480,5 @@ bool PhoneFormat::writeToPhone( Calendar *  calendar)
 #ifdef _WIN32_
-    QString  fileName = locateLocal("tmp", "tempfile.vcs");
+    QString  fileName = locateLocal("tmp", "phonefile.vcs");
 #else
-    QString  fileName = "/tmp/kdepimtemp.vcs";
+    QString  fileName = "/tmp/phonefile.vcs";
 #endif
@@ -496,14 +496,3 @@ bool PhoneFormat::save( Calendar *calendar)
 {
-    QLabel status ( i18n(" Opening device ..."), 0 );
-    int w = status.sizeHint().width()+20 ;
-    if ( w < 200 ) w = 230;
-    int h = status.sizeHint().height()+20 ;
-    int dw = QApplication::desktop()->width();
-    int dh = QApplication::desktop()->height();
-    status.setCaption(i18n("Writing to phone...") );
-    status.setGeometry( (dw-w)/2, (dh - h )/2 ,w,h );
-    status.show();
-    status.raise();
-    qApp->processEvents();
-    QString message;
+   
 
@@ -536,3 +525,14 @@ bool PhoneFormat::save( Calendar *calendar)
         return false;
-    
+    QLabel status ( i18n(" Opening device ..."), 0 );
+    int w = status.sizeHint().width()+20 ;
+    if ( w < 200 ) w = 230;
+    int h = status.sizeHint().height()+20 ;
+    int dw = QApplication::desktop()->width();
+    int dh = QApplication::desktop()->height();
+    status.setCaption(i18n("Writing to phone...") );
+    status.setGeometry( (dw-w)/2, (dh - h )/2 ,w,h );
+    QString message;
+    status.show();
+    status.raise();
+    qApp->processEvents();
     // 5 reread data
@@ -561,15 +561,7 @@ bool PhoneFormat::save( Calendar *calendar)
             qApp->processEvents();
-            uint csum;
-            csum = PhoneFormat::getCsumEvent( ev );
-            QString cSum = QString::number( csum );
-            //ev->setCsum( mProfileName,  cSum );
-            //qDebug("Event cSum %s ", cSum.latin1());
             ev1 = er1.first(); 
             while ( ev1 ) {
-                if (  ev1->getCsum( mProfileName ) == cSum ) {
+                if (  ev->contains( ev1 ) ) {
+                    afterSave( ev ,ev1->getID(mProfileName),ev1->getCsum(mProfileName));
                     er1.remove( ev1 );
-                    afterSave( ev );
-                    ev->setID(mProfileName, ev1->getID(mProfileName) );
-                    //qDebug("Event found  on phone for %s ", ev->summary().latin1());
-
                     break;
@@ -596,13 +588,7 @@ bool PhoneFormat::save( Calendar *calendar)
             qApp->processEvents();
-            uint csum;
-            csum = PhoneFormat::getCsumTodo( to );
-            QString cSum = QString::number( csum );
-            //to->setCsum( mProfileName,  cSum );
-            //qDebug("Todo cSum %s ", cSum.latin1());
             Todo* to1 = tl1.first(); 
             while ( to1 ) {
-                if (  to1->getCsum( mProfileName ) == cSum ) {
+                if (  to->contains( to1 ) ) {
+                    afterSave( to ,to1->getID(mProfileName),to1->getCsum(mProfileName));
                     tl1.remove( to1 );
-                    afterSave( to );
-                    to->setID(mProfileName, to1->getID(mProfileName) );
                     break;
diff --git a/libkcal/phoneformat.h b/libkcal/phoneformat.h
index 001fd81..d11f68b 100644
--- a/libkcal/phoneformat.h
+++ b/libkcal/phoneformat.h
@@ -56,3 +56,3 @@ class PhoneFormat : public QObject {
     QString mProfileName;
-    void afterSave( Incidence* );
+    void afterSave( Incidence* ,const QString&,const QString&);
 };
diff --git a/libkcal/todo.cpp b/libkcal/todo.cpp
index 0c1e3e4..3d2de61 100644
--- a/libkcal/todo.cpp
+++ b/libkcal/todo.cpp
@@ -58,3 +58,61 @@ Incidence *Todo::clone()
 
+bool Todo::contains ( Todo* from )
+{ 
 
+    if ( !from->summary().isEmpty() )
+        if (  !summary().startsWith(  from->summary() ))
+            return false;
+    if ( from->hasStartDate() ) {
+        if ( !hasStartDate() )
+            return false;
+        if ( from->dtStart() != dtStart())
+            return false;      
+    }
+    if ( from->hasDueDate() ){
+        if ( !hasDueDate() )
+            return false;
+        if ( from->dtDue() != dtDue())
+            return false;  
+    }
+    if ( !from->location().isEmpty() )
+        if (  !location().startsWith( from->location() ) )
+            return false;
+    if ( !from->description().isEmpty() )
+        if (  !description().startsWith(  from->description() ))
+            return false;
+     if ( from->alarms().count() ) {
+        Alarm *a = from->alarms().first();
+        if (  a->enabled()  ){
+            if ( !alarms().count() )
+                return false;
+            Alarm *b = alarms().first();
+            if( ! b->enabled() )
+                return false;
+            if ( ! (a->offset() == b->offset() ))
+                return false;
+        }
+    }
+   
+    QStringList cat = categories();
+    QStringList catFrom = from->categories();
+    QString nCat;
+    int iii;
+    for ( iii = 0; iii < catFrom.count();++iii ) {
+        nCat = catFrom[iii];
+        if ( !nCat.isEmpty() )
+            if ( !cat.contains( nCat )) {
+                return false;
+            }
+    }
+    if ( from->isCompleted() ) {
+        if ( !isCompleted() )
+            return false;
+    }
+    if( priority() !=  from->priority() )
+        return false;
+
+
+    return true;
+
+}
 bool KCal::operator==( const Todo& t1, const Todo& t2 )
diff --git a/libkcal/todo.h b/libkcal/todo.h
index 9aa92f8..0f22c59 100644
--- a/libkcal/todo.h
+++ b/libkcal/todo.h
@@ -101,2 +101,3 @@ class Todo : public Incidence
     bool hasCompletedDate() const;
+    bool contains ( Todo*);
     
diff --git a/libkcal/vcalformat.cpp b/libkcal/vcalformat.cpp
index a6ae1bc..df93209 100644
--- a/libkcal/vcalformat.cpp
+++ b/libkcal/vcalformat.cpp
@@ -64,3 +64,4 @@ bool VCalFormat::load(Calendar *calendar, const QString &fileName)
   clearException();
-  useLocalTime = mCalendar->isLocalTime();
+  if ( ! useLocalTime )
+      useLocalTime = mCalendar->isLocalTime();
   VObject *vcal = 0;
@@ -92,3 +93,4 @@ bool VCalFormat::save(Calendar *calendar, const QString &fileName)
   mCalendar = calendar;
-  useLocalTime = mCalendar->isLocalTime();
+  if ( ! useLocalTime )
+      useLocalTime = mCalendar->isLocalTime();
 
@@ -1174,32 +1176,34 @@ Event* VCalFormat::VEventToEvent(VObject *vevent)
     else if (tmpStr.left(2) == "YM") {
-      int index = tmpStr.find(' ');
-      int last = tmpStr.findRev(' ') + 1;
-      int rFreq = tmpStr.mid(2, (index-1)).toInt();
-      index += 1;
-      short tmpMonth;
-      if( index == last ) {
-        // e.g. YM1 #0
-        tmpMonth = anEvent->dtStart().date().month();
-        anEvent->recurrence()->addYearlyNum(tmpMonth);
-      }
-      else {
-        // e.g. YM1 3 #0
-        while (index < last) {
-          int index2 = tmpStr.find(' ', index);
-          tmpMonth = tmpStr.mid(index, (index2-index)).toShort();
-          index = index2+1;
-          anEvent->recurrence()->addYearlyNum(tmpMonth);
-        } // while != #
-      }
-      index = last; if (tmpStr.mid(index,1) == "#") index++;
-      if (tmpStr.find('T', index) != -1) {
-        QDate rEndDate = (ISOToQDateTime(tmpStr.mid(index, tmpStr.length()-index))).date();
-        anEvent->recurrence()->setYearly(Recurrence::rYearlyMonth, rFreq, rEndDate);
-      } else {
-        int rDuration = tmpStr.mid(index, tmpStr.length()-index).toInt();
-        if (rDuration == 0)
-          anEvent->recurrence()->setYearly(Recurrence::rYearlyMonth, rFreq, -1);
-        else
-          anEvent->recurrence()->setYearly(Recurrence::rYearlyMonth, rFreq, rDuration);
-      }
+        // we have to set this such that recurrence accepts addYearlyNum(tmpDay);
+        anEvent->recurrence()->setYearly(Recurrence::rYearlyMonth, 1, -1);
+        int index = tmpStr.find(' ');
+        int last = tmpStr.findRev(' ') + 1;
+        int rFreq = tmpStr.mid(2, (index-1)).toInt();
+        index += 1;
+        short tmpMonth;
+        if( index == last ) {
+            // e.g. YM1 #0
+            tmpMonth = anEvent->dtStart().date().month();
+            anEvent->recurrence()->addYearlyNum(tmpMonth);
+        }
+        else {
+            // e.g. YM1 3 #0
+            while (index < last) {
+                int index2 = tmpStr.find(' ', index);
+                tmpMonth = tmpStr.mid(index, (index2-index)).toShort();
+                index = index2+1;
+                anEvent->recurrence()->addYearlyNum(tmpMonth);
+            } // while != #
+        }
+        index = last; if (tmpStr.mid(index,1) == "#") index++;
+        if (tmpStr.find('T', index) != -1) {
+            QDate rEndDate = (ISOToQDateTime(tmpStr.mid(index, tmpStr.length()-index))).date();
+            anEvent->recurrence()->setYearly(Recurrence::rYearlyMonth, rFreq, rEndDate);
+        } else {
+            int rDuration = tmpStr.mid(index, tmpStr.length()-index).toInt();
+            if (rDuration == 0)
+                anEvent->recurrence()->setYearly(Recurrence::rYearlyMonth, rFreq, -1);
+            else
+                anEvent->recurrence()->setYearly(Recurrence::rYearlyMonth, rFreq, rDuration);
+        }
     }
@@ -1208,34 +1212,36 @@ Event* VCalFormat::VEventToEvent(VObject *vevent)
     else if (tmpStr.left(2) == "YD") {
-      int index = tmpStr.find(' ');
-      int last = tmpStr.findRev(' ') + 1;
-      int rFreq = tmpStr.mid(2, (index-1)).toInt();
-      index += 1;
-      short tmpDay;
-      if( index == last ) {
-        // e.g. YD1 #0
-        tmpDay = anEvent->dtStart().date().dayOfYear();
-        anEvent->recurrence()->addYearlyNum(tmpDay);
-      }
-      else {
-        // e.g. YD1 123 #0
-        while (index < last) {
-          int index2 = tmpStr.find(' ', index);
-          tmpDay = tmpStr.mid(index, (index2-index)).toShort();
-          index = index2+1;
-          anEvent->recurrence()->addYearlyNum(tmpDay);
-        } // while != #
-      }
-      index = last; if (tmpStr.mid(index,1) == "#") index++;
-      if (tmpStr.find('T', index) != -1) {
-        QDate rEndDate = (ISOToQDateTime(tmpStr.mid(index, tmpStr.length()-index))).date();
-        anEvent->recurrence()->setYearly(Recurrence::rYearlyDay, rFreq, rEndDate);
-      } else {
-        int rDuration = tmpStr.mid(index, tmpStr.length()-index).toInt();
-        if (rDuration == 0)
-          anEvent->recurrence()->setYearly(Recurrence::rYearlyDay, rFreq, -1);
-        else
-          anEvent->recurrence()->setYearly(Recurrence::rYearlyDay, rFreq, rDuration);
-      }
+        // we have to set this such that recurrence accepts addYearlyNum(tmpDay);
+        anEvent->recurrence()->setYearly(Recurrence::rYearlyDay, 1, -1);
+        int index = tmpStr.find(' ');
+        int last = tmpStr.findRev(' ') + 1;
+        int rFreq = tmpStr.mid(2, (index-1)).toInt();
+        index += 1;
+        short tmpDay;
+        if( index == last ) {
+            // e.g. YD1 #0
+            tmpDay = anEvent->dtStart().date().dayOfYear();
+            anEvent->recurrence()->addYearlyNum(tmpDay);
+        }
+        else {
+            // e.g. YD1 123 #0
+            while (index < last) {
+                int index2 = tmpStr.find(' ', index);
+                tmpDay = tmpStr.mid(index, (index2-index)).toShort();
+                index = index2+1;
+                anEvent->recurrence()->addYearlyNum(tmpDay);
+            } // while != #
+        }
+        index = last; if (tmpStr.mid(index,1) == "#") index++;
+        if (tmpStr.find('T', index) != -1) {
+            QDate rEndDate = (ISOToQDateTime(tmpStr.mid(index, tmpStr.length()-index))).date();
+            anEvent->recurrence()->setYearly(Recurrence::rYearlyDay, rFreq, rEndDate);
+        } else {
+            int rDuration = tmpStr.mid(index, tmpStr.length()-index).toInt();
+            if (rDuration == 0)
+                anEvent->recurrence()->setYearly(Recurrence::rYearlyDay, rFreq, -1);
+            else
+                anEvent->recurrence()->setYearly(Recurrence::rYearlyDay, rFreq, rDuration);
+        }
     } else {
-      kdDebug(5800) << "we don't understand this type of recurrence!" << endl;
+        kdDebug(5800) << "we don't understand this type of recurrence!" << endl;
     } // if
@@ -1538,8 +1544,9 @@ void VCalFormat::populate(VObject *vcal)
   if ((curVO = isAPropertyOf(vcal, VCTimeZoneProp)) != 0) {
-    char *s = fakeCString(vObjectUStringZValue(curVO));
-    mCalendar->setTimeZone(s);
-    deleteStr(s);
+      if ( vObjectUStringZValue(curVO) != 0 ) {
+          char *s = fakeCString(vObjectUStringZValue(curVO));
+          mCalendar->setTimeZone(s);
+          deleteStr(s);
+      }
   }
 
-
   // Store all events with a relatedTo property in a list for post-processing