Many bugfixes

1 files changed, 44 insertions, 12 deletions

diff --git a/libkcal/recurrence.cpp b/libkcal/recurrence.cpp
index dd74e10..e84f672 100644
--- a/libkcal/recurrence.cpp
+++ b/libkcal/recurrence.cpp
@@ -1,392 +1,424 @@
 /*
     This file is part of libkcal.
     Copyright (c) 1998 Preston Brown
     Copyright (c) 2001 Cornelius Schumacher <schumacher@kde.org>
     Copyright (c) 2002 David Jarvie <software@astrojar.org.uk>
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
 
     This library is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
     Library General Public License for more details.
 
     You should have received a copy of the GNU Library General Public License
     along with this library; see the file COPYING.LIB.  If not, write to
     the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
     Boston, MA 02111-1307, USA.
 */
 
 #include <limits.h>
 
 #include <kdebug.h>
 #include <kglobal.h>
 #include <klocale.h>
 
 #include "incidence.h"
 
 #include "recurrence.h"
 
 using namespace KCal;
 
 Recurrence::Feb29Type Recurrence::mFeb29YearlyDefaultType = Recurrence::rMar1;
 
 
 Recurrence::Recurrence(Incidence *parent, int compatVersion)
 : recurs(rNone),   // by default, it's not a recurring event
   rWeekStart(1),   // default is Monday
   rDays(7),
   mFloats(parent ? parent->doesFloat() : false),
   mRecurReadOnly(false),
   mRecurExDatesCount(0),
   mFeb29YearlyType(mFeb29YearlyDefaultType),
   mCompatVersion(compatVersion ? compatVersion : INT_MAX),
   mCompatRecurs(rNone),
   mCompatDuration(0),
   mParent(parent)
 {
   rMonthDays.setAutoDelete( true );
   rMonthPositions.setAutoDelete( true );
   rYearNums.setAutoDelete( true );
 }
 
 Recurrence::Recurrence(const Recurrence &r, Incidence *parent)
 : recurs(r.recurs),
   rWeekStart(r.rWeekStart),
   rDays(r.rDays.copy()),
   rFreq(r.rFreq),
   rDuration(r.rDuration),
   rEndDateTime(r.rEndDateTime),
   mRecurStart(r.mRecurStart),
   mFloats(r.mFloats),
   mRecurReadOnly(r.mRecurReadOnly),
   mRecurExDatesCount(r.mRecurExDatesCount),
   mFeb29YearlyType(r.mFeb29YearlyType),
   mCompatVersion(r.mCompatVersion),
   mCompatRecurs(r.mCompatRecurs),
   mCompatDuration(r.mCompatDuration),
   mParent(parent)
 {
   for (QPtrListIterator<rMonthPos> mp(r.rMonthPositions);  mp.current();  ++mp) {
     rMonthPos *tmp = new rMonthPos;
     tmp->rPos     = mp.current()->rPos;
     tmp->negative = mp.current()->negative;
     tmp->rDays    = mp.current()->rDays.copy();
     rMonthPositions.append(tmp);
   }
   for (QPtrListIterator<int> md(r.rMonthDays);  md.current();  ++md) {
     int *tmp = new int;
     *tmp = *md.current();
     rMonthDays.append(tmp);
   }
   for (QPtrListIterator<int> yn(r.rYearNums);  yn.current();  ++yn) {
     int *tmp = new int;
     *tmp = *yn.current();
     rYearNums.append(tmp);
   }
   rMonthDays.setAutoDelete( true );
   rMonthPositions.setAutoDelete( true );
   rYearNums.setAutoDelete( true );
 }
 
 Recurrence::~Recurrence()
 {
 }
 
 
 bool Recurrence::operator==( const Recurrence& r2 ) const
 {  
       
     // the following line is obvious
     if (  recurs == rNone &&  r2.recurs == rNone )
         return true;
     // we need the above line, because two non recurring events may
     // differ in the other settings, because one (or both) 
     // may be not initialized properly
+
     if ( recurs != r2.recurs
   ||   rFreq != r2.rFreq
   ||   rDuration != r2.rDuration
   ||   !rDuration && rEndDateTime != r2.rEndDateTime
   ||   mRecurStart != r2.mRecurStart
   ||   mFloats != r2.mFloats
   ||   mRecurReadOnly != r2.mRecurReadOnly
   ||   mRecurExDatesCount != r2.mRecurExDatesCount )
     return false;
   // no need to compare mCompat* and mParent
   // OK to compare the pointers
   switch ( recurs )
   {
     case rWeekly:
       return rDays == r2.rDays
       &&     rWeekStart == r2.rWeekStart;
-    case rMonthlyPos:
-      return rMonthPositions.count() == r2.rMonthPositions.count();
-    case rMonthlyDay:
-      return rMonthDays.count() == r2.rMonthDays.count();
-    case rYearlyPos:
-      return rYearNums.count() == r2.rYearNums.count()
-      &&     rMonthPositions.count() == r2.rMonthPositions.count();
-    case rYearlyMonth:
-        return rYearNums.count() == r2.rYearNums.count()
-        &&     mFeb29YearlyType == r2.mFeb29YearlyType;
-    case rYearlyDay:
-      return rYearNums == r2.rYearNums;
+  case rMonthlyPos: {
+      QPtrList<rMonthPos> MonthPositions = rMonthPositions;
+      QPtrList<rMonthPos> MonthPositions2 = r2.rMonthPositions;
+      if ( !MonthPositions.count() )
+          return false;
+      if ( !MonthPositions2.count() )
+          return false;
+      return MonthPositions.first()->rPos == MonthPositions2.first()->rPos;
+  }
+  case rMonthlyDay: {
+      QPtrList<int> MonthDays = rMonthDays ; 
+      QPtrList<int> MonthDays2 = r2.rMonthDays ;  
+      if ( !MonthDays.count() )
+          return false;
+      if ( !MonthDays2.count() )
+          return false; 
+      return *MonthDays.first() == *MonthDays2.first() ;
+  }
+  case rYearlyPos: {
+
+      QPtrList<int> YearNums = rYearNums;
+      QPtrList<int> YearNums2 = r2.rYearNums;
+      if ( *YearNums.first() != *YearNums2.first() )
+          return false;
+      QPtrList<rMonthPos> MonthPositions = rMonthPositions;
+      QPtrList<rMonthPos> MonthPositions2 = r2.rMonthPositions;
+      if ( !MonthPositions.count() )
+          return false;
+      if ( !MonthPositions2.count() )
+          return false;
+      return MonthPositions.first()->rPos == MonthPositions2.first()->rPos;
+     
+  }
+  case rYearlyMonth: {
+      QPtrList<int> YearNums = rYearNums;
+      QPtrList<int> YearNums2 = r2.rYearNums;
+      return ( *YearNums.first() == *YearNums2.first()  && mFeb29YearlyType == r2.mFeb29YearlyType);
+  }
+      case rYearlyDay: {
+      QPtrList<int> YearNums = rYearNums;
+      QPtrList<int> YearNums2 = r2.rYearNums;
+      return ( *YearNums.first() == *YearNums2.first() );
+      }
     case rNone:
     case rMinutely:
     case rHourly:
     case rDaily:
     default:
       return true;
   }
 }
 /*
 bool  Recurrence::compareLists( const QPtrList<int> &l1 ,const QPtrList<int> &l2)
 {
     if ( l1.count() != l2.count() )
         return false;
     int count = l1.count();
     int i;
     for ( i = 0; i < count ; ++i ) {
         // if ( l1.at(i) != l2.at(i)   )
         return false;
         qDebug("compüare ");
     }
     return true;
 }
 */
 QString Recurrence::recurrenceText() const
 {
     QString recurText = i18n("No");
     if ( recurs == Recurrence::rMinutely  )
         recurText = i18n("minutely");
     else if ( recurs == Recurrence::rHourly  )
         recurText = i18n("hourly");
     else if ( recurs == Recurrence::rDaily  )
         recurText = i18n("daily");
     else if ( recurs ==  Recurrence::rWeekly ) 
         recurText = i18n("weekly");
     else if ( recurs == Recurrence::rMonthlyPos  )
         recurText = i18n("monthly");
     else if ( recurs ==  Recurrence::rMonthlyDay )
         recurText = i18n("day-monthly");
     else if ( recurs ==  Recurrence::rYearlyMonth )
         recurText = i18n("month-yearly");
     else if ( recurs ==  Recurrence::rYearlyDay )
         recurText = i18n("day-yearly");
     else if ( recurs ==  Recurrence::rYearlyPos )
         recurText = i18n("position-yearly");
     return recurText;
 }
 
 void Recurrence::setCompatVersion(int version)
 {
   mCompatVersion = version ? version : INT_MAX;
 }
 
 ushort Recurrence::doesRecur() const
 {
   return recurs;
 }
 
 bool Recurrence::recursOnPure(const QDate &qd) const
 {
   switch(recurs) {
     case rMinutely:
       return recursSecondly(qd, rFreq*60);
     case rHourly:
       return recursSecondly(qd, rFreq*3600);
     case rDaily:
       return recursDaily(qd);
     case rWeekly:
       return recursWeekly(qd);
     case rMonthlyPos:
     case rMonthlyDay:
       return recursMonthly(qd);
     case rYearlyMonth:
       return recursYearlyByMonth(qd);
     case rYearlyDay:
       return recursYearlyByDay(qd);
     case rYearlyPos:
       return recursYearlyByPos(qd);
     default:
         return false;
     case rNone:
       return false;
   } // case
   return false;
 }
 
 bool Recurrence::recursAtPure(const QDateTime &dt) const
 {
   switch(recurs) {
   case rMinutely:
     return recursMinutelyAt(dt, rFreq);
   case rHourly:
     return recursMinutelyAt(dt, rFreq*60);
   default:
     if (dt.time() != mRecurStart.time())
       return false;
     switch(recurs) {
       case rDaily:
         return recursDaily(dt.date());
       case rWeekly:
         return recursWeekly(dt.date());
       case rMonthlyPos:
       case rMonthlyDay:
         return recursMonthly(dt.date());
       case rYearlyMonth:
         return recursYearlyByMonth(dt.date());
       case rYearlyDay:
         return recursYearlyByDay(dt.date());
       case rYearlyPos:
         return recursYearlyByPos(dt.date());
       default:
           return false;
       case rNone:
         return false;
     }
   } // case
   return false;
 }
 
 QDate Recurrence::endDate() const
 {
   int count = 0;
   QDate end;
   if (recurs != rNone) {
     if (rDuration < 0)
       return QDate();    // infinite recurrence
     if (rDuration == 0)
       return rEndDateTime.date();
 
     // The end date is determined by the recurrence count
     QDate dStart = mRecurStart.date();
     switch (recurs)
     {
     case rMinutely:
       return mRecurStart.addSecs((rDuration-1+mRecurExDatesCount)*rFreq*60).date();
     case rHourly:
       return mRecurStart.addSecs((rDuration-1+mRecurExDatesCount)*rFreq*3600).date();
     case rDaily:
       return dStart.addDays((rDuration-1+mRecurExDatesCount)*rFreq);
 
     case rWeekly:
       count = weeklyCalc(END_DATE_AND_COUNT, end);
       break;
     case rMonthlyPos:
     case rMonthlyDay:
       count = monthlyCalc(END_DATE_AND_COUNT, end);
       break;
     case rYearlyMonth:
       count = yearlyMonthCalc(END_DATE_AND_COUNT, end);
       break;
     case rYearlyDay:
       count = yearlyDayCalc(END_DATE_AND_COUNT, end);
       break;
     case rYearlyPos:
       count = yearlyPosCalc(END_DATE_AND_COUNT, end);
       break;
     default:
       // catch-all.  Should never get here.
       kdDebug(5800) << "Control should never reach here in endDate()!" << endl;
       break;
     }
   }
   if (!count)
     return QDate();     // error - there is no recurrence
   return end;
 }
 
 QDateTime Recurrence::endDateTime() const
 {
   int count = 0;
   QDate end;
   if (recurs != rNone) {
     if (rDuration < 0)
       return QDateTime();    // infinite recurrence
     if (rDuration == 0)
       return rEndDateTime;
 
     // The end date is determined by the recurrence count
     QDate dStart = mRecurStart.date();
     switch (recurs)
     {
     case rMinutely:
       return mRecurStart.addSecs((rDuration-1+mRecurExDatesCount)*rFreq*60);
     case rHourly:
       return mRecurStart.addSecs((rDuration-1+mRecurExDatesCount)*rFreq*3600);
     case rDaily:
       return dStart.addDays((rDuration-1+mRecurExDatesCount)*rFreq);
 
     case rWeekly:
       count = weeklyCalc(END_DATE_AND_COUNT, end);
       break;
     case rMonthlyPos:
     case rMonthlyDay:
       count = monthlyCalc(END_DATE_AND_COUNT, end);
       break;
     case rYearlyMonth:
       count = yearlyMonthCalc(END_DATE_AND_COUNT, end);
       break;
     case rYearlyDay:
       count = yearlyDayCalc(END_DATE_AND_COUNT, end);
       break;
     case rYearlyPos:
       count = yearlyPosCalc(END_DATE_AND_COUNT, end);
       break;
     default:
       // catch-all.  Should never get here.
       kdDebug(5800) << "Control should never reach here in endDate()!" << endl;
       break;
     }
   }
   if (!count)
     return QDateTime();     // error - there is no recurrence
   return QDateTime(end, mRecurStart.time());
 }
 
 int Recurrence::durationTo(const QDate &date) const
 {
   QDate d = date;
   return recurCalc(COUNT_TO_DATE, d);
 }
 
 int Recurrence::durationTo(const QDateTime &datetime) const
 {
   QDateTime dt = datetime;
   return recurCalc(COUNT_TO_DATE, dt);
 }
 
 void Recurrence::unsetRecurs()
 {
   if (mRecurReadOnly) return;
   recurs = rNone;
   rMonthPositions.clear();
   rMonthDays.clear();
   rYearNums.clear();
 }
 
 void Recurrence::setRecurStart(const QDateTime &start)
 {
   mRecurStart = start;
   mFloats = false;
   switch (recurs)
   {
     case rMinutely:
     case rHourly:
       break;
     case rDaily:
     case rWeekly:
     case rMonthlyPos:
     case rMonthlyDay:
     case rYearlyMonth:
     case rYearlyDay:
     case rYearlyPos:
     default:
       rEndDateTime.setTime(start.time());
       break;
   }
 }