Added debug putput for program hang when reading pop3 mail data

4 files changed, 14 insertions, 5 deletions

diff --git a/kmicromail/libetpan/include/libetpan/mailstream.h b/kmicromail/libetpan/include/libetpan/mailstream.h
index a4e35cd..ffb5062 100644
--- a/kmicromail/libetpan/include/libetpan/mailstream.h
+++ b/kmicromail/libetpan/include/libetpan/mailstream.h
@@ -31,12 +31,13 @@
 
 /*
  * $Id$
  */
 
 #ifndef MAILSTREAM_H
+#define DEFAULT_NETWORK_TIMEOUT 30
 
 #define MAILSTREAM_H
 
 #include <sys/time.h>
 
 #include <libetpan/mailstream_low.h>
diff --git a/kmicromail/libetpan/tools/mailstream.c b/kmicromail/libetpan/tools/mailstream.c
index 0f55e67..6d1a8cc 100644
--- a/kmicromail/libetpan/tools/mailstream.c
+++ b/kmicromail/libetpan/tools/mailstream.c
@@ -37,13 +37,13 @@
 #include "maillock.h"
 #include <string.h>
 #include <stdlib.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 
-#define DEFAULT_NETWORK_TIMEOUT 300
+
 
 #ifdef LIBETPAN_MAILSTREAM_DEBUG
 
 #define STREAM_DEBUG
 
 #include <stdio.h>
diff --git a/kmicromail/libetpan/tools/mailstream.h b/kmicromail/libetpan/tools/mailstream.h
index a4e35cd..8a89a72 100644
--- a/kmicromail/libetpan/tools/mailstream.h
+++ b/kmicromail/libetpan/tools/mailstream.h
@@ -33,13 +33,14 @@
  * $Id$
  */
 
 #ifndef MAILSTREAM_H
 
 #define MAILSTREAM_H
-
+//dont forget to change the value in  <libetpan/mailstream.h> as well
+#define DEFAULT_NETWORK_TIMEOUT 30
 #include <sys/time.h>
 
 #include <libetpan/mailstream_low.h>
 #include <libetpan/mailstream_helper.h>
 #include <libetpan/mailstream_socket.h>
 #include <libetpan/mailstream_ssl.h>
diff --git a/kmicromail/libetpan/tools/mailstream_socket.c b/kmicromail/libetpan/tools/mailstream_socket.c
index 29e50e1..04a6f48 100644
--- a/kmicromail/libetpan/tools/mailstream_socket.c
+++ b/kmicromail/libetpan/tools/mailstream_socket.c
@@ -166,24 +166,27 @@ static ssize_t mailstream_low_socket_read(mailstream_low * s,
     timeout = mailstream_network_delay;
     
     FD_ZERO(&fds_read);
     FD_SET(socket_data->fd, &fds_read);
     FD_ZERO(&fds_excp);
     FD_SET(socket_data->fd, &fds_excp);
+    // LUTZ for safety I insert here a max val as well
+    if (  timeout.tv_sec > DEFAULT_NETWORK_TIMEOUT ) 
+        timeout.tv_sec = DEFAULT_NETWORK_TIMEOUT; 
     r = select(socket_data->fd + 1, &fds_read, NULL, &fds_excp, &timeout);
-    if (r == 0)
+    if (r < 1 )
       return -1;
     if (FD_ISSET(socket_data->fd, &fds_excp))
       return -1;
     if (!FD_ISSET(socket_data->fd, &fds_read))
       return 0;
   }
   return recv(socket_data->fd,buf,count,MSG_NOSIGNAL);
   //return read(socket_data->fd, buf, count);
 }
-
+#include <stdio.h>
 static ssize_t mailstream_low_socket_write(mailstream_low * s,
                                            const void * buf, size_t count)
 {
   struct mailstream_socket_data * socket_data;
 
   socket_data = (struct mailstream_socket_data *) s->data;
@@ -197,14 +200,18 @@ static ssize_t mailstream_low_socket_write(mailstream_low * s,
     timeout = mailstream_network_delay;
     
     FD_ZERO(&fds_write);
     FD_SET(socket_data->fd, &fds_write);
     FD_ZERO(&fds_excp);
     FD_SET(socket_data->fd, &fds_excp);
+    // LUTZ next line blocks sometimes
+    if (  timeout.tv_sec > DEFAULT_NETWORK_TIMEOUT ) 
+        timeout.tv_sec = DEFAULT_NETWORK_TIMEOUT; 
+    fprintf(stderr,"fd %d to secs %d  \n", socket_data->fd, timeout.tv_sec );
     r = select(socket_data->fd + 1, NULL, &fds_write, &fds_excp, &timeout);
-    if (r == 0)
+    if (r < 1)
       return -1;
     if (FD_ISSET(socket_data->fd, &fds_excp))
       return -1;
     if (!FD_ISSET(socket_data->fd, &fds_write))
       return 0;
   }