performance optimization during vCard loading

2 files changed, 29 insertions, 26 deletions

diff --git a/kabc/vcardformatimpl.cpp b/kabc/vcardformatimpl.cpp
index 3fcaf94..bd9a57b 100644
--- a/kabc/vcardformatimpl.cpp
+++ b/kabc/vcardformatimpl.cpp
@@ -52,10 +52,11 @@ bool VCardFormatImpl::load( Addressee &addressee, QFile *file )
 
   VCardListIterator it( e.cardList() );
 
   if ( it.current() ) {
-    VCard v(*it.current());
-    loadAddressee( addressee, v );
+//US    VCard v(*it.current());
+//US    loadAddressee( addressee, v );
+    loadAddressee( addressee, it.current() );
     return true;
   }
 
   return false;
@@ -72,11 +73,12 @@ bool VCardFormatImpl::loadAll( AddressBook *addressBook, Resource *resource, QFi
 
   VCardListIterator it( e.cardList() );
 
   for (; it.current(); ++it) {
-    VCard v(*it.current());
+//US    VCard v(*it.current());
     Addressee addressee;
-    loadAddressee( addressee, v );
+//US    loadAddressee( addressee, v );
+    loadAddressee( addressee, it.current() );
     addressee.setResource( resource );
     addressBook->insertAddressee( addressee );
   }
 
@@ -121,11 +123,11 @@ void VCardFormatImpl::saveAll( AddressBook *ab, Resource *resource, QFile *file
   QCString vcardData = vcards.asString();
   file->writeBlock( (const char*)vcardData, vcardData.length() );
 }
 
-bool VCardFormatImpl::loadAddressee( Addressee& addressee, VCard &v )
+bool VCardFormatImpl::loadAddressee( Addressee& addressee, VCard *v )
 {
-  QPtrList<ContentLine> contentLines = v.contentLineList();
+  QPtrList<ContentLine> contentLines = v->contentLineList();
   ContentLine *cl;
 
   for( cl = contentLines.first(); cl; cl = contentLines.next() ) {
     QCString n = cl->name();
@@ -783,21 +785,21 @@ void VCardFormatImpl::addAgentValue( VCARD::VCard *vcard, const Agent &agent )
     QString vstr;
     Addressee *addr = agent.addressee();
     if ( addr ) {
       writeToString( (*addr), vstr );
-      
+
       qDebug("VCardFormatImpl::addAgentValue please verify if replace is correct");
-/*US      
+/*US
       vstr.replace( ":", "\\:" );
       vstr.replace( ",", "\\," );
       vstr.replace( ";", "\\;" );
       vstr.replace( "\r\n", "\\n" );
-*/      
-      vstr.replace( QRegExp(":"), "\\:" );   
-      vstr.replace( QRegExp(","), "\\," );   
-      vstr.replace( QRegExp(";"), "\\;" );   
-      vstr.replace( QRegExp("\r\n"), "\\n" );   
-      
+*/
+      vstr.replace( QRegExp(":"), "\\:" );
+      vstr.replace( QRegExp(","), "\\," );
+      vstr.replace( QRegExp(";"), "\\;" );
+      vstr.replace( QRegExp("\r\n"), "\\n" );
+
       cl.setValue( new TextValue( vstr.utf8() ) );
     } else
       return;
   } else {
@@ -824,19 +826,19 @@ Agent VCardFormatImpl::readAgentValue( VCARD::ContentLine *cl )
 
   if ( isIntern ) {
     QString vstr = QString::fromUtf8( v->asString() );
     qDebug("VCardFormatImpl::addAgentValue please verify if replace is correct");
-/*US    
+/*US
     vstr.replace( "\\n", "\r\n" );
     vstr.replace( "\\:", ":" );
     vstr.replace( "\\,", "," );
     vstr.replace( "\\;", ";" );
 */
-    vstr.replace( QRegExp("\\n"), "\r\n" );   
-    vstr.replace( QRegExp("\\:"), ":" );   
-    vstr.replace( QRegExp("\\,"), "," );   
-    vstr.replace( QRegExp("\\;"), ";" );   
-    
+    vstr.replace( QRegExp("\\n"), "\r\n" );
+    vstr.replace( QRegExp("\\:"), ":" );
+    vstr.replace( QRegExp("\\,"), "," );
+    vstr.replace( QRegExp("\\;"), ";" );
+
     Addressee *addr = new Addressee;
     readFromString( vstr, *addr );
     agent.setAddressee( addr );
   } else {
@@ -865,9 +867,9 @@ void VCardFormatImpl::addPictureValue( VCARD::VCard *vcard, VCARD::EntityType ty
       QDataStream s( data, IO_WriteOnly );
       s.setVersion( 4 ); // to produce valid png files
       s << img;
       cl.setValue( new TextValue( KCodecs::base64Encode( data ) ) );
-      
+
     } else { // save picture in cache
       QString dir;
       if ( type == EntityPhoto )
         dir = "photos";
@@ -880,9 +882,9 @@ void VCardFormatImpl::addPictureValue( VCARD::VCard *vcard, VCARD::EntityType ty
     params.append( new Param( "ENCODING", "b" ) );
     if ( !pic.type().isEmpty() )
       params.append( new Param( "TYPE", pic.type().utf8() ) );
   } else {
-  
+
     cl.setValue( new TextValue( pic.url().utf8() ) );
     params.append( new Param( "VALUE", "uri" ) );
   }
 
@@ -1000,10 +1002,11 @@ bool VCardFormatImpl::readFromString( const QString &vcard, Addressee &addressee
   VCardEntity e( vcard.utf8() );
   VCardListIterator it( e.cardList() );
 
   if ( it.current() ) {
-    VCard v(*it.current());
-    loadAddressee( addressee, v );
+//US    VCard v(*it.current());
+//US    loadAddressee( addressee, v );
+    loadAddressee( addressee, it.current() );
     return true;
   }
 
   return false;
diff --git a/kabc/vcardformatimpl.h b/kabc/vcardformatimpl.h
index 2dd68d9..fa3d55f 100644
--- a/kabc/vcardformatimpl.h
+++ b/kabc/vcardformatimpl.h
@@ -41,9 +41,9 @@ namespace KABC {
 class AddressBook;
 
 /**
   @short Implementation of vCard backend for address book.
-  
+
   This class implements reading and writing of address book information using
   the vCard format. It requires the vCard lib from kdepim.
 */
 class VCardFormatImpl
@@ -57,9 +57,9 @@ class VCardFormatImpl
     bool readFromString( const QString &vcard, Addressee &addr );
     bool writeToString( const Addressee &addressee, QString &vcard );
 
   protected:
-    bool loadAddressee( Addressee &, VCARD::VCard & );
+    bool loadAddressee( Addressee &, VCARD::VCard * );
     void saveAddressee( const Addressee &, VCARD::VCard *, bool intern );
 
     void addTextValue (VCARD::VCard *, VCARD::EntityType, const QString & );
     QString readTextValue( VCARD::ContentLine * );