bugfix: memoryleak in vCards during loading of addressbooks

1 files changed, 20 insertions, 3 deletions

diff --git a/kabc/vcard/VCardv.cpp b/kabc/vcard/VCardv.cpp
index 8d271f4..3f0a5e5 100644
--- a/kabc/vcard/VCardv.cpp
+++ b/kabc/vcard/VCardv.cpp
@@ -1,107 +1,124 @@
 /*
 	libvcard - vCard parsing library for vCard version 3.0
 
 	Copyright (C) 1998 Rik Hemsley rik@kde.org
 
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to
   deal in the Software without restriction, including without limitation the
   rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
   sell copies of the Software, and to permit persons to whom the Software is
   furnished to do so, subject to the following conditions:
 
   The above copyright notice and this permission notice shall be included in
   all copies or substantial portions of the Software.
 
   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
   IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
   FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
   AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
   ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
   WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */
 
 #include <qcstring.h>
 #include <qstrlist.h>
 
 #include <VCardEntity.h>
 #include <VCardVCard.h>
 #include <VCardContentLine.h>
 #include <VCardRToken.h>
 
 #include <VCardDefines.h>
 
 using namespace VCARD;
 
 VCard::VCard()
 	:	Entity()
 {
+  contentLineList_.setAutoDelete( TRUE );
 }
 
 VCard::VCard(const VCard & x)
 	:	Entity(x),
-		group_(x.group_),
-		contentLineList_(x.contentLineList_)
+		group_(x.group_)
 {
+  contentLineList_.setAutoDelete( TRUE );
+  //US
+	qDebug("VCard::VCard");
+
+  QPtrListIterator<ContentLine> it(x.contentLineList_);
+  for (; it.current(); ++it) {
+    ContentLine * c = new ContentLine(*it.current());
+    contentLineList_.append(c);
+  }
+
 }
 
 VCard::VCard(const QCString & s)
 	:	Entity(s)
 {
+  contentLineList_.setAutoDelete( TRUE );
 }
 
 	VCard &
 VCard::operator = (VCard & x)
 {
+  //US
+	qDebug("VCard::operator =");
 	if (*this == x) return *this;
 
 	group_				= x.group();
-	contentLineList_	= x.contentLineList_;
+    QPtrListIterator<ContentLine> it(x.contentLineList_);
+    for (; it.current(); ++it) {
+      ContentLine * c = new ContentLine(*it.current());
+      contentLineList_.append(c);
+    }
 
 	Entity::operator = (x);
 	return *this;
 }
 
 	VCard &
 VCard::operator = (const QCString & s)
 {
 	Entity::operator = (s);
 	return *this;
 }
 
 	bool
 VCard::operator == (VCard & x)
 {
 	x.parse();
 	return false;
 }
 
 VCard::~VCard()
 {
 }
 
 	void
 VCard::_parse()
 {
 	vDebug("parse() called");
 	QStrList l;
 
 	RTokenise(strRep_, "\r\n", l);
 
 	if (l.count() < 3) { // Invalid VCARD !
 		vDebug("Invalid vcard");
 		return;
 	}
 
 	// Get the first line
 	QCString beginLine = QCString(l.at(0)).stripWhiteSpace();
 
 	vDebug("Begin line == \"" + beginLine + "\"");
 
 	// Remove extra blank lines
 	while (QCString(l.last()).isEmpty())
 		l.remove(l.last());
 
 	// Now we know this is the last line
 	QCString endLine = l.last();