fixes

1 files changed, 5 insertions, 47 deletions

diff --git a/kabc/plugins/sharpdtm/sharpdtmconverter.cpp b/kabc/plugins/sharpdtm/sharpdtmconverter.cpp
index 95e16b6..4adcae4 100644
--- a/kabc/plugins/sharpdtm/sharpdtmconverter.cpp
+++ b/kabc/plugins/sharpdtm/sharpdtmconverter.cpp
@@ -295,192 +295,150 @@ bool SharpDTMConverter::addresseeToSharp( const Addressee &addr, SlZDataBase* da
         if ( !addr.familyName().isEmpty() ) {
             formattedName = addr.familyName();
             if ( !addr.givenName().isEmpty() ) {
                 formattedName += ", ";
                 formattedName += addr.givenName();
             }
         } else
             formattedName = addr.givenName();
     }
     database->writeField(ZdbAdrs::FileAs, formattedName);
     database->writeField(ZdbAdrs::FullName, formattedName);
 
     // email
     //qDebug("SharpDTMConverter::addresseeToSharp check which seperator we need here for the emails!!");
     //qDebug("SharpDTMConverter::addresseeToSharp its probably the same from sharpToAddressee");
     QString emails = addr.emails().join(" ");
     database->writeField(ZdbAdrs::Emails, emails );
 
     database->writeField(ZdbAdrs::DefaultEmail, addr.preferredEmail() );
     // home
     const Address homeaddress = addr.address(Address::Home);
     database->writeField(ZdbAdrs::HomeStreet, homeaddress.street());
     database->writeField(ZdbAdrs::HomeCity, homeaddress.locality());
     database->writeField(ZdbAdrs::HomeState, homeaddress.region());
     database->writeField(ZdbAdrs::HomeZip, homeaddress.postalCode());
     database->writeField(ZdbAdrs::HomeCountry, homeaddress.country());
     
     PhoneNumber homephone = addr.phoneNumber( PhoneNumber::Home );
     database->writeField(ZdbAdrs::HomePhone, homephone.number());
     PhoneNumber homefax = addr.phoneNumber( PhoneNumber::Home | PhoneNumber::Fax );
     database->writeField(ZdbAdrs::HomeFax, homefax.number());
     PhoneNumber homemobile = addr.phoneNumber( PhoneNumber::Home | PhoneNumber::Cell );
     database->writeField(ZdbAdrs::HomeMobile, homemobile.number());
     if (!homemobile.number().isEmpty()) {
       cellHome = true;
     }
     database->writeField(ZdbAdrs::HomeWebPage, addr.url().url());
     // business
     const Address businessaddress = addr.address(Address::Work);
         //qDebug("write business address ");
     database->writeField(ZdbAdrs::BusinessStreet, businessaddress.street());
     database->writeField(ZdbAdrs::BusinessCity, businessaddress.locality());
     database->writeField(ZdbAdrs::BusinessState, businessaddress.region());
     database->writeField(ZdbAdrs::BusinessZip, businessaddress.postalCode());
     database->writeField(ZdbAdrs::BusinessCountry, businessaddress.country());
     
     PhoneNumber businessphone = addr.phoneNumber( PhoneNumber::Work );
     database->writeField(ZdbAdrs::BusinessPhone, businessphone.number());
 
     PhoneNumber businessfax = addr.phoneNumber( PhoneNumber::Work | PhoneNumber::Fax );
     database->writeField(ZdbAdrs::BusinessFax, businessfax.number());
 
     PhoneNumber businessmobile = addr.phoneNumber( PhoneNumber::Work | PhoneNumber::Cell );
     database->writeField(ZdbAdrs::BusinessMobile, businessmobile.number());
     if (!businessmobile.number().isEmpty()) {
         cellWork = true;
     }
     PhoneNumber mobile = addr.phoneNumber( PhoneNumber::Cell );
     if (! mobile.number().isEmpty()) {
         if ( ! cellHome ) 
             database->writeField(ZdbAdrs::HomeMobile, mobile.number());
         else if (! cellWork )
             database->writeField(ZdbAdrs::BusinessMobile, mobile.number());
     }
 
     PhoneNumber businesspager = addr.phoneNumber( PhoneNumber::Work | PhoneNumber::Pager );
     database->writeField(ZdbAdrs::BusinessPager, businesspager.number());
 
     database->writeField(ZdbAdrs::JobTitle, addr.role());
     database->writeField(ZdbAdrs::Company, addr.organization());
 
     database->writeField(ZdbAdrs::Profession, addr.custom( "KADDRESSBOOK", "X-Profession" ));
     database->writeField(ZdbAdrs::Assistant, addr.custom( "KADDRESSBOOK", "X-AssistantsName" ));
     database->writeField(ZdbAdrs::Department, addr.custom( "KADDRESSBOOK", "X-Department" ));
     database->writeField(ZdbAdrs::Manager, addr.custom( "KADDRESSBOOK", "X-ManagersName" ));
     database->writeField(ZdbAdrs::Office, addr.custom( "KADDRESSBOOK", "X-Office" ));
 
     //personal
     database->writeField(ZdbAdrs::Spouse, addr.custom( "KADDRESSBOOK", "X-Spouse" ));
 
     QString gt = addr.custom( "KADDRESSBOOK", "X-Gender" );
 	//qDebug("SharpDTMConverter::addresseeToSharp please check that gender works!! : Gender: %s", gt.latin1());
 	//qDebug("SharpDTMConverter::addresseeToSharp: may be writeField(\"ZdbAdrs::Gender\", ushort) is here better suited?");
 	//qDebug("SharpDTMConverter::addresseeToSharp: check also the reverse functionality in sharpToAddressee");
     if (gt == "male")
       database->writeField(ZdbAdrs::Gender, "1");
     else if (gt == "female")
       database->writeField(ZdbAdrs::Gender, "2");
     else
       database->writeField(ZdbAdrs::Gender, "");
 
     QString dateS ;
     QDate dt = KGlobal::locale()->readDate(addr.custom("KADDRESSBOOK", "X-Anniversary" ), "%Y-%m-%d"); // = Qt::ISODate
     if ( dt.isValid() ) {
         dateS =  KGlobal::locale()->formatDate(dt, true  );
     }
     database->writeField(ZdbAdrs::Anniversary, dateS );
     database->writeField(ZdbAdrs::Children, addr.custom( "KADDRESSBOOK", "X-Children" ));
     dt = addr.birthday().date(); 
     dateS = ""; 
     if ( dt.isValid() ) {
         dateS =  KGlobal::locale()->formatDate(dt, true );
     }
     database->writeField(ZdbAdrs::Birthday, dateS);
     database->writeField(ZdbAdrs::Nickname, addr.nickName());
 
     // other
     database->writeField(ZdbAdrs::Notes, addr.note());
 
 //US    QString groups() const { return find( Qtopia::Groups ); }
 //US    QStringList groupList() const; 
 
 
 	//qDebug("SharpDTMConverter::addresseeToSharp please check if category transformation works");
 
     return true;
 }
 
 
 bool SharpDTMConverter::setCategories( const Addressee &addr, SlZDataBase* database , const CardId &contact )
 {  
     QStringList list = addr.categories();
 
 	QArray<int> ids(list.count());
 	uint index = 0;
 	for(uint i=0; i<ids.size(); i++){
 		if(catDB->exists(list[i])){
 			ids[index] = catDB->id(list[i]);
-            qDebug("set ex cat %d %s ",ids[index] , list[i].latin1());
+            //qDebug("set exist cat %d %s ",ids[index] , list[i].latin1());
 			index++;
 		} else {
 			ids[index] = catDB->addCategory(list[i]);
-            qDebug("add new cat %d %s ",ids[index] , list[i].latin1());
+            //qDebug("add new cat %d %s ",ids[index] , list[i].latin1());
 			index++;
 		}
 	}
     bool res ;
-    if ( res = database->updateCategories(contact, ids) )
-        qDebug("cat updated ");
-    else
-        qDebug("error cat updating ");
+
+    if ( !(res = database->updateCategories(contact, ids) ))
+        qDebug("SharpDTMConverter::Error updating categories");
 
     return res;
 }
 
-#if 0
-	m_pCategories = new SlCategories;
-catDB
-
-	if(categories == QString::null) return true;
-	QStringList list = CSVParser::parse(categories);
-	QArray<int> ids(list.count());
-	uint index = 0;
-	for(uint i=0; i<ids.size(); i++){
-#if 0
-		bool ok;
-		ids[index] = list[i].toInt(&ok);
-		if(ok){
-			index++;
-		} else {
-			if(m_pCategories->exists(list[i])){
-				ids[index] = m_pCategories->id(list[i]);
-				index++;
-			}
-		}
-#else
-		if(m_pCategories->exists(list[i])){
-			ids[index] = m_pCategories->id(list[i]);
-			index++;
-		} else if(m_addCategory){
-			ids[index] = m_pCategories->addCategory(list[i]);
-			index++;
-		}
-#endif
-	}
-	if(ids.size() > 0 && index == 0){
-		return true;
-	} else if(index != ids.size()){
-		ids.resize(index);
-	}
-	if(!m_pZdb->updateCategories(id, ids)){
-		return false;
-	}
-	return true;
-#endif
-
 QDate SharpDTMConverter::convertDate( QString  s)
 {
     QDate dt = KGlobal::locale()->readDate( s ); 
     return dt;
     return QDate ();
 }