author | zautrix <zautrix> | 2004-09-11 23:25:03 (UTC) |
---|---|---|
committer | zautrix <zautrix> | 2004-09-11 23:25:03 (UTC) |
commit | 0a2900e71fd3d80393d67c81aab3aae19d2d680c (patch) (unidiff) | |
tree | 1f2926eca6bee600819932603eaaf28c7f267d6b | |
parent | a040c9d56282dae396b02627fafb602e44323837 (diff) | |
download | kdepimpi-0a2900e71fd3d80393d67c81aab3aae19d2d680c.zip kdepimpi-0a2900e71fd3d80393d67c81aab3aae19d2d680c.tar.gz kdepimpi-0a2900e71fd3d80393d67c81aab3aae19d2d680c.tar.bz2 |
Bugfixes
-rw-r--r-- | kabc/plugins/dir/resourcedir.cpp | 32 | ||||
-rw-r--r-- | kabc/plugins/file/resourcefile.cpp | 16 | ||||
-rw-r--r-- | kabc/plugins/sharpdtm/resourcesharpdtm.cpp | 15 | ||||
-rw-r--r-- | kmicromail/accountitem.h | 2 |
4 files changed, 44 insertions, 21 deletions
diff --git a/kabc/plugins/dir/resourcedir.cpp b/kabc/plugins/dir/resourcedir.cpp index fac06a1..7d96cb7 100644 --- a/kabc/plugins/dir/resourcedir.cpp +++ b/kabc/plugins/dir/resourcedir.cpp | |||
@@ -59,6 +59,8 @@ $Id$ | |||
59 | #include "resourcedir.h" | 59 | #include "resourcedir.h" |
60 | #include "syncprefwidget.h" | 60 | #include "syncprefwidget.h" |
61 | 61 | ||
62 | //#define ALLOW_LOCKING | ||
63 | |||
62 | using namespace KABC; | 64 | using namespace KABC; |
63 | 65 | ||
64 | extern "C" | 66 | extern "C" |
@@ -136,16 +138,17 @@ void ResourceDir::writeConfig( KConfig *config ) | |||
136 | 138 | ||
137 | Ticket *ResourceDir::requestSaveTicket() | 139 | Ticket *ResourceDir::requestSaveTicket() |
138 | { | 140 | { |
139 | kdDebug(5700) << "ResourceDir::requestSaveTicket()" << endl; | 141 | |
140 | 142 | ||
141 | if ( !addressBook() ) return 0; | 143 | if ( !addressBook() ) return 0; |
142 | 144 | #ifdef ALLOW_LOCKING | |
143 | if ( !lock( mPath ) ) { | 145 | if ( !lock( mPath ) ) { |
144 | kdDebug(5700) << "ResourceDir::requestSaveTicket(): Unable to lock path '" | 146 | |
145 | << mPath << "'" << endl; | ||
146 | return 0; | 147 | return 0; |
147 | } | 148 | } |
149 | #endif | ||
148 | return createTicket( this ); | 150 | return createTicket( this ); |
151 | |||
149 | } | 152 | } |
150 | 153 | ||
151 | 154 | ||
@@ -178,8 +181,6 @@ void ResourceDir::doClose() | |||
178 | 181 | ||
179 | bool ResourceDir::load() | 182 | bool ResourceDir::load() |
180 | { | 183 | { |
181 | kdDebug(5700) << "ResourceDir::load(): '" << mPath << "'" << endl; | ||
182 | |||
183 | QDir dir( mPath ); | 184 | QDir dir( mPath ); |
184 | QStringList files = dir.entryList( QDir::Files ); | 185 | QStringList files = dir.entryList( QDir::Files ); |
185 | 186 | ||
@@ -205,8 +206,6 @@ bool ResourceDir::load() | |||
205 | 206 | ||
206 | bool ResourceDir::save( Ticket *ticket ) | 207 | bool ResourceDir::save( Ticket *ticket ) |
207 | { | 208 | { |
208 | kdDebug(5700) << "ResourceDir::save(): '" << mPath << "'" << endl; | ||
209 | |||
210 | AddressBook::Iterator it; | 209 | AddressBook::Iterator it; |
211 | bool ok = true; | 210 | bool ok = true; |
212 | 211 | ||
@@ -232,15 +231,15 @@ bool ResourceDir::save( Ticket *ticket ) | |||
232 | mDirWatch.startScan(); | 231 | mDirWatch.startScan(); |
233 | 232 | ||
234 | delete ticket; | 233 | delete ticket; |
234 | #ifdef ALLOW_LOCKING | ||
235 | unlock( mPath ); | 235 | unlock( mPath ); |
236 | 236 | #endif | |
237 | return ok; | 237 | return ok; |
238 | } | 238 | } |
239 | 239 | ||
240 | bool ResourceDir::lock( const QString &path ) | 240 | bool ResourceDir::lock( const QString &path ) |
241 | { | 241 | { |
242 | kdDebug(5700) << "ResourceDir::lock()" << endl; | 242 | #ifdef ALLOW_LOCKING |
243 | |||
244 | QString p = path; | 243 | QString p = path; |
245 | //US change the implementation how the lockfilename is getting created | 244 | //US change the implementation how the lockfilename is getting created |
246 | //US p.replace( QRegExp("/"), "_" ); | 245 | //US p.replace( QRegExp("/"), "_" ); |
@@ -249,8 +248,6 @@ bool ResourceDir::lock( const QString &path ) | |||
249 | QString lockName = locateLocal( "data", "kabc/lock/" + url.fileName() + ".lock" ); | 248 | QString lockName = locateLocal( "data", "kabc/lock/" + url.fileName() + ".lock" ); |
250 | 249 | ||
251 | 250 | ||
252 | kdDebug(5700) << "-- lock name: " << lockName << endl; | ||
253 | |||
254 | if ( QFile::exists( lockName ) ) return false; | 251 | if ( QFile::exists( lockName ) ) return false; |
255 | 252 | ||
256 | QString lockUniqueName; | 253 | QString lockUniqueName; |
@@ -260,8 +257,6 @@ bool ResourceDir::lock( const QString &path ) | |||
260 | //US mLockUniqueName = locateLocal( "data", "kabc/lock/" + lockUniqueName ); | 257 | //US mLockUniqueName = locateLocal( "data", "kabc/lock/" + lockUniqueName ); |
261 | mLockUniqueName = locateLocal( "data", "kabc/lock/" + url.fileName() ); | 258 | mLockUniqueName = locateLocal( "data", "kabc/lock/" + url.fileName() ); |
262 | 259 | ||
263 | kdDebug(5700) << "-- lock unique name: " << mLockUniqueName << endl; | ||
264 | |||
265 | // Create unique file | 260 | // Create unique file |
266 | QFile file( mLockUniqueName ); | 261 | QFile file( mLockUniqueName ); |
267 | file.open( IO_WriteOnly ); | 262 | file.open( IO_WriteOnly ); |
@@ -281,10 +276,14 @@ bool ResourceDir::lock( const QString &path ) | |||
281 | // TODO: check stat | 276 | // TODO: check stat |
282 | 277 | ||
283 | return false; | 278 | return false; |
279 | #else | ||
280 | return true; | ||
281 | #endif | ||
284 | } | 282 | } |
285 | 283 | ||
286 | void ResourceDir::unlock( const QString &path ) | 284 | void ResourceDir::unlock( const QString &path ) |
287 | { | 285 | { |
286 | #ifdef ALLOW_LOCKING | ||
288 | QString p = path; | 287 | QString p = path; |
289 | //US change the implementation how the lockfilename is getting created | 288 | //US change the implementation how the lockfilename is getting created |
290 | //US p.replace( QRegExp( "/" ), "_" ); | 289 | //US p.replace( QRegExp( "/" ), "_" ); |
@@ -295,6 +294,9 @@ void ResourceDir::unlock( const QString &path ) | |||
295 | ::unlink( QFile::encodeName( lockName ) ); | 294 | ::unlink( QFile::encodeName( lockName ) ); |
296 | QFile::remove( mLockUniqueName ); | 295 | QFile::remove( mLockUniqueName ); |
297 | addressBook()->emitAddressBookUnlocked(); | 296 | addressBook()->emitAddressBookUnlocked(); |
297 | #else | ||
298 | return; | ||
299 | #endif | ||
298 | } | 300 | } |
299 | 301 | ||
300 | void ResourceDir::setPath( const QString &path ) | 302 | void ResourceDir::setPath( const QString &path ) |
diff --git a/kabc/plugins/file/resourcefile.cpp b/kabc/plugins/file/resourcefile.cpp index fa6bc49..17263ae 100644 --- a/kabc/plugins/file/resourcefile.cpp +++ b/kabc/plugins/file/resourcefile.cpp | |||
@@ -53,6 +53,7 @@ $Id$ | |||
53 | #include "resourcefile.h" | 53 | #include "resourcefile.h" |
54 | #include "syncprefwidget.h" | 54 | #include "syncprefwidget.h" |
55 | 55 | ||
56 | //#define ALLOW_LOCKING | ||
56 | 57 | ||
57 | using namespace KABC; | 58 | using namespace KABC; |
58 | 59 | ||
@@ -147,11 +148,12 @@ Ticket *ResourceFile::requestSaveTicket() | |||
147 | 148 | ||
148 | if ( !addressBook() ) return 0; | 149 | if ( !addressBook() ) return 0; |
149 | 150 | ||
151 | #ifdef ALLOW_LOCKING | ||
150 | if ( !lock( mFileName ) ) { | 152 | if ( !lock( mFileName ) ) { |
151 | kdDebug(5700) << "ResourceFile::requestSaveTicket(): Unable to lock file '" | 153 | qDebug("unablt to lock file "); |
152 | << mFileName << "'" << endl; | ||
153 | return 0; | 154 | return 0; |
154 | } | 155 | } |
156 | #endif | ||
155 | return createTicket( this ); | 157 | return createTicket( this ); |
156 | } | 158 | } |
157 | 159 | ||
@@ -246,13 +248,16 @@ bool ResourceFile::save( Ticket *ticket ) | |||
246 | mDirWatch.startScan(); | 248 | mDirWatch.startScan(); |
247 | 249 | ||
248 | delete ticket; | 250 | delete ticket; |
251 | #ifdef ALLOW_LOCKING | ||
249 | unlock( mFileName ); | 252 | unlock( mFileName ); |
253 | #endif | ||
250 | 254 | ||
251 | return ok; | 255 | return ok; |
252 | } | 256 | } |
253 | 257 | ||
254 | bool ResourceFile::lock( const QString &fileName ) | 258 | bool ResourceFile::lock( const QString &fileName ) |
255 | { | 259 | { |
260 | #ifdef ALLOW_LOCKING | ||
256 | 261 | ||
257 | 262 | ||
258 | QString fn = fileName; | 263 | QString fn = fileName; |
@@ -295,10 +300,14 @@ bool ResourceFile::lock( const QString &fileName ) | |||
295 | // TODO: check stat | 300 | // TODO: check stat |
296 | 301 | ||
297 | return false; | 302 | return false; |
303 | #else | ||
304 | return true; | ||
305 | #endif | ||
298 | } | 306 | } |
299 | 307 | ||
300 | void ResourceFile::unlock( const QString &fileName ) | 308 | void ResourceFile::unlock( const QString &fileName ) |
301 | { | 309 | { |
310 | #ifdef ALLOW_LOCKING | ||
302 | QString fn = fileName; | 311 | QString fn = fileName; |
303 | //US change the implementation how the lockfilename is getting created | 312 | //US change the implementation how the lockfilename is getting created |
304 | //US fn.replace( QRegExp( "/" ), "_" ); | 313 | //US fn.replace( QRegExp( "/" ), "_" ); |
@@ -310,6 +319,9 @@ void ResourceFile::unlock( const QString &fileName ) | |||
310 | QFile::remove( lockName ); | 319 | QFile::remove( lockName ); |
311 | QFile::remove( mLockUniqueName ); | 320 | QFile::remove( mLockUniqueName ); |
312 | addressBook()->emitAddressBookUnlocked(); | 321 | addressBook()->emitAddressBookUnlocked(); |
322 | #else | ||
323 | return; | ||
324 | #endif | ||
313 | } | 325 | } |
314 | 326 | ||
315 | void ResourceFile::setFileName( const QString &fileName ) | 327 | void ResourceFile::setFileName( const QString &fileName ) |
diff --git a/kabc/plugins/sharpdtm/resourcesharpdtm.cpp b/kabc/plugins/sharpdtm/resourcesharpdtm.cpp index 8a795e9..867bc07 100644 --- a/kabc/plugins/sharpdtm/resourcesharpdtm.cpp +++ b/kabc/plugins/sharpdtm/resourcesharpdtm.cpp | |||
@@ -54,7 +54,7 @@ $Id$ | |||
54 | #include "stdaddressbook.h" | 54 | #include "stdaddressbook.h" |
55 | 55 | ||
56 | #include "sharpdtmconverter.h" | 56 | #include "sharpdtmconverter.h" |
57 | 57 | //#define ALLOW_LOCKING | |
58 | using namespace KABC; | 58 | using namespace KABC; |
59 | extern "C" | 59 | extern "C" |
60 | { | 60 | { |
@@ -105,17 +105,18 @@ void ResourceSharpDTM::writeConfig( KConfig *config ) | |||
105 | 105 | ||
106 | Ticket *ResourceSharpDTM::requestSaveTicket() | 106 | Ticket *ResourceSharpDTM::requestSaveTicket() |
107 | { | 107 | { |
108 | kdDebug(5700) << "ResourceSharpDTM::requestSaveTicket()" << endl; | 108 | |
109 | 109 | ||
110 | qDebug("ResourceSharpDTM::requestSaveTicket: %s", fileName().latin1()); | 110 | qDebug("ResourceSharpDTM::requestSaveTicket: %s", fileName().latin1()); |
111 | 111 | ||
112 | if ( !addressBook() ) return 0; | 112 | if ( !addressBook() ) return 0; |
113 | 113 | ||
114 | #ifdef ALLOW_LOCKING | ||
114 | if ( !lock( fileName() ) ) { | 115 | if ( !lock( fileName() ) ) { |
115 | kdDebug(5700) << "ResourceSharpDTM::requestSaveTicket(): Unable to lock file '" | 116 | qDebug("ResourceSharpDTM::requestSaveTicket(): Unable to lock file "); |
116 | << fileName() << "'" << endl; | ||
117 | return 0; | 117 | return 0; |
118 | } | 118 | } |
119 | #endif | ||
119 | return createTicket( this ); | 120 | return createTicket( this ); |
120 | } | 121 | } |
121 | 122 | ||
@@ -240,6 +241,7 @@ bool ResourceSharpDTM::save( Ticket *ticket ) | |||
240 | 241 | ||
241 | bool ResourceSharpDTM::lock( const QString &lockfileName ) | 242 | bool ResourceSharpDTM::lock( const QString &lockfileName ) |
242 | { | 243 | { |
244 | #ifdef ALLOW_LOCKING | ||
243 | qDebug("ResourceSharpDTM::lock: %s", fileName().latin1()); | 245 | qDebug("ResourceSharpDTM::lock: %s", fileName().latin1()); |
244 | 246 | ||
245 | kdDebug(5700) << "ResourceSharpDTM::lock()" << endl; | 247 | kdDebug(5700) << "ResourceSharpDTM::lock()" << endl; |
@@ -285,10 +287,14 @@ bool ResourceSharpDTM::lock( const QString &lockfileName ) | |||
285 | // TODO: check stat | 287 | // TODO: check stat |
286 | 288 | ||
287 | return false; | 289 | return false; |
290 | #else | ||
291 | return true; | ||
292 | #endif | ||
288 | } | 293 | } |
289 | 294 | ||
290 | void ResourceSharpDTM::unlock( const QString &fileName ) | 295 | void ResourceSharpDTM::unlock( const QString &fileName ) |
291 | { | 296 | { |
297 | #ifdef ALLOW_LOCKING | ||
292 | qDebug("ResourceSharpDTM::unlock() %s", fileName.latin1()); | 298 | qDebug("ResourceSharpDTM::unlock() %s", fileName.latin1()); |
293 | 299 | ||
294 | QString fn = fileName; | 300 | QString fn = fileName; |
@@ -298,6 +304,7 @@ void ResourceSharpDTM::unlock( const QString &fileName ) | |||
298 | QFile::remove( lockName ); | 304 | QFile::remove( lockName ); |
299 | QFile::remove( mLockUniqueName ); | 305 | QFile::remove( mLockUniqueName ); |
300 | addressBook()->emitAddressBookUnlocked(); | 306 | addressBook()->emitAddressBookUnlocked(); |
307 | #endif | ||
301 | } | 308 | } |
302 | 309 | ||
303 | void ResourceSharpDTM::setFileName( const QString &newFileName ) | 310 | void ResourceSharpDTM::setFileName( const QString &newFileName ) |
diff --git a/kmicromail/accountitem.h b/kmicromail/accountitem.h index faf919d..4c92bfc 100644 --- a/kmicromail/accountitem.h +++ b/kmicromail/accountitem.h | |||
@@ -1,9 +1,11 @@ | |||
1 | #ifndef __ACCOUNT_ITEM | 1 | #ifndef __ACCOUNT_ITEM |
2 | #define __ACCOUNT_ITEM | 2 | #define __ACCOUNT_ITEM |
3 | 3 | ||
4 | |||
4 | #include <qlistview.h> | 5 | #include <qlistview.h> |
5 | #include <qlist.h> | 6 | #include <qlist.h> |
6 | #include <opie2/osmartpointer.h> | 7 | #include <opie2/osmartpointer.h> |
8 | #include <libmailwrapper/mailwrapper.h> | ||
7 | 9 | ||
8 | class POP3wrapper; | 10 | class POP3wrapper; |
9 | class RecMail; | 11 | class RecMail; |