ompi html fixes

author: zautrix <zautrix> 2005-02-24 11:19:48 (UTC)
committer: zautrix <zautrix> 2005-02-24 11:19:48 (UTC)
commit: ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb (patch) (unidiff)
tree: b3b4c6ee66b7ae39fad43622a2badacdbe9ed4e1
parent: 66ea8a0023a2a58e7887a41c265f2a7112b6b625 (diff)
download: kdepimpi-ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb.zip
kdepimpi-ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb.tar.gz
kdepimpi-ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb.tar.bz2
3 files changed, 25 insertions, 3 deletions
diff --git a/bin/kdepim/WhatsNew.txt b/bin/kdepim/WhatsNew.txt
index 0596511..86ac9b5 100644
--- a/bin/kdepim/WhatsNew.txt
+++ b/bin/kdepim/WhatsNew.txt
@@ -4,16 +4,19 @@ Info about the changes in new versions of KDE-Pim/Pi
 KO/Pi:
 Fixed a bug in todo start/due date handling for non recurring todos with a start and due date.
 Fixed some layout problems in the KO/Pi agenda view when there were many conflicting itmes. 
 Fixed several problems of the keyboard focus in the desktop versions when opening the search dialog/event viewer.
 Fixed problem in pi-sync mode when wrong password was sent.
+OM/Pi:
+Fixed a crash when displaying mails with "Show mail as html" was checked in the config.
+Added a check before displaying the mail if the mail is in html format, if "Show mail as html" is enabled.
 ********** VERSION 2.0.11 ************
 Fixed some problems in pi-sync mode
 (e.g. details of events were not synced properly)
 ********** VERSION 2.0.10 ************
diff --git a/kmicromail/viewmail.cpp b/kmicromail/viewmail.cpp
index 726f540..685b4e4 100644
--- a/kmicromail/viewmail.cpp
+++ b/kmicromail/viewmail.cpp
@@ -94,16 +94,28 @@ AttachItem* ViewMail::lastChild(AttachItem*parent)
    return item;
 }
 void ViewMail::setBody(const RecBodyP&body )
 {
    m_body = body;
    m_mail[2] = body->Bodytext();
+    m_showHtml =  KOPrefs::instance()->mViewAsHtml;
+    if ( m_showHtml ) {
+        if ( m_mail[2].find ("<html>",0,false ) > -1 ) {
+            qDebug("html mail ");
+        } else {
+            qDebug("no html mail ");
+            m_showHtml = false;
+        }
+    }
+    showHtml->blockSignals( true );
+    showHtml->setOn( m_showHtml );
+    showHtml->blockSignals( false );
    // qDebug("********text %s ",m_mail[2].latin1() );
    attachbutton->setEnabled(body->Parts().count()>0);
    attachments->setEnabled(body->Parts().count()>0);
    if (body->Parts().count()==0)
    {
        return;
    }
    AttachItem * curItem=0;
@@ -326,37 +338,44 @@ void ViewMail::setMail(const RecMailP&mail )
    m_mail2[0] = mail->To();
    m_mail2[1] = mail->CC();
    m_mail2[2] = mail->Bcc();
    setText();
 }
+void ViewMail::slotNextMail() 
+{ 
+    nextMail->blockSignals( true );
+    setCaption(i18n("Displaying next mail...please wait!")); 
+    qApp->processEvents();
+    emit  showNextMail(this); 
+    nextMail->blockSignals( false );
+}
 ViewMail::ViewMail( QWidget *parent, const char *name, WFlags fl)
        : ViewMailBase(parent, name, fl), _inLoop(false)
 {
    m_gotBody = false;
    deleted = false;
    sourceOn = false;
+    readConfig();
    connect( reply, SIGNAL(activated()), SLOT(slotReply()));
    connect( forward, SIGNAL(activated()), SLOT(slotForward()));
    connect( deleteMail, SIGNAL( activated() ),  SLOT( slotDeleteMail() ) );
    connect( showHtml, SIGNAL( toggled(bool) ), SLOT( slotShowHtml(bool) ) ); 
    connect( closeMail, SIGNAL( activated() ), SLOT( close() ) ); 
    connect( nextMail, SIGNAL( activated() ), SLOT( slotNextMail() ) );
    connect( viewSource, SIGNAL( activated() ), SLOT( slotViewSource() ) );
    connect( downloadMail, SIGNAL( activated() ), SIGNAL( signalDownloadMail() ) );
    attachments->setEnabled(m_gotBody);
    connect( attachments,  SIGNAL( clicked(QListViewItem*,const QPoint&, int) ), SLOT( slotItemClicked(QListViewItem*,const QPoint&, int) ) );
-    readConfig();
    attachments->setSorting(-1);
 }
 void ViewMail::readConfig()
 {
 
    setFont ( KOPrefs::instance()->mReadFont );
    m_showHtml =  KOPrefs::instance()->mViewAsHtml;
diff --git a/kmicromail/viewmail.h b/kmicromail/viewmail.h
index fc5edcf..bb5b685 100644
--- a/kmicromail/viewmail.h
+++ b/kmicromail/viewmail.h
@@ -49,17 +49,17 @@ public:
    void deleteAndDisplayNextMail(ViewMail *);
    void signalDownloadMail();
 protected:
    QString deHtml(const QString &string);
    AttachItem* searchParent(const QValueList<int>&path);
    AttachItem* lastChild(AttachItem*parent);
 protected slots:
-    void slotNextMail() { setCaption(i18n("Displaying next mail...please wait!")); qApp->processEvents();emit  showNextMail(this); };
+    void slotNextMail();
    void slotReply();
    void slotForward();
    void setText();
    void slotItemClicked( QListViewItem * item , const QPoint & point, int c );
    void slotDeleteMail( );
    void slotShowHtml( bool );
    void slotViewSource();
author	zautrix <zautrix>	2005-02-24 11:19:48 (UTC)
committer	zautrix <zautrix>	2005-02-24 11:19:48 (UTC)
commit	ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb (patch) (unidiff)
tree	b3b4c6ee66b7ae39fad43622a2badacdbe9ed4e1
parent	66ea8a0023a2a58e7887a41c265f2a7112b6b625 (diff)
download	kdepimpi-ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb.zip kdepimpi-ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb.tar.gz kdepimpi-ff8a2f593fae5ffe82f889ab70d32bf02a45f4fb.tar.bz2

diff --git a/bin/kdepim/WhatsNew.txt b/bin/kdepim/WhatsNew.txt index 0596511..86ac9b5 100644 --- a/bin/kdepim/WhatsNew.txt +++ b/bin/kdepim/WhatsNew.txt
@@ -4,16 +4,19 @@ Info about the changes in new versions of KDE-Pim/Pi
4		4
5	KO/Pi:	5	KO/Pi:
6	Fixed a bug in todo start/due date handling for non recurring todos with a start and due date.	6	Fixed a bug in todo start/due date handling for non recurring todos with a start and due date.
7	Fixed some layout problems in the KO/Pi agenda view when there were many conflicting itmes.	7	Fixed some layout problems in the KO/Pi agenda view when there were many conflicting itmes.
8	Fixed several problems of the keyboard focus in the desktop versions when opening the search dialog/event viewer.	8	Fixed several problems of the keyboard focus in the desktop versions when opening the search dialog/event viewer.
9		9
10	Fixed problem in pi-sync mode when wrong password was sent.	10	Fixed problem in pi-sync mode when wrong password was sent.
11		11
		12	OM/Pi:
		13	Fixed a crash when displaying mails with "Show mail as html" was checked in the config.
		14	Added a check before displaying the mail if the mail is in html format, if "Show mail as html" is enabled.
12		15
13	******** VERSION 2.0.11 **********	16	******** VERSION 2.0.11 **********
14		17
15	Fixed some problems in pi-sync mode	18	Fixed some problems in pi-sync mode
16	(e.g. details of events were not synced properly)	19	(e.g. details of events were not synced properly)
17		20
18	******** VERSION 2.0.10 **********	21	******** VERSION 2.0.10 **********
19		22


diff --git a/kmicromail/viewmail.cpp b/kmicromail/viewmail.cpp index 726f540..685b4e4 100644 --- a/kmicromail/viewmail.cpp +++ b/kmicromail/viewmail.cpp
@@ -94,16 +94,28 @@ AttachItem* ViewMail::lastChild(AttachItem*parent)
94	return item;	94	return item;
95	}	95	}
96		96
97	void ViewMail::setBody(const RecBodyP&body )	97	void ViewMail::setBody(const RecBodyP&body )
98	{	98	{
99		99
100	m_body = body;	100	m_body = body;
101	m_mail[2] = body->Bodytext();	101	m_mail[2] = body->Bodytext();
		102	m_showHtml = KOPrefs::instance()->mViewAsHtml;
		103	if ( m_showHtml ) {
		104	if ( m_mail[2].find ("<html>",0,false ) > -1 ) {
		105	qDebug("html mail ");
		106	} else {
		107	qDebug("no html mail ");
		108	m_showHtml = false;
		109	}
		110	}
		111	showHtml->blockSignals( true );
		112	showHtml->setOn( m_showHtml );
		113	showHtml->blockSignals( false );
102	// qDebug("********text %s ",m_mail[2].latin1() );	114	// qDebug("********text %s ",m_mail[2].latin1() );
103	attachbutton->setEnabled(body->Parts().count()>0);	115	attachbutton->setEnabled(body->Parts().count()>0);
104	attachments->setEnabled(body->Parts().count()>0);	116	attachments->setEnabled(body->Parts().count()>0);
105	if (body->Parts().count()==0)	117	if (body->Parts().count()==0)
106	{	118	{
107	return;	119	return;
108	}	120	}
109	AttachItem * curItem=0;	121	AttachItem * curItem=0;
@@ -326,37 +338,44 @@ void ViewMail::setMail(const RecMailP&mail )
326		338
327	m_mail2[0] = mail->To();	339	m_mail2[0] = mail->To();
328	m_mail2[1] = mail->CC();	340	m_mail2[1] = mail->CC();
329	m_mail2[2] = mail->Bcc();	341	m_mail2[2] = mail->Bcc();
330		342
331	setText();	343	setText();
332	}	344	}
333		345
334		346	void ViewMail::slotNextMail()
		347	{
		348	nextMail->blockSignals( true );
		349	setCaption(i18n("Displaying next mail...please wait!"));
		350	qApp->processEvents();
		351	emit showNextMail(this);
		352	nextMail->blockSignals( false );
		353	}
335		354
336	ViewMail::ViewMail( QWidget parent, const char name, WFlags fl)	355	ViewMail::ViewMail( QWidget parent, const char name, WFlags fl)
337	: ViewMailBase(parent, name, fl), _inLoop(false)	356	: ViewMailBase(parent, name, fl), _inLoop(false)
338	{	357	{
339	m_gotBody = false;	358	m_gotBody = false;
340	deleted = false;	359	deleted = false;
341	sourceOn = false;	360	sourceOn = false;
		361	readConfig();
342	connect( reply, SIGNAL(activated()), SLOT(slotReply()));	362	connect( reply, SIGNAL(activated()), SLOT(slotReply()));
343	connect( forward, SIGNAL(activated()), SLOT(slotForward()));	363	connect( forward, SIGNAL(activated()), SLOT(slotForward()));
344	connect( deleteMail, SIGNAL( activated() ), SLOT( slotDeleteMail() ) );	364	connect( deleteMail, SIGNAL( activated() ), SLOT( slotDeleteMail() ) );
345	connect( showHtml, SIGNAL( toggled(bool) ), SLOT( slotShowHtml(bool) ) );	365	connect( showHtml, SIGNAL( toggled(bool) ), SLOT( slotShowHtml(bool) ) );
346	connect( closeMail, SIGNAL( activated() ), SLOT( close() ) );	366	connect( closeMail, SIGNAL( activated() ), SLOT( close() ) );
347	connect( nextMail, SIGNAL( activated() ), SLOT( slotNextMail() ) );	367	connect( nextMail, SIGNAL( activated() ), SLOT( slotNextMail() ) );
348	connect( viewSource, SIGNAL( activated() ), SLOT( slotViewSource() ) );	368	connect( viewSource, SIGNAL( activated() ), SLOT( slotViewSource() ) );
349	connect( downloadMail, SIGNAL( activated() ), SIGNAL( signalDownloadMail() ) );	369	connect( downloadMail, SIGNAL( activated() ), SIGNAL( signalDownloadMail() ) );
350		370
351	attachments->setEnabled(m_gotBody);	371	attachments->setEnabled(m_gotBody);
352	connect( attachments, SIGNAL( clicked(QListViewItem,const QPoint&, int) ), SLOT( slotItemClicked(QListViewItem,const QPoint&, int) ) );	372	connect( attachments, SIGNAL( clicked(QListViewItem,const QPoint&, int) ), SLOT( slotItemClicked(QListViewItem,const QPoint&, int) ) );
353		373
354	readConfig();
355	attachments->setSorting(-1);	374	attachments->setSorting(-1);
356	}	375	}
357		376
358	void ViewMail::readConfig()	377	void ViewMail::readConfig()
359	{	378	{
360		379
361	setFont ( KOPrefs::instance()->mReadFont );	380	setFont ( KOPrefs::instance()->mReadFont );
362	m_showHtml = KOPrefs::instance()->mViewAsHtml;	381	m_showHtml = KOPrefs::instance()->mViewAsHtml;


diff --git a/kmicromail/viewmail.h b/kmicromail/viewmail.h index fc5edcf..bb5b685 100644 --- a/kmicromail/viewmail.h +++ b/kmicromail/viewmail.h
@@ -49,17 +49,17 @@ public:
49	void deleteAndDisplayNextMail(ViewMail *);	49	void deleteAndDisplayNextMail(ViewMail *);
50	void signalDownloadMail();	50	void signalDownloadMail();
51	protected:	51	protected:
52	QString deHtml(const QString &string);	52	QString deHtml(const QString &string);
53	AttachItem* searchParent(const QValueList<int>&path);	53	AttachItem* searchParent(const QValueList<int>&path);
54	AttachItem* lastChild(AttachItem*parent);	54	AttachItem* lastChild(AttachItem*parent);
55		55
56	protected slots:	56	protected slots:
57	void slotNextMail() { setCaption(i18n("Displaying next mail...please wait!")); qApp->processEvents();emit showNextMail(this); };	57	void slotNextMail();
58	void slotReply();	58	void slotReply();
59	void slotForward();	59	void slotForward();
60	void setText();	60	void setText();
61	void slotItemClicked( QListViewItem * item , const QPoint & point, int c );	61	void slotItemClicked( QListViewItem * item , const QPoint & point, int c );
62	void slotDeleteMail( );	62	void slotDeleteMail( );
63	void slotShowHtml( bool );	63	void slotShowHtml( bool );
64	void slotViewSource();	64	void slotViewSource();
65		65