wn view enhancements

7 files changed, 78 insertions, 63 deletions

diff --git a/kalarmd/simplealarmdaemonapplet.cpp b/kalarmd/simplealarmdaemonapplet.cpp
index 7e8125d..94d8428 100644
--- a/kalarmd/simplealarmdaemonapplet.cpp
+++ b/kalarmd/simplealarmdaemonapplet.cpp
@@ -10,16 +10,17 @@ SimpleAlarmDaemonApplet::SimpleAlarmDaemonApplet()
   : mApplet( 0 ), ref( 0 )
 {
   
 }
 
 SimpleAlarmDaemonApplet::~SimpleAlarmDaemonApplet()
 {
   delete mApplet;
+  mApplet = 0;
 }
 
 
 QWidget *SimpleAlarmDaemonApplet::applet( QWidget *parent )
 {
   if ( !mApplet ) {
       mApplet = new SimpleAlarmDaemonImpl( parent );
           if ( QApplication::desktop()->width() < 480 ) 
diff --git a/kalarmd/simplealarmdaemonapplet.h b/kalarmd/simplealarmdaemonapplet.h
index a4cbee4..1787bf3 100644
--- a/kalarmd/simplealarmdaemonapplet.h
+++ b/kalarmd/simplealarmdaemonapplet.h
@@ -1,15 +1,14 @@
 #ifndef SIMPLEALARMDAEMONAPPLET_H
 #define SIMPLEALARMDAEMONAPPLET_H
 
 #include <qpe/taskbarappletinterface.h>
 
 class SimpleAlarmDaemonImpl;
-class ScreenshotApplet;
 
 class SimpleAlarmDaemonApplet : public TaskbarAppletInterface
 {
   public:
     SimpleAlarmDaemonApplet();
     virtual ~SimpleAlarmDaemonApplet();
 
     QRESULT queryInterface( const QUuid&, QUnknownInterface** );
diff --git a/kalarmd/simplealarmdaemonimpl.cpp b/kalarmd/simplealarmdaemonimpl.cpp
index 4ff6861..50c4605 100644
--- a/kalarmd/simplealarmdaemonimpl.cpp
+++ b/kalarmd/simplealarmdaemonimpl.cpp
@@ -43,50 +43,50 @@
 #include <stdio.h>
 #include <unistd.h>
 
 
 SimpleAlarmDaemonImpl::SimpleAlarmDaemonImpl( QWidget *parent )
     : QLabel( parent )
 {
     mAlarmDialog = new AlarmDialog( 0 );
-    mPopUp = new QPopupMenu( 0 );
+    mPopUp = new QPopupMenu( this );
     mPopUp->insertItem( "What's Next?", this, SLOT ( showWN() ) );
     mPopUp->insertItem( "Next Days!", this, SLOT ( showKO() ) );
     mPopUp->insertSeparator();
     mPopUp->insertItem( "What's Todo?", this, SLOT ( showTodo() ) );
     mPopUp->insertSeparator();
     mPopUp->insertItem( "Addresses", this, SLOT ( showAdd() ) );
     mPopUp->insertSeparator();
     mPopUp->insertItem( "Edit Journal", this, SLOT ( writeJournal() ) );
     mPopUp->insertItem( "New Event", this, SLOT ( newEvent() ) );
     mPopUp->insertItem( "New Todo", this, SLOT ( newTodo() ) );
     mPopUp->insertItem( "New Mail", this, SLOT ( newMail() ) );
     mPopUp->insertSeparator();
     mPopUp->insertItem( "Multi Sync", this, SLOT ( ringSync() ) );
-    mTimerPopUp = new QPopupMenu( mPopUp );
+    mTimerPopUp = new QPopupMenu( this );
 
-    mBeepPopUp = new QPopupMenu( mPopUp );   
-    mSoundPopUp = new QPopupMenu( mBeepPopUp );   
-    mPausePopUp = new QPopupMenu( mBeepPopUp );    
-    QPopupMenu* savePopUp = new QPopupMenu( mBeepPopUp ); 
+    mBeepPopUp = new QPopupMenu( this );   
+    mSoundPopUp = new QPopupMenu( this );   
+    mPausePopUp = new QPopupMenu( this );    
+    QPopupMenu* savePopUp = new QPopupMenu( this ); 
     savePopUp->insertItem( "Save", 0 );   
     savePopUp->insertItem( "Load", 1 );   
     mSoundPopUp->insertItem( "Buzzer", 0 );   
     mSoundPopUp->insertItem( "Wav file", 1 ); 
     mPausePopUp->insertItem( " 1 sec", 1 );
     mPausePopUp->insertItem( " 2 sec", 2 );
     mPausePopUp->insertItem( " 3 sec", 3 );
     mPausePopUp->insertItem( " 5 sec", 5 );
     mPausePopUp->insertItem( "10 sec", 10 );
     mPausePopUp->insertItem( "30 sec", 30 );
     mPausePopUp->insertItem( " 1 min", 60 );
     mPausePopUp->insertItem( " 5 min", 300 );
     mPausePopUp->insertItem( "10 min", 600 );
-    mSuspendPopUp = new QPopupMenu( mBeepPopUp );
+    mSuspendPopUp = new QPopupMenu( this );
     mSuspendPopUp->insertItem( "Off", 0 ); 
     mSuspendPopUp->insertItem( " 1x", 1 );   
     mSuspendPopUp->insertItem( " 2x", 2 );   
     mSuspendPopUp->insertItem( " 3x", 3 );  
     mSuspendPopUp->insertItem( " 5x", 5 );  
     mSuspendPopUp->insertItem( "10x", 10 );  
     mSuspendPopUp->insertItem( "20x", 20 );  
     mSuspendPopUp->insertItem( "30x", 30 );    
@@ -137,17 +137,17 @@ SimpleAlarmDaemonImpl::SimpleAlarmDaemonImpl( QWidget *parent )
         wavAlarm = true;
         mSoundPopUp->setItemChecked ( 1, true );
     }
     saveSlot( 1 );
 }
 
 SimpleAlarmDaemonImpl::~SimpleAlarmDaemonImpl()
 {
-    delete mPopUp;
+    //delete mPopUp;
     delete mAlarmDialog;
 }
 void SimpleAlarmDaemonImpl::saveSlot( int load )
 {
     QString fileName = QDir::homeDirPath() +"/.kopialarmrc";
     //qDebug("save %d ", load );
     QFile file( fileName );
     if ( load ) {
@@ -559,17 +559,17 @@ void SimpleAlarmDaemonImpl::newEvent()
 
 }
 void SimpleAlarmDaemonImpl::newMail()
 {
  QCopEnvelope e("QPE/Application/ompi", "newMail()");
 }
 void SimpleAlarmDaemonImpl::showAdd()
 {
- QCopEnvelope e("QPE/Application/kapi", " ");
+ QCopEnvelope e("QPE/Application/kapi", "raise()");
 }
 void SimpleAlarmDaemonImpl::ringSync()
 {
     QCopEnvelope e("QPE/Application/kopi", "-ringSync");
 
 }
 void SimpleAlarmDaemonImpl::newCountdown()
 {
diff --git a/korganizer/koprefs.cpp b/korganizer/koprefs.cpp
index 8dca3ae..1cdb2fb 100644
--- a/korganizer/koprefs.cpp
+++ b/korganizer/koprefs.cpp
@@ -224,17 +224,18 @@ KOPrefs::KOPrefs() :
   addItemBool("Marcus Bains shows seconds",&mMarcusBainsShowSeconds,false);
   addItemBool("Show Marcus Bains",&mMarcusBainsEnabled,true);
   addItemBool("EditOnDoubleClick",&mEditOnDoubleClick,true);
   addItemBool("ViewChangeHoldFullscreen",&mViewChangeHoldFullscreen,false);
   addItemBool("ViewChangeHoldNonFullscreen",&mViewChangeHoldNonFullscreen,false);
   addItemBool("CenterOnCurrentTime",&mCenterOnCurrentTime,false);
   addItemBool("SetTimeToDayStartAt",&mSetTimeToDayStartAt,true);
   addItemBool("HighlightCurrentDay",&mHighlightCurrentDay,true);
-  addItemBool("WNViewShowsParents",&mWNViewShowsParents,true);
+  addItemBool("WNViewShowsParents",&mWNViewShowsParents,true);;
+  addItemBool("WNViewShowsPast",&mWNViewShowsPast,true);
   addItemBool("WNViewShowLocation",&mWNViewShowLocation,false);
   addItemBool("UseHighlightLightColor",&mUseHighlightLightColor,false);
   addItemBool("ListViewMonthTimespan",&mListViewMonthTimespan,true);
   addItemBool("TodoViewUsesCatColors",&mTodoViewUsesCatColors,false);
   addItemBool("TodoViewShowsPercentage",&mTodoViewShowsPercentage,false);
   addItemBool("TodoViewUsesSmallFont",&mTodoViewUsesSmallFont,false);
   addItemBool("TodoViewUsesForegroundColor",&mTodoViewUsesForegroundColor,false);
   addItemBool("MonthViewUsesForegroundColor",&mMonthViewUsesForegroundColor,false);
diff --git a/korganizer/koprefs.h b/korganizer/koprefs.h
index 0656644..f2fe77a 100644
--- a/korganizer/koprefs.h
+++ b/korganizer/koprefs.h
@@ -227,16 +227,17 @@ class KOPrefs : public KPimPrefs
     bool mViewChangeHoldFullscreen;
     bool mViewChangeHoldNonFullscreen;
     bool mCenterOnCurrentTime;
     bool mSetTimeToDayStartAt;
     bool mHighlightCurrentDay;
     bool mUseHighlightLightColor;
     bool mListViewMonthTimespan;
     bool mWNViewShowsParents;
+    bool mWNViewShowsPast;
     bool mWNViewShowLocation;
     bool mTodoViewShowsPercentage;
     bool mTodoViewUsesCatColors;
     bool mTodoViewUsesSmallFont;
     bool mTodoViewUsesForegroundColor;
     bool mMonthViewUsesForegroundColor;
 
     bool mHightlightDateTimeEdit;
diff --git a/korganizer/koprefsdialog.cpp b/korganizer/koprefsdialog.cpp
index 393e6e6..578c0e9 100644
--- a/korganizer/koprefsdialog.cpp
+++ b/korganizer/koprefsdialog.cpp
@@ -779,48 +779,56 @@ void KOPrefsDialog::setupViewsTab()
 
  holidayColor =
       addWidColor(i18n("Day color even months"),
                   &(KOPrefs::instance()->mMonthViewEvenColor),topFrame);
   topLayout->addWidget(holidayColor->label(),ii,0);
   topLayout->addWidget(holidayColor->button(),ii++,1);
 
  
- holidayColor =
+  holidayColor =
       addWidColor(i18n("Color for Sundays + category \"Holiday\""),
                   &(KOPrefs::instance()->mMonthViewHolidayColor),topFrame);
   topLayout->addWidget(holidayColor->label(),ii,0);
   topLayout->addWidget(holidayColor->button(),ii++,1);
   // *********************** What'sNext View
   topFrame = addPage(i18n("What's Next View"),0,0);
   //  DesktopIcon("viewmag",KIcon::SizeMedium));
   
   topLayout = new QGridLayout(topFrame,4,1);
   topLayout->setSpacing(spacingHint());
   topLayout->setMargin(marginHint());
   ii = 0;
-   KPrefsDialogWidBool *passwdk =
-    addWidBool(i18n("Show parent To-Do's in What's Next view"),
-               &(KOPrefs::instance()->mWNViewShowsParents),topFrame);
-   topLayout->addWidget(passwdk->checkBox(), ii++,0);
+  KPrefsDialogWidBool *passwdk =
+
+      addWidBool(i18n("Show events, that are done in \nWhat's Next view"),
+                 &(KOPrefs::instance()->mWNViewShowsPast),topFrame);
+  topLayout->addWidget(passwdk->checkBox(), ii++,0);
+  passwdk =
+      addWidBool(i18n("Show parent To-Do's in What's Next view"),
+                 &(KOPrefs::instance()->mWNViewShowsParents),topFrame);
+  topLayout->addWidget(passwdk->checkBox(), ii++,0);
   
   passwdk =
-    addWidBool(i18n("Show location in What's Next view"),
-               &(KOPrefs::instance()->mWNViewShowLocation),topFrame);
-   topLayout->addWidget(passwdk->checkBox(), ii++,0);
+      addWidBool(i18n("Show location in What's Next view"),
+                 &(KOPrefs::instance()->mWNViewShowLocation),topFrame);
+  topLayout->addWidget(passwdk->checkBox(), ii++,0);
   
   passwdk =
-    addWidBool(i18n("Show Sync Events in \nWhat's Next/Agenda view"),
-               &(KOPrefs::instance()->mShowSyncEvents),topFrame);
-   topLayout->addWidget(passwdk->checkBox(), ii++,0);
-    passwdk =
-           addWidBool(i18n("Use short date in \nWhat's Next/Event view"),
-                      &(KOPrefs::instance()->mShortDateInViewer),topFrame);
-       topLayout->addMultiCellWidget(passwdk->checkBox(), ii,ii,0,1);
+      addWidBool(i18n("Show Sync Events in \nWhat's Next/Agenda view"),
+                 &(KOPrefs::instance()->mShowSyncEvents),topFrame);
+  topLayout->addWidget(passwdk->checkBox(), ii++,0);
+  passwdk =
+      addWidBool(i18n("Use short date in \nWhat's Next/Event view"),
+                 &(KOPrefs::instance()->mShortDateInViewer),topFrame);
+  topLayout->addWidget(passwdk->checkBox(), ii++,0);
    
+
+ 
+
   // *********************** Todo View
 
    topFrame = addPage(i18n("Todo View"),0,0);
     //  DesktopIcon("viewmag",KIcon::SizeMedium));
 
   topLayout = new QGridLayout(topFrame,4,1);
   topLayout->setSpacing(spacingHint());
   topLayout->setMargin(marginHint());
diff --git a/korganizer/kowhatsnextview.cpp b/korganizer/kowhatsnextview.cpp
index 0f0bf11..aa33588 100644
--- a/korganizer/kowhatsnextview.cpp
+++ b/korganizer/kowhatsnextview.cpp
@@ -352,17 +352,17 @@ void KOWhatsNextView::updateView()
     //   qDebug("xxxxxxxxxxxxxxxxxxxxx ");
     //   QWidget* test = new QWidget();
     //  test->setBackgroundMode(FixedPixmap  );
     //  test->setBackgroundPixmap ( bPix );
     //  test->resize( 300, 400 );
     //  test->show();
     //   mView->setBackgroundMode(FixedPixmap  );
     //   mView->setBackgroundPixmap ( bPix );
-    qDebug("%s ",mText.latin1());
+    // qDebug("%s ",mText.latin1());
 }
 
 void  KOWhatsNextView::appendDay( int i, QDate eventDate )
 {
     QString date;
     QString day = KGlobal::locale()->formatDate( eventDate , KOPrefs::instance()->mShortDateInViewer); 
     if ( ! KOPrefs::instance()->mShortDateInViewer && QApplication::desktop()->width() < 320 ) {
         if ( i == 0 ) {
@@ -431,29 +431,30 @@ void KOWhatsNextView::changeEventDisplay(Event *, int action)
 }
 
 void KOWhatsNextView::appendEvent(Incidence *ev, bool reply, bool notRed )
 {
     if ( !KOPrefs::instance()->mShowSyncEvents && ev->uid().left(15) == QString("last-syncEvent-") )
         return;
     QDateTime cdt =  QDateTime::currentDateTime();
     QDateTime noc;
+    QString tempText;
     bool ok = true; 
     if ( reply ) {
         noc = ev->getNextOccurence( cdt, &ok );
         if (! ok && ev->type() == "Event")
             return;
     }
-    mText += "<tr><td><b>";
+    tempText += "<tr><td><b>";
     if (ev->type()=="Event") {
         if (reply)  {
             if (!ev->doesFloat())
-                mText += KGlobal::locale()->formatDateTime( noc , KOPrefs::instance()->mShortDateInViewer) +": ";
+                tempText += KGlobal::locale()->formatDateTime( noc , KOPrefs::instance()->mShortDateInViewer) +": ";
             else
-                mText += KGlobal::locale()->formatDate( noc.date() , KOPrefs::instance()->mShortDateInViewer) +": ";
+                tempText += KGlobal::locale()->formatDate( noc.date() , KOPrefs::instance()->mShortDateInViewer) +": ";
                 
         } else {
             if (!ev->doesFloat()) {
                 Event *event = static_cast<Event *>(ev);
                 QDateTime st,end;
                 if ( event->recurrence()->doesRecur() ) {
                     QDate  recDate= mEventDate;
                     int days =  event->dtStart().date().daysTo (event->dtEnd().date()  );
@@ -476,105 +477,109 @@ void KOWhatsNextView::appendEvent(Incidence *ev, bool reply, bool notRed )
                     dateText = "++:++-";
                 else
                     dateText =  event->dtStartTimeStr() + "-";
                 if ( end.date() > mEventDate ) 
                     dateText += "++:++";
                 else
                     dateText += event->dtEndTimeStr();
                 if ( notRed ) 
-                    mText += dateText;
+                    tempText += dateText;
                 else {
-                    if ( end < cdt  )
-                        mText += "<font color=\"#F00000\">" + dateText + "</font>";
+                    if ( end < cdt  ) {
+                        if ( !KOPrefs::instance()->mWNViewShowsPast )
+                            return;
+                        tempText += "<font color=\"#F00000\">" + dateText + "</font>";
+                    }
                     else if ( st < cdt )
-                        mText += "<font color=\"#008000\">" + dateText + "</font>";
+                        tempText += "<font color=\"#008000\">" + dateText + "</font>";
                     else
-                        mText += dateText;
+                        tempText += dateText;
                 
                 }
     
             } else {
-                mText += i18n("Allday:");
+                tempText += i18n("Allday:");
 
             }
         }
     } else {
         mTodos.append( ev );
-        mText += i18n("ToDo:"); 
+        tempText += i18n("ToDo:"); 
         if (reply)  {
-            mText += " "; 
+            tempText += " "; 
             if ( noc != cdt ) {
-                mText += KGlobal::locale()->formatDate( noc.date() , KOPrefs::instance()->mShortDateInViewer) +": ";
+                tempText += KGlobal::locale()->formatDate( noc.date() , KOPrefs::instance()->mShortDateInViewer) +": ";
             }
         } else {
             if ( ((Todo*)ev)->dtDue().date() < QDate::currentDate() ) {
-                // mText +="<font color=\"#F00000\">" + i18n("O-due!") + "</font>";
+                // tempText +="<font color=\"#F00000\">" + i18n("O-due!") + "</font>";
                 QString dfs = KGlobal::locale()->dateFormatShort();
                 KGlobal::locale()->setDateFormatShort("%d.%b");
-                mText +="<font color=\"#F00000\">" + KGlobal::locale()->formatDate(((Todo*)ev)->dtDue().date(), true, KLocale::Userdefined) + "</font>";
+                tempText +="<font color=\"#F00000\">" + KGlobal::locale()->formatDate(((Todo*)ev)->dtDue().date(), true, KLocale::Userdefined) + "</font>";
                 KGlobal::locale()->setDateFormatShort(dfs);
             } else {
                 if (!ev->doesFloat() )
                     if( ( (Todo*)ev)->dtDue()  < cdt  ) {
-                        mText +="<font color=\"#F00000\">" + ((Todo*)ev)->dtDueTimeStr() + "</font>";
+                        tempText +="<font color=\"#F00000\">" + ((Todo*)ev)->dtDueTimeStr() + "</font>";
 
 
                     } else 
-                        mText +=((Todo*)ev)->dtDueTimeStr();
+                        tempText +=((Todo*)ev)->dtDueTimeStr();
                 mTodos.append( ev );
             }
         }
     }
-    mText += "</b></td><td>";
+    tempText += "</b></td><td>";
     bool needClose = false;
     if ( ev->cancelled() ) {
-        mText += "<font color=\"#F00000\">[c";
+        tempText += "<font color=\"#F00000\">[c";
         needClose =true;
 
     }
     if ( ev->isAlarmEnabled() ) { 
         if ( !needClose)
-            mText +="[";
-        mText += "a";
+            tempText +="[";
+        tempText += "a";
         needClose =true;
 
     }
     if ( ev->description().length() > 0 ) {
         if ( !needClose)
-            mText +="[";
-        mText += "i";
+            tempText +="[";
+        tempText += "i";
         needClose =true;
     }
     if ( ev->recurrence()->doesRecur() ) {
         if ( !needClose)
-            mText +="[";
-        mText += "r";
+            tempText +="[";
+        tempText += "r";
         needClose =true;
     }
     if ( needClose ) {
-        mText += "] ";
+        tempText += "] ";
     }
     if ( ev->cancelled() ) 
-        mText += "</font>";
-    mText += "<a ";
-    if (ev->type()=="Event") mText += "href=\"event:";
-    if (ev->type()=="Todo") mText += "href=\"todo:";
-    mText += ev->uid() + "\">";
+        tempText += "</font>";
+    tempText += "<a ";
+    if (ev->type()=="Event") tempText += "href=\"event:";
+    if (ev->type()=="Todo") tempText += "href=\"todo:";
+    tempText += ev->uid() + "\">";
     if ( ev->summary().length() > 0 )
-        mText += ev->summary();
+        tempText += ev->summary();
     else
-        mText += i18n("-no summary-"); 
-    mText += "</a>";
+        tempText += i18n("-no summary-"); 
+    tempText += "</a>";
     if ( KOPrefs::instance()->mWNViewShowLocation )
         if ( !ev->location().isEmpty() )
-            mText += " ("+ev->location() +")";
+            tempText += " ("+ev->location() +")";
     if ( ev->relatedTo() && KOPrefs::instance()->mWNViewShowsParents)
-            mText += " ["+ev->relatedTo()->summary() +"]";
-    mText += "</td></tr>\n";
+            tempText += " ["+ev->relatedTo()->summary() +"]";
+    tempText += "</td></tr>\n";
+    mText += tempText;
 }
 
 bool KOWhatsNextView::appendTodo(Incidence *ev, QString ind , bool isSub )
 {
     if ( mTodos.find( ev ) != mTodos.end() ) return false;
 
     mTodos.append( ev );
     if ( !isSub )