another fixx

7 files changed, 69 insertions, 20 deletions

diff --git a/bin/kdepim/WhatsNew.txt b/bin/kdepim/WhatsNew.txt
index 14dcdac..9ba4f3e 100644
--- a/bin/kdepim/WhatsNew.txt
+++ b/bin/kdepim/WhatsNew.txt
@@ -14,13 +14,15 @@ Made the week-month mode changing in month view faster.
 
 Made month view better useable with keyboard.
 Now TAB key jumps to next cell with an event/todo.
 Scroll in cell with coursor keys, scroll in time (next week) with
 Shift/Control + coursorkeys.
 
-Fixeg bug that the todo view flat mode was reset after first view update.
+Fixed bug that the todo view flat mode was reset after first view update.
+
+If a todo is displayed closed in the todo view, it is now displayed in overdue/due today color depending on the subtodos overdue/due today properties.
 
 ********** VERSION 2.0.2 ************
 
 KO/Pi:
 Fixed the layout problem of the day label buttons 
 of the agenda view introduced in version 2.0.1.
diff --git a/korganizer/komonthview.cpp b/korganizer/komonthview.cpp
index 31c5659..cb519b2 100644
--- a/korganizer/komonthview.cpp
+++ b/korganizer/komonthview.cpp
@@ -1199,13 +1199,13 @@ void KOMonthView::updateView()
                         }
                     } else {
                         if ( invalid )
                             break;
                         invalid = true;
                         //qDebug("invalid %s", event->summary().latin1());
-                        incidenceStart = QDateTime( mStartDate );
+                        incidenceStart = QDateTime( mStartDate ).addSecs( -2 );;
                     }
                     if ( last )
                         break;
                     bool ok;
                     incidenceStart = event->getNextOccurence( incidenceStart.addSecs( 1 ) ,&ok );
                     if ( ! ok )
diff --git a/korganizer/kotodoviewitem.cpp b/korganizer/kotodoviewitem.cpp
index 6bdee18..78d4027 100644
--- a/korganizer/kotodoviewitem.cpp
+++ b/korganizer/kotodoviewitem.cpp
@@ -325,27 +325,23 @@ void KOTodoViewItem::paintCell(QPainter *p, const QColorGroup &cg, int column, i
       QStringList categories = mTodo->categories();
       QString cat = categories.first();
       if ( !cat.isEmpty()) {
           colorToSet = *(KOPrefs::instance()->categoryColor(cat) );
       } else
           setColor = false;  
-  }
-  if (mTodo->hasDueDate()) {
-    if (mTodo->dtDue().date()==QDate::currentDate() &&
-        !mTodo->isCompleted()) {
-        //_cg.setColor( role , KOPrefs::instance()->mTodoDueTodayColor); 
-        colorToSet = KOPrefs::instance()->mTodoDueTodayColor;     
-        setColor = true;
-    }
-    if (mTodo->dtDue().date() < QDate::currentDate() &&
-        !mTodo->isCompleted()) {
-        //_cg.setColor( role, KOPrefs::instance()->mTodoOverdueColor);
-        colorToSet = KOPrefs::instance()->mTodoOverdueColor;
-        setColor = true;
-    }
-  } 
+   }
+
+   int odue = mTodo->hasDueSubTodo( !isOpen());
+   if (odue == 2) {
+       colorToSet = KOPrefs::instance()->mTodoOverdueColor;
+       setColor = true;
+   } else if ( odue == 1 ) {
+       colorToSet = KOPrefs::instance()->mTodoDueTodayColor;     
+       setColor = true;
+   }
+ 
 
   if ( setColor ) {
       _cg.setColor(role,colorToSet );
       if ( role == QColorGroup::Base) {
           int rgb = colorToSet.red();
           rgb += colorToSet.blue()/2;
diff --git a/korganizer/mainwindow.cpp b/korganizer/mainwindow.cpp
index a2c20a8..5bc8c00 100644
--- a/korganizer/mainwindow.cpp
+++ b/korganizer/mainwindow.cpp
@@ -1343,13 +1343,22 @@ void MainWindow::processIncidenceSelection( Incidence *incidence )
             }
 
         } else {
             if ( incidence->dtStart().time() != incidence->dtEnd().time() )
                 startString = ": "+KGlobal::locale()->formatTime(incidence->dtStart().time())+
                     "-"+KGlobal::locale()->formatTime(incidence->dtEnd().time());
-            startString +=" "+KGlobal::locale()->formatDate( incidence->dtStart().date(), true);
+            if ( incidence->categories().contains( i18n("Birthday") ) || incidence->categories().contains( i18n("Anniversary") )  ) {
+                bool ok;
+                QDateTime noc = incidence->getNextOccurence( mView->startDate().addDays(-1), &ok );
+                if ( ok ) {
+                    int years = noc.date().year() - incidence->dtStart().date().year();
+                    startString += i18n(" (%1 y.)"). arg( years );
+                }
+            }
+            else
+                startString +=" "+KGlobal::locale()->formatDate( incidence->dtStart().date(), true);
         }
 
     }
     else
         startString = i18n(": (Prio ") +QString::number( (( KCal::Todo*)incidence)->priority() ) +") "+QString::number( (( KCal::Todo*)incidence)->percentComplete() ) +i18n("\% completed");
     if ( !incidence->location().isEmpty() )
diff --git a/libkcal/incidence.h b/libkcal/incidence.h
index 1807bc4..de2a381 100644
--- a/libkcal/incidence.h
+++ b/libkcal/incidence.h
@@ -263,24 +263,24 @@ class Incidence : public IncidenceBase
     QDateTime getNextOccurence( const QDateTime& dt, bool* yes ) const;
     bool cancelled() const;
     void setCancelled( bool b );
 
 protected:
     QPtrList<Alarm> mAlarms;
+    QPtrList<Incidence> mRelations;
   private:
     int mRevision;
     bool mCancelled;
 
     // base components of jounal, event and todo
     QDateTime mCreated;
     QString mDescription;
     QString mSummary;
     QStringList mCategories;
     Incidence *mRelatedTo;
     QString mRelatedToUid;
-    QPtrList<Incidence> mRelations;
     DateList mExDates;
     QPtrList<Attachment> mAttachments;
     QStringList mResources;
     bool mHasStartDate;                  // if todo has associated start date
 
     int mSecrecy;
diff --git a/libkcal/todo.cpp b/libkcal/todo.cpp
index 7f1de78..d81a68f 100644
--- a/libkcal/todo.cpp
+++ b/libkcal/todo.cpp
@@ -190,13 +190,43 @@ QString Todo::dtDueDateStr(bool shortfmt) const
 }
 
 QString Todo::dtDueStr(bool shortfmt) const
 {
   return KGlobal::locale()->formatDateTime(mDtDue, shortfmt);
 }
-
+// retval 0 : no found
+//        1 : due for date found
+//        2 : overdue for date found
+int Todo::hasDueSubTodoForDate( const QDate & date, bool checkSubtodos  )
+{
+    int retval = 0;
+    if ( isCompleted() )
+        return 0;
+    if ( hasDueDate() ) {
+        if ( dtDue().date() < date )
+            return 2;
+        // we do not return, because we may find an overdue sub todo
+        if ( dtDue().date() == date )
+            retval = 1;
+    }
+    if ( checkSubtodos ) {
+        Incidence *aTodo;
+        for (aTodo = mRelations.first(); aTodo; aTodo = mRelations.next()) {
+            int ret = ((Todo*)aTodo)->hasDueSubTodoForDate( date ,checkSubtodos );
+            if ( ret == 2 )
+                return 2;
+            if ( ret == 1)
+                retval = 1;
+        }
+    }
+    return retval;
+}
+int Todo::hasDueSubTodo( bool checkSubtodos  ) //= true
+{  
+    return hasDueSubTodoForDate(QDate::currentDate(), checkSubtodos );
+}
 bool Todo::hasDueDate() const
 {
   return mHasDueDate;
 }
 
 void Todo::setHasDueDate(bool f)
diff --git a/libkcal/todo.h b/libkcal/todo.h
index 41f5841..137b252 100644
--- a/libkcal/todo.h
+++ b/libkcal/todo.h
@@ -59,12 +59,24 @@ class Todo : public Incidence
 
     /** returns TRUE or FALSE depending on whether the todo has a due date */
     bool hasDueDate() const;
     /** sets the event's hasDueDate value. */
     void setHasDueDate(bool f);
 
+    /*
+      Looks for a subtodo (including itself ) which is not complete and is
+      - overdue, or
+      - due today.
+      It returns 0 for nothing found,
+      1 for found a todo which is due today and no overdue found
+      2 for found a overdue todo
+    */
+    int hasDueSubTodo( bool checkSubtodos = true );
+    /* same as above, but a specific date can be specified*/
+    int hasDueSubTodoForDate( const  QDate & date, bool checkSubtodos );
+
  
     /** sets the event's status to the string specified.  The string
      * must be a recognized value for the status field, i.e. a string
      * equivalent of the possible status enumerations previously described. */
 //    void setStatus(const QString &statStr);
     /** sets the event's status to the value specified.  See the enumeration