added AB filter settings

5 files changed, 65 insertions, 15 deletions

diff --git a/bin/kdepim/WhatsNew.txt b/bin/kdepim/WhatsNew.txt
index 5d8ef41..d8f8323 100644
--- a/bin/kdepim/WhatsNew.txt
+++ b/bin/kdepim/WhatsNew.txt
@@ -1,279 +1,284 @@
 Info about the changes in new versions of KDE-Pim/Pi
 
 ********** VERSION 1.9.18 ************
 
 FYI: The VERSION 1.9.17 was a testing release only.
 Please read the changelog of VERSION 1.9.17 as well.
 
 Cleaned up the syncing config dialog.
 Added sync config options for date range for events.
 Added sync config options for filters on incoming data.
 Added sync config options for filters on outgoing data.
 Please read the updated SyncHowTo about the new filter settings.
 These filter settings make it now possible to sync with shared
 calendars without writing back private or confidential data
 (via the outgoing filters).
 To sync only with particular parts of a shared calendar, 
 the incoming filter settings can be used.
 An example can be found in the SyncHowTo.
 
 KO/Pi:
 The timeedit input has a pulldown list for times.
 If opened, this pulldown list should now has the right time highlighted.
+Added the possibility to exclude events/todos/journals in a filter.
+You should exclude journals, if you do not want them to sync with a  public calendar.
 
+KA/Pi:
+Added the possibility to in/exclude public/private/confidential contacts to a filter.
+If you have already defined filterrules in KA/Pi you have to adjust them all by setting the "include public/private/confidential" property manually. Sorry for that ...
  
 
 ********** VERSION 1.9.17 ************
 
 KO/Pi:
 Fixed that tooltips were not updated after moving an item in agenda view.
 Fixed a bug in sorting start date for recurring events in list view.
 Changed the left button in todo viewer from "Agenda" to "Set completed".
 This makes it possible to change a todo in the What's Next View quickly to the completed state without leaving the What's Next View.
 Added more info in the todo viewer: Startdate, parent/sub todos.
  
 
 KA/Pi:
 All fields search does now actually search all the (possible) fields, 
 not only those listed in the contact list.
 Made is possible to inline a picture in a vcard on the Z.
 This was only possible on the desktop, now is it possible on the Z as well.
 Fixed of missing save settings after filter configuration.
 Made saving of addressbook much faster.
 Fixed extension widget layout problem.
 Fixed saving of default formatted name settings.
 Fixed formatted name handling in edit dialog.
 Added an option for changing formatted names of many contacts
 (menu: File - Change - Set formatted name).
 
 QWhatsThis was not working on the Z ( only black rectangle was shown).
 This is Fixed.
 
 KDE-Sync:
 Now readonly KDE resources are synced as well.
 (They are not changed in KDE itself, of course).
 
  
 
 ********** VERSION 1.9.16 ************
 
 KO/Pi:
 Fixed search dialog size on Z 6000 (480x640 display).
 Added setting to hide/show time in agenda items.
 Added setting to hide not running todos in todo view.
 Added columns for start date/time in todo view.
 Replaced the solid half-hour lines in agenda view by dot lines.
 Added possibility of printing the What's Next View on the desktop
 (i.e. Windows and Linux).
 Fixed a crash in KO/Pi when starting KO/Pi with What's Next view.
 Added tooltips in month view.(Tooltips only available on desktop)
 
 Fixed a strange problem in KO/Pi alarm applet.
 Did not find the actual problem, 
 such that now Qtopia reboots again if deinstalling the alarm applet.
 But the alarm applet should work again.
 
 KA/Pi:
 Fixed the problem, that internal pictures were not saved.
 
 Fixed a problem in the pi-sync mode by increasing the timeout for data transfer from 20 seconds to 5 minutes.
 
 Fixed some minor problems. (Like word wrap in help text windows).
 
 Fixed a compiling problem in microkde/kresources.
 
 KO/Pi is using zdbat (renamed to db2file) for syncing with Sharp DTM.
 This version now includes zdbat 1.0.0 (old version was zdbat 0.2.9)
 such that now syncing KO/Pi with Sharp DTM should work on the 
 Zaurus C 3000 model.
 
 ********** VERSION 1.9.15 ************
 
 Usebilty enhancements in KO/Pi:
 When clicking on the date in a month view cell, the day view is shown.
 Old behaviour was, that the "new event" dialog popped up.
 
 Added a one step "undo delete" in KO/Pi (Accessable in the "Action" menu). 
 That means, you can restore the latest
 event/todo/journal you have deleted.
 A journal is deleted, if you clear all the text of the journal.
 
 Fixed the bug of the editor dialogs in KO/Pi of version 1.9.14.
 
 KA/Pi  starting in 480x640 resolution:
 Hide the filter action in toolbar
 and added icons for undo/delete/redo in toolbar.
 
 Change in OM/Pi ViewMail dialog:
 When clicking on the "delete" icon the mail is deleted after confirmation as usual. 
 But the edit dialog is not closed as before, now the next mail in the folder is shown automatically (if there is any).
 
 Fixed a crash when deleting mail-accounts in OM/Pi.
 
 
 ********** VERSION 1.9.14 ************
 
 Fixed some problems with the dialog sizes when switching 
 portrait/landscape mode on 640x480 PDA display.
 
 Fixed some other small bugs in KA/Pi KO/Pi and OM/Pi and PwM/Pi.
 
 Fixed an ugly bug in KOpieMail: 
 KOpieMail was not able to write files (mails) to MSDOS file system, 
 like on an usual preformatted SD card. That should work now.
 To save your mail data on the Sd card do the following:
 Create a dir on the SD card:
 mkdir /mnt/card/localmail
 Go to your home dir:
 cd
 Go to kopiemail data storage dir:
 cd kdepim/apps/kopiemail
 Create a symlink to the SD card:
 ls -s /mnt/card/localmail
 Now KOpieMail will store all mails on the SD card.
 
 KO/Pi Monthview:
 Now "Go to Today" selects the current month from day 1-end,
 not the current date + some days.
 I.e. "Go to Today" shows now always
 the current month with first day of month in the first row. 
 
 Added missing German translation.
 
 Fixed icons of executeable on Wintendo.
 
 Added a "Show next Mail" button to the OM/Pi 
 mail viewer such that the mail below the current mail
 in the mail list view of the current folder
 can be read with a single click.
 
 
 ********** VERSION 1.9.13 ************
 
 Fixed nasty PwM/Pi file reading bug, when
 the used hash algo of file is different then the global 
 hash algo.
 
 Added KA/Pi support for opie mailit mailapplication.
 
 Fixed some bugs in OM/Pi.
 Now character conversion tables are available for the Zaurus
 to make OM/Pi working properly.
 To get the character conversion in OM/Pi working, please download
 at the sourceforge project site the package
 sr-character-conversion_SharpROM_arm.ipk.zip
 (or oz-character-conversion_OZ-gcc3xx_arm.ipk.zip for OZ roms)
 from the section "general files for KDE/Pim"
 Instructions how to install this package are in a ReadMe in this file.
 
 
 Fixed the orientation change problem in KA/Pi when switching
 portrait/landscape mode.
 
 French translation available for KA/Pi and OM/Pi.
 
 Fixed some problems with categories in KO/Pi in DTM sync.
 
 Added selection dialog for export to phone in KA/Pi.
 
 If in KO/Pi is an attendee selected to add to a meeting and this
 attendee is already in the list of attendees, this person is not added
 again.
 
 Some menu cleanup in KA/Pi.
 
 ********** VERSION 1.9.12 ************
 
 Fix for the bug in KO/Pi What's Next view of version 1.9.11.
 
 Bugfix: Licence file is now shown again.
 
 OM/Pi now supports Unicode (utf8 charset).
 Fixed some bugs in OM/Pi.
 
 KA/Pi has more German translation.
 
 
 ********** VERSION 1.9.11 ************
 
 Fixed several problems in PWM/Pi, like
 asking the user, if unsaved changed are pending
 when closing the app.
 And PwM/Pi handles now different texts for the
 fields Description, Username, Password, configurable per category.
 
 Fixed a crash in KO/Pi , when importing/loading vcs files
 which have an entry with an attendee with state:
 NEEDS ACTION
 
 Fixed some problems in the German translation of OM/Pi,
 which makes some dialogs not fitting on the screen
 of the Z 5500.
 
 Fixed Qtopia crash, when disabling/deinstalling
 KO/Pi alarm applet.
 
 Implemented direct KDE<->KA/Pi sync for KA/Pi running 
 on Linux desktop.
 
 Added feature "remove sync info" to sync menu.
 
 Tweaked the KO/Pi What's next view a bit, added
 setting to hide events that are done.
 
 Disabled "beam receive enabled" on startup to 
 avoid problems if Fastload is enabled.
 Please set "beam receive enabled",
 if you want to receive data via IR.
 
 Fixed bug in  direct KDE<->KO/Pi sync for KO/Pi running 
 on Linux desktop.
 
 Made in KA/Pi scrolling possible, if details view is selected.
 (The keyboard focus is set automatically to the search line)
 
 Fixed a bug in DMT sync, that a new entry in DTM was added 
 on every sync to Kx/Pi.
 
 Fixed missing writing of KA/Pi categories to DMT entries when syncing.
 
 Fixed a bug in DMT sync with todos created in KO/Pi containing
 non-latin1 characters.
 
 Rearranged package contents of Sharp-ipks and made all
 packages installable on SD again.
 
 Fixed the writing of addressbook data in DTM sync.
 Empty fields in KA/Pi were not removed. 
 
 Added better category handling in KA/Pi:
 Added item 
 Edit Categories and
 Manage new categories
 to the settings menu.
 Possible to configure a view to display categories.
 
 Added detailed "KDE Sync Howto" and "Multi Sync Howto" to Help menu.
 
 Fixed displaying of "free" days and time in KO Monthview and Agendaview.
 
 ... and many other bugfixes.
 
 ********** VERSION 1.9.10 ************
 
 Many internal small bugfixes.
 And fix of the "big" bug in KO/Pi, 
 that after Syncing the appointments had an offset by several hours.
 That was a problem with the internal timezone setting,
 introduced by the changed timezone configuration settings.
 
 German translation for OM/Pi is now available.
 
 
 ********** VERSION 1.9.9 ************
 
 KDE-Pim/Pi has a new Member!
 It is called PWM/Pi (Passwordmanager/platform-independent) 
 and it is available for the Zaurus.
 It is planned, that it will be available later for Windows.
 (And for Linux, of course).
diff --git a/kaddressbook/filter.cpp b/kaddressbook/filter.cpp
index 39d2ae4..9cb4c2d 100644
--- a/kaddressbook/filter.cpp
+++ b/kaddressbook/filter.cpp
@@ -1,206 +1,228 @@
 /*                                                                      
     This file is part of KAddressBook.                                  
     Copyright (c) 2002 Mike Pilone <mpilone@slac.com>                   
                                                                         
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or   
     (at your option) any later version.                                 
                                                                         
     This program is distributed in the hope that it will be useful,     
     but WITHOUT ANY WARRANTY; without even the implied warranty of      
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the        
     GNU General Public License for more details.                        
                                                                         
     You should have received a copy of the GNU General Public License   
     along with this program; if not, write to the Free Software         
     Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.           
                                                                         
     As a special exception, permission is given to link this program    
     with any edition of Qt, and distribute the resulting executable,    
     without including the source code for Qt in the source distribution.
 */                                                                      
 
 #include <kconfig.h>
 #include <kconfigbase.h>
 #include <kdebug.h>
 
 #include "kabprefs.h"
 
 #include "filter.h"
+#include <secrecy.h>
 
 Filter::Filter()
   : mName( QString::null ), mMatchRule( Matching ), mEnabled( true ),
     mInternal( false )
 {
+    mCriteria = ShowPublic | ShowPrivate| ShowConfidential ;
 }
 
 Filter::Filter( const QString &name )
   : mName( name ), mMatchRule( Matching ), mEnabled( true ),
     mInternal( false )
 {
+    mCriteria = ShowPublic | ShowPrivate| ShowConfidential ;
 }
 
 Filter::~Filter()
 {
 }
 
 void Filter::setName( const QString &name )
 {
   mName = name;
 }
 
 const QString &Filter::name() const
 {
   return mName;
 }
 
 bool Filter::isInternal() const
 {
   return mInternal;
 }
 
 void Filter::apply( KABC::Addressee::List &addresseeList )
 {
   KABC::Addressee::List::Iterator iter;
   for ( iter = addresseeList.begin(); iter != addresseeList.end(); ) {
     if ( filterAddressee( *iter ) )
       ++iter;
     else
     {
 #ifndef KAB_EMBEDDED
       iter = addresseeList.erase( iter );
 #else //KAB_EMBEDDED
       iter = addresseeList.remove( iter );
 #endif //KAB_EMBEDDED
     }
   }
 }
 
 bool Filter::filterAddressee( const KABC::Addressee &a )
 {
+    switch ( a.secrecy().type()) {
+    case KABC::Secrecy::Public: 
+        if (! (mCriteria & ShowPublic ))
+            return false;
+        break;
+    case KABC::Secrecy::Private:
+        if (! (mCriteria & ShowPrivate ))
+            return false;
+        break;
+    case KABC::Secrecy::Confidential:
+        if (! (mCriteria & ShowConfidential ))
+            return false;
+        break;
+    default:
+        return false;
+        break;
+    }
   QStringList::Iterator iter;
   iter = mCategoryList.begin();
   // empty filter always matches
 
   if ( iter == mCategoryList.end() )
     return true;
 
   for ( ; iter != mCategoryList.end(); ++iter ) {
     if ( a.hasCategory( *iter ) )
       return ( mMatchRule == Matching );
   }
   
   return !( mMatchRule == Matching );
 }
 
 void Filter::setEnabled( bool on )
 {
   mEnabled = on;
 }
 
 bool Filter::isEnabled() const
 {
   return mEnabled;
 }
 
 void Filter::setCategories( const QStringList &list )
 {
   mCategoryList = list;
 }
     
 const QStringList &Filter::categories() const
 {
   return mCategoryList;
 }
 
 void Filter::save( KConfig *config )
 {
   config->writeEntry( "Name", mName );
   config->writeEntry( "Enabled", mEnabled );
   config->writeEntry( "Categories", mCategoryList );
   config->writeEntry( "MatchRule", (int)mMatchRule );
+  config->writeEntry( "Criteria", (int)mCriteria );
 }
 
 void Filter::restore( KConfig *config )
 {
   mName = config->readEntry( "Name", "<internal error>" );
   mEnabled = config->readBoolEntry( "Enabled", true );
   mCategoryList = config->readListEntry( "Categories" );
   mMatchRule = (MatchRule)config->readNumEntry( "MatchRule", Matching );
+  mCriteria = config->readNumEntry( "Criteria", (ShowPublic | ShowPrivate| ShowConfidential) );
 }
 
 void Filter::save( KConfig *config, QString baseGroup, Filter::List &list )
 {
   {
     KConfigGroupSaver s( config, baseGroup );
 
     // remove the old filters
     uint count = config->readNumEntry( "Count" );
     /*   // memory access violation here
     for ( uint i = 0; i < count; ++i )
       config->deleteGroup( QString( "%1_%2" ).arg( baseGroup ).arg( i ) );
     */
   }
   
   int index = 0;
   Filter::List::Iterator iter;
   for ( iter = list.begin(); iter != list.end(); ++iter ) {
     if ( !(*iter).mInternal ) {
       KConfigGroupSaver s( config, QString( "%1_%2" ).arg( baseGroup ).arg( index ) );
                                                      
       (*iter).save( config );
       index++;
     }
   }
 
   KConfigGroupSaver s( config, baseGroup );
 
   config->writeEntry( "Count", index );
 
 }
                      
 Filter::List Filter::restore( KConfig *config, QString baseGroup )
 {
   Filter::List list;
   int count = 0;
   Filter f;
   
   {
     KConfigGroupSaver s( config, baseGroup );
     count = config->readNumEntry( "Count", 0 );
   }
   
   for ( int i = 0; i < count; i++ ) {
     {
       KConfigGroupSaver s( config, QString( "%1_%2" ).arg( baseGroup ).arg( i ) );
       f.restore( config );
     }
 
     list.append( f );
   }
 
   if ( list.isEmpty()) {
       QStringList cats = KABPrefs::instance()->mCustomCategories;
       for ( QStringList::Iterator it = cats.begin(); it != cats.end(); ++it ) {
           Filter filter;
           filter.mName = *it;
           filter.mEnabled = true;
           filter.mCategoryList = *it;
           filter.mMatchRule = Matching;
           filter.mInternal = true;
           list.append( filter );
       }
   }
   return list;
 }
 
 void Filter::setMatchRule( MatchRule rule )
 {
   mMatchRule = rule;
 }
     
 Filter::MatchRule Filter::matchRule() const
 {
   return mMatchRule;
 }
diff --git a/kaddressbook/filter.h b/kaddressbook/filter.h
index cf2c0a1..26870d7 100644
--- a/kaddressbook/filter.h
+++ b/kaddressbook/filter.h
@@ -1,153 +1,157 @@
 /*                                                                      
     This file is part of KAddressBook.                                  
     Copyright (c) 2002 Mike Pilone <mpilone@slac.com>                   
                                                                         
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or   
     (at your option) any later version.                                 
                                                                         
     This program is distributed in the hope that it will be useful,     
     but WITHOUT ANY WARRANTY; without even the implied warranty of      
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the        
     GNU General Public License for more details.                        
                                                                         
     You should have received a copy of the GNU General Public License   
     along with this program; if not, write to the Free Software         
     Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.           
                                                                         
     As a special exception, permission is given to link this program    
     with any edition of Qt, and distribute the resulting executable,    
     without including the source code for Qt in the source distribution.
 */                                                                      
 
 #ifndef FILTER_H
 #define FILTER_H
 
 #include <qstring.h>
 #include <qstringlist.h>
 #include <qvaluelist.h>
 
 #include <kabc/addressee.h>
 #include <kconfig.h>
 
 /**
   Filter for AddressBook related objects (Addressees)
 
   @todo This class should be switched to use shared data.
  */
 class Filter
 {
-  public:
+  public: 
+    enum { ShowPublic = 1, ShowPrivate = 2, ShowConfidential = 4};
+     void setCriteria(int c) { mCriteria = c ;}
+    int criteria() const { return mCriteria;}
     typedef QValueList<Filter> List;
     
     enum MatchRule { Matching = 0, NotMatching = 1 };
 
     Filter();
     Filter( const QString& name );
     ~Filter();
 
     /**
       Set the name of the filter.
      */
     void setName( const QString &name );
 
     /**
       @return The name of the filter.
      */
     const QString &name() const;
 
     /**
       @return Whether the filter is an internal one.
      */
     bool isInternal() const;
     
     /**
       Apply the filter to the addressee list. All addressees not passing
       the filter criterias will be removed from the list.
     
       If the MatchRule is NotMatch, then all the addressees matching the
       filter will be removed from the list.
      */
     void apply( KABC::Addressee::List &addresseeList );
     
     /**
       Apply the filter to the addressee.
      
       @return True if the addressee passes the criteria, false otherwise.
       The return values are opposite if the MatchRule is NotMatch.
      */
     bool filterAddressee( const KABC::Addressee &a );
     
     /**
       Enable or disable the filter
      */
     void setEnabled( bool on );
     
     /**
       @return True if this filter is enabled, false otherwise.
      */
     bool isEnabled() const;
     
     /**
       Set the list of categories. This list is used to filter addressees.
      */
     void setCategories( const QStringList &list );
     
     /**
       @return The list of categories.
      */
     const QStringList &categories() const;
     
     /**
       Saves the filter to the config file. The group should already be set.
      */
     void save( KConfig *config );
     
     /**
       Loads the filter from the config file. The group should already be set.
      */
     void restore( KConfig *config );
     
     /**
       Saves a list of filters to the config file.
     
       @param config The config file to use
       @param baseGroup The base groupname to use. The number of filters
                        will be written to this group, then a _1, _2, etc
                        will be append for each filter saved.
       @param list The list of filters to be saved.
      */
     static void save( KConfig *config, QString baseGroup, Filter::List &list );
     
     /**
       Restores a list of filters from a config file.
     
       @param config The config file to read from.
       @param baseGroup The base group name to be used to find the filters
       
       @return The list of filters.
      */
     static Filter::List restore( KConfig *config, QString baseGroup );
     
     /**
       Sets the filter rule. If the rule is Filter::Matching (default),
       then the filter will return true on items that match the filter.
       If the rule is Filter::NotMatching, then the filter will return
       true on items that do not match the filter.
      */
     void setMatchRule( MatchRule rule );
     
     /** @return The current match rule.
     */
     MatchRule matchRule() const;
    
   private:
+    int mCriteria;
     QString mName;
     QStringList mCategoryList;
     MatchRule mMatchRule;
     bool mEnabled;
     bool mInternal;
 };
 
 #endif
diff --git a/kaddressbook/filtereditdialog.cpp b/kaddressbook/filtereditdialog.cpp
index 063585a..987f234 100644
--- a/kaddressbook/filtereditdialog.cpp
+++ b/kaddressbook/filtereditdialog.cpp
@@ -1,302 +1,316 @@
 /*
     This file is part of KAddressBook.
     Copyright (c) 2002 Mike Pilone <mpilone@slac.com>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
     As a special exception, permission is given to link this program
     with any edition of Qt, and distribute the resulting executable,
     without including the source code for Qt in the source distribution.
 */
 
 /*
 Enhanced Version of the file for platform independent KDE tools.
 Copyright (c) 2004 Ulf Schenk
 
 $Id$
 */
 
 #include <qbuttongroup.h>
 #include <qhbox.h>
 #include <qlabel.h>
 #include <qlayout.h>
 #include <qpushbutton.h>
 #include <qradiobutton.h>
+#include <qcheckbox.h>
 #include <qregexp.h>
 #include <qstring.h>
 #include <qtoolbutton.h>
 #include <qtooltip.h>
 #include <qwidget.h>
 
 #include <kapplication.h>
 #include <kbuttonbox.h>
 #include <kdebug.h>
 #include <kiconloader.h>
 #include <klineedit.h>
 #include <klistbox.h>
 #include <klistview.h>
 #include <klocale.h>
 #include <kglobal.h>
 
 #include "kabprefs.h"
 #include "filtereditdialog.h"
 
 FilterEditDialog::FilterEditDialog( QWidget *parent, const char *name )
   : KDialogBase( Plain, i18n( "Edit Address Book Filter" ),
                  Help | Ok | Cancel, Ok, parent, name, /*US false*/ true, true )
 {
   initGUI();
 
   QStringList cats = KABPrefs::instance()->mCustomCategories;
 
   QStringList::Iterator iter;
   for ( iter = cats.begin(); iter != cats.end(); ++iter )
     mCategoriesView->insertItem( new QCheckListItem( mCategoriesView, (*iter), QCheckListItem::CheckBox ) );
   filterNameTextChanged( mNameEdit->text() );
 }
 
 FilterEditDialog::~FilterEditDialog()
 {
 }
 
 void FilterEditDialog::setFilter( const Filter &filter )
 {
   mNameEdit->setText( filter.name() );
 
   QStringList categories = filter.categories();
   QListViewItem *item = mCategoriesView->firstChild();
   while ( item != 0 ) {
     if ( categories.contains( item->text( 0 ) ) ) {
       QCheckListItem *checkItem = static_cast<QCheckListItem*>( item );
       checkItem->setOn( true );
     }
 
     item = item->nextSibling();
   }
 
   if ( filter.matchRule() == Filter::Matching )
     mMatchRuleGroup->setButton( 0 );
   else
     mMatchRuleGroup->setButton( 1 );
+
+  int c = filter.criteria() ;
+  mPublic->setChecked(c &Filter::ShowPublic);
+  mPrivate->setChecked(c & Filter::ShowPrivate);
+  mConfidential->setChecked(c & Filter::ShowConfidential);
+
 }
 
 Filter FilterEditDialog::filter()
 {
   Filter filter;
 
   filter.setName( mNameEdit->text() );
 
   QStringList categories;
   QListViewItem *item = mCategoriesView->firstChild();
   while ( item != 0 ) {
     QCheckListItem *checkItem = static_cast<QCheckListItem*>( item );
     if ( checkItem->isOn() )
       categories.append( item->text( 0 ) );
 
     item = item->nextSibling();
   }
   filter.setCategories( categories );
 
   if ( mMatchRuleGroup->find( 0 )->isOn() )
     filter.setMatchRule( Filter::Matching );
   else
     filter.setMatchRule( Filter::NotMatching );
 
+  int c = 0;
+  if (mPublic->isChecked()) c |= Filter::ShowPublic;
+  if (mPrivate->isChecked()) c |= Filter::ShowPrivate;
+  if (mConfidential->isChecked()) c |= Filter::ShowConfidential;
+  filter.setCriteria( c ) ;
+
   return filter;
 }
 
 void FilterEditDialog::initGUI()
 {
 #ifndef KAB_EMBEDDED  
   resize( 490, 300 );
 #else //KAB_EMBEDDED  
   resize( KMIN(KGlobal::getDesktopWidth()-10, 490), KMIN(KGlobal::getDesktopHeight()-50, 300));
 #endif //KAB_EMBEDDED  
   
 
   QWidget *page = plainPage();
   QLabel *label;
 
   QGridLayout *topLayout = new QGridLayout( page, 3, 2, 0, spacingHint() );
 
   label = new QLabel( i18n( "Name" ), page );
   mNameEdit = new KLineEdit( page );
   mNameEdit->setFocus();
   topLayout->addWidget( label, 0, 0 );
   topLayout->addWidget( mNameEdit, 0, 1 );
   connect( mNameEdit, SIGNAL( textChanged( const QString& ) ),
            SLOT( filterNameTextChanged( const QString&) ) );
 
   mCategoriesView = new KListView( page );
   mCategoriesView->addColumn( i18n( "Categories" ) );
   topLayout->addMultiCellWidget( mCategoriesView, 1, 1, 0, 1 );
 
-  mMatchRuleGroup = new QButtonGroup( page );
+  mMatchRuleGroup = new QHButtonGroup( i18n( "Category rule" ), page );
   mMatchRuleGroup->setExclusive( true );
-
-  QBoxLayout *gbLayout = new QVBoxLayout( mMatchRuleGroup );
-  gbLayout->setSpacing( KDialog::spacingHint() );
-  gbLayout->setMargin( KDialog::marginHint() );
-
-  QRadioButton *radio = new QRadioButton( i18n( "Show only contacts matching\n the selected categories" ), mMatchRuleGroup );
+  QRadioButton *radio = new QRadioButton( i18n( "Include categories" ), mMatchRuleGroup );
   radio->setChecked( true );
-  mMatchRuleGroup->insert( radio );
-  gbLayout->addWidget( radio );
+  //mMatchRuleGroup->insert( radio );
+  radio = new QRadioButton( i18n( "Exclude categories" ), mMatchRuleGroup );
+  //mMatchRuleGroup->insert( radio );
+  topLayout->addMultiCellWidget( mMatchRuleGroup, 2, 2, 0, 1 );
 
-  radio = new QRadioButton( i18n( "Show all contacts except those\n matching the selected categories" ), mMatchRuleGroup );
-  mMatchRuleGroup->insert( radio );
-  gbLayout->addWidget( radio );
+  QHButtonGroup * mMatchPPCGroup = new QHButtonGroup(i18n( "Include contacts, that are:" ), page );
+  mPublic = new QCheckBox( i18n( "public" ), mMatchPPCGroup );
+  mPrivate = new QCheckBox( i18n( "private" ), mMatchPPCGroup );
+  mConfidential = new QCheckBox( i18n( "confidential" ), mMatchPPCGroup );
+  mPublic->setChecked( true );
+  mPrivate->setChecked( true );
+  mConfidential->setChecked( true );
+  topLayout->addMultiCellWidget( mMatchPPCGroup, 3, 3, 0, 1 );
 
-  topLayout->addMultiCellWidget( mMatchRuleGroup, 2, 2, 0, 1 );
 }
 
 void FilterEditDialog::filterNameTextChanged( const QString &text )
 {
   enableButtonOK( !text.isEmpty() );
 }
 
 void FilterEditDialog::slotHelp()
 {
 #ifndef KAB_EMBEDDED
   kapp->invokeHelp( "using-filters" );
 #endif //KAB_EMBEDDED
 }
 
 FilterDialog::FilterDialog( QWidget *parent, const char *name )
   : KDialogBase( Plain, i18n( "Edit Address Book Filters" ),
                  Ok | Cancel, Ok, parent, name, /*US false*/true, true )
 {
   initGUI();
 }
 
 FilterDialog::~FilterDialog()
 {
 }
 
 void FilterDialog::setFilters( const Filter::List &list )
 {
   mFilterList.clear();
   mInternalFilterList.clear();
 
   Filter::List::ConstIterator it;
   for ( it = list.begin(); it != list.end(); ++it ) {
     if ( (*it).isInternal() )
       mInternalFilterList.append( *it );
     else
       mFilterList.append( *it );
   }
 
   refresh();
 }
 
 Filter::List FilterDialog::filters() const
 {
   Filter::List list = mFilterList + mInternalFilterList;
   return list;
 }
 
 void FilterDialog::add()
 {
 #ifndef KAB_EMBEDDED  
   FilterEditDialog dlg( this );
 #else //KAB_EMBEDDED  
   FilterEditDialog dlg( this->parentWidget() );
 #endif //KAB_EMBEDDED  
 
   if ( dlg.exec() )
     mFilterList.append( dlg.filter() );
 
   refresh();
 
   mFilterListBox->setCurrentItem( mFilterListBox->count() - 1 );
 }
 
 void FilterDialog::edit()
 {
   FilterEditDialog dlg( this );
 
   uint pos = mFilterListBox->currentItem();
 
   dlg.setFilter( mFilterList[ pos ] );
 
   if ( dlg.exec() ) {
     mFilterList.remove( mFilterList.at( pos ) );
     mFilterList.insert( mFilterList.at( pos ), dlg.filter() );
   }
 
   refresh();
 
   mFilterListBox->setCurrentItem( pos );
 }
 
 void FilterDialog::remove()
 {
   mFilterList.remove( mFilterList.at( mFilterListBox->currentItem() ) );
 
   selectionChanged( 0 );
 
   refresh();
 }
 
 void FilterDialog::refresh()
 {
   mFilterListBox->clear();
 
   Filter::List::Iterator iter;
   for ( iter = mFilterList.begin(); iter != mFilterList.end(); ++iter )
     mFilterListBox->insertItem( (*iter).name() );
 }
 
 void FilterDialog::selectionChanged( QListBoxItem *item )
 {
   bool state = ( item != 0 );
 
   mEditButton->setEnabled( state );
   mRemoveButton->setEnabled( state );
 }
 
 void FilterDialog::initGUI()
 {
 #ifndef KAB_EMBEDDED  
   resize( 330, 200 );
 #else //KAB_EMBEDDED  
   resize( KMIN(KGlobal::getDesktopWidth()-10, 330), KMIN(KGlobal::getDesktopHeight()-50, 200));
 #endif //KAB_EMBEDDED  
 
   QWidget *page = plainPage();
 
   QGridLayout *topLayout = new QGridLayout( page, 1, 2, 0, spacingHint() );
 
   mFilterListBox = new KListBox( page );
   topLayout->addWidget( mFilterListBox, 0, 0 );
   connect( mFilterListBox, SIGNAL( selectionChanged( QListBoxItem * ) ),
            SLOT( selectionChanged( QListBoxItem * ) ) );
   connect( mFilterListBox, SIGNAL( doubleClicked ( QListBoxItem * ) ),
            SLOT( edit() ) );
 
   KButtonBox *buttonBox = new KButtonBox( page, Vertical );
   buttonBox->addButton( i18n( "&Add..." ), this, SLOT( add() ) );
   mEditButton = buttonBox->addButton( i18n( "&Edit..." ), this, SLOT( edit() ) );
   mEditButton->setEnabled( false );
   mRemoveButton = buttonBox->addButton( i18n( "&Remove" ), this, SLOT( remove() ) );
   mRemoveButton->setEnabled( false );
 
   buttonBox->layout();
   topLayout->addWidget( buttonBox, 0, 1 );
 }
 
 #ifndef KAB_EMBEDDED
 #include "filtereditdialog.moc"
 #endif //KAB_EMBEDDED
diff --git a/kaddressbook/filtereditdialog.h b/kaddressbook/filtereditdialog.h
index 4dd75e4..5a8bad1 100644
--- a/kaddressbook/filtereditdialog.h
+++ b/kaddressbook/filtereditdialog.h
@@ -1,104 +1,109 @@
 /*
     This file is part of KAddressBook.
     Copyright (c) 2002 Mike Pilone <mpilone@slac.com>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 
     As a special exception, permission is given to link this program
     with any edition of Qt, and distribute the resulting executable,
     without including the source code for Qt in the source distribution.
 */
 
 /*
 Enhanced Version of the file for platform independent KDE tools.
 Copyright (c) 2004 Ulf Schenk
 
 $Id$
 */
 
 #ifndef FILTEREDITDIALOG_H
 #define FILTEREDITDIALOG_H
 
 class QButtonGroup;
 class QString;
 class QToolButton;
 class QWidget;
 class QListBoxItem;
+class QCheckBox;
 
 class KLineEdit;
 class KListBox;
 class KListView;
 
 #include <kdialogbase.h>
+#include <qhbuttongroup.h>
 
 #include "filter.h"
 
 class FilterDialog : public KDialogBase
 {
   Q_OBJECT
 
   public:
     FilterDialog( QWidget *parent, const char *name = 0 );
     ~FilterDialog();
 
     void setFilters( const Filter::List &list );
     Filter::List filters() const;
 
   protected slots:
     void add();
     void edit();
     void remove();
     void selectionChanged( QListBoxItem* );
 
   private:
     void initGUI();
     void refresh();
 
     Filter::List mFilterList;
     Filter::List mInternalFilterList;
 
     KListBox *mFilterListBox;
     QPushButton *mAddButton;
     QPushButton *mEditButton;
     QPushButton *mRemoveButton;
 };
 
 class FilterEditDialog : public KDialogBase
 {
     Q_OBJECT
   public:
     FilterEditDialog( QWidget *parent, const char *name = 0 );
     ~FilterEditDialog();
 
     void setFilter( const Filter &filter );
     Filter filter();
 
   protected slots:
     void filterNameTextChanged( const QString& );
     void slotHelp();
 
   private:
     void initGUI();
 
     Filter mFilter;
 
     KLineEdit *mNameEdit;
     KListView *mCategoriesView;
-    QButtonGroup *mMatchRuleGroup;
+    QHButtonGroup *mMatchRuleGroup;
+    QCheckBox *mPrivate;
+    QCheckBox *mPublic;
+    QCheckBox *mConfidential;
     QPushButton *mEditButton;
     QPushButton *mRemoveButton;
 };
 
 #endif