commit

2 files changed, 31 insertions, 24 deletions

diff --git a/kaddressbook/phoneeditwidget.cpp b/kaddressbook/phoneeditwidget.cpp
index b20275d..997fc05 100644
--- a/kaddressbook/phoneeditwidget.cpp
+++ b/kaddressbook/phoneeditwidget.cpp
@@ -76,8 +76,6 @@ PhoneEditWidget::PhoneEditWidget( QWidget *parent, const char *name )
     temp->setPixmap( KGlobal::iconLoader()->loadIcon( "kaddressbook", KIcon::Desktop, 0 ) );
     hbLayout->add( temp );
-    appendEditCombo();
-    appendEditCombo();
-    appendEditCombo();
     setDefaults();
+    mTypeNumberEditList.setAutoDelete( true );
 }
 
@@ -87,19 +85,16 @@ PhoneEditWidget::~PhoneEditWidget()
 void  PhoneEditWidget::setDefaults()
 {
-    PhoneTypeNumberEdit* edit = mTypeNumberEditList.first();
+    mTypeNumberEditList.clear();
+    PhoneTypeNumberEdit* edit = appendEditCombo();
     KABC::PhoneNumber phoneNumber;
     phoneNumber.setType( KABC::PhoneNumber::Home | KABC::PhoneNumber::Pref );
     edit->setPhoneNumber( phoneNumber  );
-    edit = mTypeNumberEditList.next();
+    edit = appendEditCombo();
     phoneNumber.setType( KABC::PhoneNumber::Work | KABC::PhoneNumber::Pref );
     edit->setPhoneNumber( phoneNumber  );
-    edit = mTypeNumberEditList.next();
+    edit = appendEditCombo();
     phoneNumber.setType( KABC::PhoneNumber::Cell );
     edit->setPhoneNumber( phoneNumber  );
-    edit = mTypeNumberEditList.next();
-    while ( edit ) {
-        edit->hide();
-        edit = mTypeNumberEditList.next();
-    }
+
 }
 void  PhoneEditWidget::addNumber()
@@ -112,4 +107,5 @@ PhoneTypeNumberEdit* PhoneEditWidget::appendEditCombo()
     connect ( edit, SIGNAL ( typeChange( int , int) ), this, SIGNAL ( typeChange( int , int)) );
     connect ( edit, SIGNAL ( modified() ), this, SIGNAL ( modified() ) );
+    connect ( edit, SIGNAL ( deleteMe( PhoneTypeNumberEdit* ) ), this, SLOT ( deleteEdit(  PhoneTypeNumberEdit*) ) );
     connect ( this, SIGNAL ( typeChange( int , int)), edit, SLOT ( typeExternalChanged( int, int)) );
 
@@ -119,4 +115,15 @@ PhoneTypeNumberEdit* PhoneEditWidget::appendEditCombo()
 }
 
+void PhoneEditWidget::deleteEdit(  PhoneTypeNumberEdit* ew )
+{
+    mPendingDelete = ew;
+    QTimer::singleShot( 0, this, SLOT ( pendingDelete() ) ); 
+}
+void PhoneEditWidget::pendingDelete()
+{ 
+    mTypeNumberEditList.removeRef( mPendingDelete );
+    emit modified();
+}
+
 void PhoneEditWidget::setPhoneNumbers( const KABC::PhoneNumber::List &li )
 {
@@ -124,8 +131,9 @@ void PhoneEditWidget::setPhoneNumbers( const KABC::PhoneNumber::List &li )
         setDefaults();
         return;
-    }
+    }   
+    mTypeNumberEditList.clear();
     KABC::PhoneNumber::List::Iterator it; 
     KABC::PhoneNumber::List list = li;
-    PhoneTypeNumberEdit* edit = mTypeNumberEditList.first();
+    PhoneTypeNumberEdit* edit = 0;//mTypeNumberEditList.first();
     for ( it = list.begin(); it != list.end(); ++it ) {
         if ( edit ) {
@@ -141,6 +149,4 @@ void PhoneEditWidget::setPhoneNumbers( const KABC::PhoneNumber::List &li )
         edit = mTypeNumberEditList.next();
     }
-    //mainLayout->invalidate ();
-    mw->update();
 }
 KABC::PhoneNumber::List PhoneEditWidget::phoneNumbers()
@@ -516,4 +522,5 @@ PhoneEditDialog::PhoneEditDialog( const KABC::PhoneNumber::List &list, QWidget *
 PhoneEditDialog::~PhoneEditDialog()
 {
+    qDebug("PhoneEditDialog::~PhoneEditDialog() ");
 }
 
diff --git a/kaddressbook/phoneeditwidget.h b/kaddressbook/phoneeditwidget.h
index 6a514ed..c730c7b 100644
--- a/kaddressbook/phoneeditwidget.h
+++ b/kaddressbook/phoneeditwidget.h
@@ -67,8 +67,11 @@ class PhoneEditWidget : public QScrollView
 
   private slots:
-    void  addNumber();
+    void deleteEdit(  PhoneTypeNumberEdit* ew );
+    void addNumber();
+    void pendingDelete();
   protected:
 
   private:
+    PhoneTypeNumberEdit* mPendingDelete;
     void setDefaults();
     PhoneTypeNumberEdit* appendEditCombo();
@@ -213,7 +216,8 @@ public:
                    this, SLOT (  textChanged ( const QString & ) ) );
           mCombo->insertStringList(  PhoneNumber::supportedTypeListNames() );
-          mIsValid = true;
       }
-
+        ~PhoneTypeNumberEdit() {
+            // qDebug("~PhoneTypeNumberEdit() ");
+        }
   void setPhoneNumber( const KABC::PhoneNumber &phoneNumber )
   {
@@ -222,5 +226,4 @@ public:
       mCombo->setCurrentItem( index );
       mNumber->setText( mPhoneNumber.number() );
-      mIsValid = true;
       show();
 
@@ -235,5 +238,4 @@ public:
   bool isValid()
   {
-      if ( !mIsValid ) return false;
       if ( mNumber->text().isEmpty() )return false;
       return true;
@@ -250,7 +252,5 @@ public:
   void deleteNumber()
   { 
-      emit modified();
-      hide();
-      mIsValid = false;
+      emit deleteMe( this );
   }
   void comboTypeChange( int index )
@@ -276,7 +276,7 @@ public:
 void  typeChange( int oldType, int newType );
  void modified();
+ void deleteMe(  PhoneTypeNumberEdit* );
 
 private:
- bool mIsValid;
   KABC::PhoneNumber mPhoneNumber;
   QPushButton* mMinusButton;