author | Mark Lodato <lodatom@gmail.com> | 2010-09-04 15:30:18 (UTC) |
---|---|---|
committer | Mark Lodato <lodatom@gmail.com> | 2010-09-04 15:35:38 (UTC) |
commit | e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2 (patch) (unidiff) | |
tree | 2ade0bb45e15ad5466ca4d3433201477f0c9214e /ui-log.c | |
parent | a4c58d92bfee0cf2e35ab1c5e828a6d790108a69 (diff) | |
download | cgit-e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2.zip cgit-e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2.tar.gz cgit-e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2.tar.bz2 |
fix errors in printf-style format strings
There were many places where the arguments to a printf-like function did
not match the format string. Mostly, these were a missing 'l' flag, but
there were three exceptions:
- In ui-stats.c, a size_t argument must be printed. C99 has the "%zu"
flag for this purpose, but not all compilers support this. Therefore,
we mimic what git does - use a NO_C99_FORMAT Makefile variable.
- In ui-stats.c, cgit_print_error() was called with a pointer instead of
a character.
- In ui-log.c, the "columns" argument was never used.
Signed-off-by: Mark Lodato <lodatom@gmail.com>
-rw-r--r-- | ui-log.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -215,34 +215,33 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern | |||
215 | 215 | ||
216 | for (i = 0; i < ofs && (commit = get_revision(&rev)) != NULL; i++) { | 216 | for (i = 0; i < ofs && (commit = get_revision(&rev)) != NULL; i++) { |
217 | free(commit->buffer); | 217 | free(commit->buffer); |
218 | commit->buffer = NULL; | 218 | commit->buffer = NULL; |
219 | free_commit_list(commit->parents); | 219 | free_commit_list(commit->parents); |
220 | commit->parents = NULL; | 220 | commit->parents = NULL; |
221 | } | 221 | } |
222 | 222 | ||
223 | for (i = 0; i < cnt && (commit = get_revision(&rev)) != NULL; i++) { | 223 | for (i = 0; i < cnt && (commit = get_revision(&rev)) != NULL; i++) { |
224 | print_commit(commit); | 224 | print_commit(commit); |
225 | free(commit->buffer); | 225 | free(commit->buffer); |
226 | commit->buffer = NULL; | 226 | commit->buffer = NULL; |
227 | free_commit_list(commit->parents); | 227 | free_commit_list(commit->parents); |
228 | commit->parents = NULL; | 228 | commit->parents = NULL; |
229 | } | 229 | } |
230 | if (pager) { | 230 | if (pager) { |
231 | htmlf("</table><div class='pager'>", | 231 | html("</table><div class='pager'>"); |
232 | columns); | ||
233 | if (ofs > 0) { | 232 | if (ofs > 0) { |
234 | cgit_log_link("[prev]", NULL, NULL, ctx.qry.head, | 233 | cgit_log_link("[prev]", NULL, NULL, ctx.qry.head, |
235 | ctx.qry.sha1, ctx.qry.vpath, | 234 | ctx.qry.sha1, ctx.qry.vpath, |
236 | ofs - cnt, ctx.qry.grep, | 235 | ofs - cnt, ctx.qry.grep, |
237 | ctx.qry.search, ctx.qry.showmsg); | 236 | ctx.qry.search, ctx.qry.showmsg); |
238 | html(" "); | 237 | html(" "); |
239 | } | 238 | } |
240 | if ((commit = get_revision(&rev)) != NULL) { | 239 | if ((commit = get_revision(&rev)) != NULL) { |
241 | cgit_log_link("[next]", NULL, NULL, ctx.qry.head, | 240 | cgit_log_link("[next]", NULL, NULL, ctx.qry.head, |
242 | ctx.qry.sha1, ctx.qry.vpath, | 241 | ctx.qry.sha1, ctx.qry.vpath, |
243 | ofs + cnt, ctx.qry.grep, | 242 | ofs + cnt, ctx.qry.grep, |
244 | ctx.qry.search, ctx.qry.showmsg); | 243 | ctx.qry.search, ctx.qry.showmsg); |
245 | } | 244 | } |
246 | html("</div>"); | 245 | html("</div>"); |
247 | } else if ((commit = get_revision(&rev)) != NULL) { | 246 | } else if ((commit = get_revision(&rev)) != NULL) { |
248 | html("<tr class='nohover'><td colspan='3'>"); | 247 | html("<tr class='nohover'><td colspan='3'>"); |